[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-12 Thread Marius
Cool. Br's, Marius On Jan 12, 9:50 pm, Alex Boisvert wrote: > I like it a lot.   Eliminates recent confusion about submit() in ajaxForm, > prettier and semantically more correct than hidden fields and supports > multiple actions.  What's not to like? > > alex > > On Tue, Jan 12, 2010 at 2:39 PM,

[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-14 Thread Marius
Most likely I'll commit it today in master as it was approved by review board. Br's, Marius On Jan 14, 9:53 am, Adam Warski wrote: > I would of course be very +1 to include the ajaxSubmit :). Thanks for the > work. > > This looks a bit different to the button I tried before, maybe you have a >

[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-15 Thread Marius
On Jan 15, 11:05 am, Adam Warski wrote: > Hello, > > I tried the trunk version and again it almost works :) > > 1. the RequestVars aren't preserved for the ajax request. I think this can be > fixed by replacing in SHtml:692 the NFuncHolder with a call to > contextFuncBuilder, so the method wou

[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-15 Thread Marius
On Jan 15, 5:59 pm, Adam Warski wrote: > Hello, > > > Oh yeah contextFuncBuider ... good catch. I'll update today. > > thanks :) done. > > > > >> 2. The button will work only with full ajax-forms right? So forms wrapped > >> with ajaxForm(...)? My initial use-case was for adding some ajax but

[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-15 Thread Marius
Ok I just looked on your code. The problem is that you put the ajax button inside the form and there is not reason for that. I changed your code to something like: bind("cont", containerTemplate, "name" -> { println("bind container name " + cont.name); SHtml.text(cont.name,

[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-16 Thread Marius
On Jan 16, 12:02 pm, Adam Warski wrote: > Hello, > > > Ok I just looked on your code. The problem is that you put the ajax > > button inside the form and there is not reason for that. > > Well, unless I do want the button to be inside the form ;) (for > user-experience/layout reasons). Although

[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-16 Thread Marius
On Jan 16, 7:08 pm, Adam Warski wrote: > Hello, > > >> Hmm yes I wondered if the order in which the functions are bound is > >> significant, but my experiments showed that it's not simply a "first > >> bound, first called" principle. So I don't quite get it yet why it doesn't > >> work. > > >

[Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-18 Thread Marius
Hi, Something puzzled me about this as in firebug the parameters order was correct. So here is the explanation why it doesn't for with your code: 1. HTTP parameters MAY arrive in an unpredictable order into the servlet. Container may alter their order due to use of maps etc, or browsers may even

Re: [Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-15 Thread Adam Warski
Hello, I tried the trunk version and again it almost works :) 1. the RequestVars aren't preserved for the ajax request. I think this can be fixed by replacing in SHtml:692 the NFuncHolder with a call to contextFuncBuilder, so the method would look like this: def doit = makeFormElementWithName(

Re: [Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-15 Thread Adam Warski
Hello, > Oh yeah contextFuncBuider ... good catch. I'll update today. thanks :) >> >> 2. The button will work only with full ajax-forms right? So forms wrapped >> with ajaxForm(...)? My initial use-case was for adding some ajax buttons to >> normal forms (submitted with a normal http request)

Re: [Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-15 Thread Adam Warski
> I kinda doubt that as I tested with a bunch of form fields. In the > ajax request the function ID of the ajax function was always the last > in the parameters and functions are evaluated in canonical order (for > the same owner). But I think you sent me your source code location and > I need to

Re: [Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-16 Thread Adam Warski
Hello, >> Hmm yes I wondered if the order in which the functions are bound is >> significant, but my experiments showed that it's not simply a "first bound, >> first called" principle. So I don't quite get it yet why it doesn't work. > > We rely on JQuery (or other underlying library) to send t

Re: [Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-18 Thread Adam Warski
Hello, > Right ... and it's not even a hack ... css is the right way of > building layout not really the html. Putting buttons "in the form" ar > giving this perception in the page doesn't mean that the button has to > be physically in the form element (at least that's the way I see > it.). actua

Re: [Lift] Re: Ajax forms and (multiple) submit buttons

2010-01-19 Thread Adam Warski
Hello, > 1. HTTP parameters MAY arrive in an unpredictable order into the > servlet. Container may alter their order due to use of maps etc, or > browsers may even alter it. The point is that parameters order for > "application/x-www-form-urlencoded" is not specified. didn't know that - something