[Lift] Re: How to remove leading text in Msgs.error

2009-06-08 Thread marius d.
Well good question but since the snippet usage didn't actually change it would be used in the same manner. Just that we don't put a default title anymore. I am planning to optimize a bit the implementation but after this sits there for a little while. For instance:

[Lift] Re: How to remove leading text in Msgs.error

2009-06-07 Thread Jeppe Nejsum Madsen
On Fri, Jun 5, 2009 at 6:05 PM, marius d. wrote: > > Committed. Let me know if that works for you. > Works perfectly. Thanks /Jeppe --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this grou

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread Timothy Perrett
Hey Marius, I see the commit - sweet work. For the sake of completeness in this thread and useful archives, it would probably be most helpful to just round up with an example :-) Cheers, Tim On Jun 5, 5:05 pm, "marius d." wrote: > Committed. Let me know if that works for you. --~--~-~

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread marius d.
Committed. Let me know if that works for you. On Jun 5, 6:31 pm, "marius d." wrote: > Oh right ..that  makes sense. Thanks Derek ! > > On Jun 5, 6:28 pm, Derek Chen-Becker wrote: > > > Well, I meant for a period of time, since we're changing default behavior. > > If someone expects an empty nod

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread marius d.
Oh right ..that makes sense. Thanks Derek ! On Jun 5, 6:28 pm, Derek Chen-Becker wrote: > Well, I meant for a period of time, since we're changing default behavior. > If someone expects an empty node to render default messages and then > upgrades to 1.1 and it stops spitting it out, that would

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread Derek Chen-Becker
Well, I meant for a period of time, since we're changing default behavior. If someone expects an empty node to render default messages and then upgrades to 1.1 and it stops spitting it out, that would be confusing. Kind of a deprecation warning, so to speak. Derek On Fri, Jun 5, 2009 at 8:25 AM,

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread marius d.
Personally I don't think that a debug warning is necessary ... since if the node is empty it is very intuitive for the user that nothing will be rendered there which leads to an intended behavior. Br's, Marius On Jun 5, 5:06 pm, Derek Chen-Becker wrote: > +1. If someone explicitly sets it to em

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread KWright
I'm currently working on an alternative that allows errors to be displayed as part of a nodeset using a surround/bind idiom. Should be ready just as soon as I get the ajax side of things straightened out... My goal is different in that I wanted to be able to display errors using a jquery-ui them

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread Derek Chen-Becker
+1. If someone explicitly sets it to empty then we should honor that, although I wonder if we should emit a debug-level warning. Derek On Fri, Jun 5, 2009 at 7:26 AM, Bryan. wrote: > > +1 on removing the default text. > > --Bryan > > On Jun 5, 6:46 am, "marius d." wrote: > > The reason for tha

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread Bryan.
+1 on removing the default text. --Bryan On Jun 5, 6:46 am, "marius d." wrote: > The reason for that is that if the node text is empty (and yes we > explicitly trim it) we render the default text. To be honest I'm not a > fan of this approach either. I think it should be ok to just not > render

[Lift] Re: How to remove leading text in Msgs.error

2009-06-05 Thread marius d.
The reason for that is that if the node text is empty (and yes we explicitly trim it) we render the default text. To be honest I'm not a fan of this approach either. I think it should be ok to just not render a default text. Does anyone have any objections? If not I could change this real quick, i