It's done.
On Mar 16, 3:05 am, David Pollak
wrote:
> Marius,
> Go ahead and make the change. I think I'm the only one using the OpenID
> stuff and I'm happy to fix it.
>
> The following maven packages are heavily used and I consider it a serious
> negative to break APIs: lift-util, lift-http, a
Marius,
Go ahead and make the change. I think I'm the only one using the OpenID
stuff and I'm happy to fix it.
The following maven packages are heavily used and I consider it a serious
negative to break APIs: lift-util, lift-http, and lift-mapper. The others I
consider to be a little more slushy
I confess I replied without context (OpenIDConsumer being sparely used in
application code, if at all).
One question that comes to my mind is whether OpenIDConsumer should be
regarded as api at all.
If yes I would still opt not breaking api in minor releases.
If not, api and non-api should be more
+1 Charles... (... I would rather avoid diverging into a philosophical
discussion). I wonder if there is someone out there that actually used
directly OpenIDConsumer ... it's likely not break anything since
Lift's OpenID support is pretty undocumented ... till now. Furthermore
I opted in for renam
I would argue the reverse. Naming consistency is forever. Breaking the
API is once, and affects only a small number of developers. I, for one,
when I start using OpenID, will be screwing that up over and over again
as my brain refuses to remember which one is all caps and which is mixed
case.
Good points but OpenIdConsumer is typically not directly used. To make
it work from your application you just use OpenIdVendor
On Mar 15, 8:52 pm, Jan Lohre wrote:
> Breaking the api IMHO needs stronger justification than naming consistency.
>
> But thats just my two cents.
>
> Kind regards,
> J
Breaking the api IMHO needs stronger justification than naming consistency.
But thats just my two cents.
Kind regards,
Jan
2009/3/15 Marius
>
> Folks,
>
> Writing about OpenID in LIftBook inherently made me use it so I can
> use valid examples. Everything worked smoothly ... util I turned off
