- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
I hope it's ok I've pushed this instead of James :)
commit df0ca89d232ca1811605c0a5acc753b6783d8293
Author: Torsten Hämmerle
Date: Mon Apr 16 00:35:08 2018 +0200
issue 5307: Skyline Refi
- **Patch**: countdown --> push
- **Comment**:
Patch counted down - please push.
---
** [issues:#5307] Skyline Refinements (Rounded Boxes and Rotated Ellipses)**
**Status:** Started
**Created:** Sun Apr 15, 2018 09:46 PM UTC by Torsten Hämmerle
**Last Updated:** Tue Apr 24, 2018 11:10 AM UTC
- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for April 27th.
---
** [issues:#5307] Skyline Refinements (Rounded Boxes and Rotated Ellipses)**
**Status:** Started
**Created:** Sun Apr 15, 2018 09:46 PM UTC by Torsten Hämmerle
**Last Updated:** Sat Apr 21, 2018 11:38 AM U
Passes make, make check and a full make doc.
Reg test diffs can be downloaded from here:
https://cloud.indie.host/s/T8r3rKBMqKLgwYr
---
** [issues:#5307] Skyline Refinements (Rounded Boxes and Rotated Ellipses)**
**Status:** Started
**Created:** Sun Apr 15, 2018 09:46 PM UTC by Torsten Hämme
- **Needs**: -->
- **Patch**: new --> review
- **Type**: --> Enhancement
- **Comment**:
Passes make, make check and a full make doc.
Reg test diffs can be downloaded from here:
https://cloud.indie.host/s/T8r3rKBMqKLgwYr
---
** [issues:#5307] Skyline Refinements (Rounded Boxes and Rotate
Wrap lines, consistent quantization/radius
http://codereview.appspot.com/341140043
---
** [issues:#5307] Skyline Refinements (Rounded Boxes and Rotated Ellipses)**
**Status:** Started
**Created:** Sun Apr 15, 2018 09:46 PM UTC by Torsten Hämmerle
**Last Updated:** Sat Apr 21, 2018 10:24 AM UTC
- Description has changed:
Diff:
--- old
+++ new
@@ -1,3 +1,5 @@
+http://codereview.appspot.com/341140043
+
Recently, there have been some discussions about mysterious spacing of
\rounded-box markup.
Harm identified skyline problems as the cause and submitted the following bug
report:
issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses)
lily/stencil-integral.cc
function make_partial_ellipse_boxes:
Use correct scaling factors for x_rad and y_rad for an arbitrary
transformation matrix
This affects calculation of quantisation value
function make_round_filled_box
# (3) Boxes with more detailed outlines
**Straight lines**
The straight lines are drawn as one simple boxes each (if horizontal).
If they are sloped, they will be drawn as buildings (cf. sloped beams) in order
to get nice and
smooth lines without unneccessary staircase optics. Therefore, I had to
# (2) Simple Boxes
Admittedly, the vast majority of boxes is neither rotated nor has it rounded
corners with considerable radius. The most prominent example of round filled
boxes probably are ledger lines.
Therefore, I consider it important to keep the simple cases simple.
* It's very easy to s
# (1) Rotating Ellipses
This was rather a side-effect when working on boxes with rounded corners.
Ellipse skylines are built out of a number of rectangular boxes and the number
of boxes needed is depending on the circumference: the longer the line, the
more intermediate points are needed.
**Wher
Veeery nice :-)
---
** [issues:#5307] Skyline Refinements (Rounded Boxes and Rotated Ellipses)**
**Status:** Started
**Labels:** re
**Created:** Sun Apr 15, 2018 09:46 PM UTC by Torsten Hämmerle
**Last Updated:** Sun Apr 15, 2018 10:23 PM UTC
**Owner:** Torsten Hämmerle
**Attachments:**
-
[s
Before uploading the patch, here's the new rendering of the above file:
All the best,
Torsten
Attachments:
-
[skylines-boxes-2-21-0.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/9ffd3aa8/66df/attachment/skylines-boxes-2-21-0.png)
(71.1 kB; image/png)
---
** [issues:#
Rotations by anything than multiples of 90° cannot work revertably for either
bounding boxes or skylines. They could be made to work for convex hulls and/or
complete outlines. Convex hulls would allow tighter placement than bounding
rectangles but would work worse than skylines for a number of
---
** [issues:#5307] Skyline Refinements (Rounded Boxes and Rotated Ellipses)**
**Status:** Started
**Labels:** re
**Created:** Sun Apr 15, 2018 09:46 PM UTC by Torsten Hämmerle
**Last Updated:** Sun Apr 15, 2018 09:46 PM UTC
**Owner:** Torsten Hämmerle
**Attachments:**
-
[skylines-boxes-2
15 matches
Mail list logo