[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: ~~~ issue 5312: Key cancellation glyph position inconsistent staging author Torsten Hämmerle Tue, 24 Apr 2018 17:54:17 +0100 (18:54 +0200) committer

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

- **Patch**: review --> countdown - **Comment**: Patch on countdown for April 30th. --- ** [issues:#5312] Key cancellation glyph position inconsistent** **Status:** Started **Created:** Mon Apr 23, 2018 05:42 PM UTC by pkx166h **Last Updated:** Wed Apr 25, 2018 08:03 AM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

- **Patch**: new --> review - **Type**: --> Enhancement --- ** [issues:#5312] Key cancellation glyph position inconsistent** **Status:** Started **Created:** Mon Apr 23, 2018 05:42 PM UTC by pkx166h **Last Updated:** Wed Apr 25, 2018 08:03 AM UTC **Owner:** Torsten Hämmerle **Attachments:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

Passes make, make check and a full make doc. Reg test diffs can be downloaded from here: https://cloud.indie.host/s/48HekyfYcZexSXG --- ** [issues:#5312] Key cancellation glyph position inconsistent** **Status:** Started **Created:** Mon Apr 23, 2018 05:42 PM UTC by pkx166h **Last Updated:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

Patch submitted. In order to be able to distinguish between two natural glyphs just touching at the corners or a real at-length overlap, I'm now using two intervals representing the actual glyph shapes: They either just touch or overlap. See attached PNG comparing the old and new kerning model.

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

- Description has changed: Diff: --- old +++ new @@ -1,3 +1,5 @@ +http://codereview.appspot.com/343020043 + From: foxfanfare - **Needs**: --> - **Type**: --> --- ** [issues:#5312] Key cancellation glyph position inconsistent** **Status:** Started **Created:** Mon

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

issue 5312: Key cancellation glyph position inconsistent file lily/key-signature-interface.cc Using two intervals representing the "vertical skylines" of two adjacent natural glyphs. This makes a better model of the actual glyph shape than the original single point within an inverval. Now we can

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

Adding possible 'workaround' (at least for flats) from Harm in casse someone else needs it. --- Hi, I played a little with 'padding-pairs. Obviously the execption to add 0.3 padding in key-signature-interface.cc only applies if 'padding-pairs is unset. Below is limited to flat-cancellation:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

- **status**: New --> Started - **assigned_to**: Torsten Hämmerle --- ** [issues:#5312] Key cancellation glyph position inconsistent** **Status:** Started **Created:** Mon Apr 23, 2018 05:42 PM UTC by pkx166h **Last Updated:** Mon Apr 23, 2018 06:02 PM UTC **Owner:** Torsten Hämmerle

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5312 Key cancellation glyph position inconsistent

As already stated in the thread, this has nothing to do with clefs at all. This occurs when cancelling flat key signature while sharp key signature cancelling looks OK. In fact, it's the vertical distance of adjacent natural signs that make the gap look OK or too close when they touch: The