which version to use for a convert-ly rule?

2009-02-26 Thread Andrew Hawryluk
I've pulled from origin and fixed a bug (don't get too excited - it may have been the tiniest bug ever): http://code.google.com/p/lilypond/issues/detail?id=729 I see that the most recent rule is 2.13.0, so my rule should be 2.13.x where x >= 0. Do I use the current development version or current +

Please fix: release show stopppers

2009-02-26 Thread Han-Wen Nienhuys
Doc build: -master/Documentation/devel/compiling.itexi:2: warning: unreferenced node `Compiling from source'. makeinfo: Removing output file `out/contrib-guide.txt' due to errors; use --force to preserve. Dist error: file from VC not distributed: lilypond-2.13.0/Documentation/ja/user/i18n/ja -

Re: [PATCH] Completion_heads_engraver broken?

2009-02-26 Thread Joe Neeman
On Thu, 2009-02-26 at 11:23 +0100, Michael Käppler wrote: > Hi all, > I don't completely understand the way how Duration::Duration(Rational r, > bool scale) converts a rational number into a note and dots, but > it's clear that the Completion_heads issue with splitting up breve and > longa notes

Re: [frogs] Re: What's up with the Frogs?

2009-02-26 Thread Carl D. Sorensen
On 2/24/09 6:53 PM, "Andrew Hawryluk" wrote: > > I will take a look. Any advice on identifying an easy bug vs. a very > hard one? Most of the ones that really bother me (e.g. #379) have > turned out to be really nasty, and therefore not a good place to > start. I have no great ideas for this

Re: [PATCH] Completion_heads_engraver broken?

2009-02-26 Thread Michael Käppler
Both fixed. Other comments? >From c30a3049063acb270332d6f83a43a808a4893b16 Mon Sep 17 00:00:00 2001 From: root Date: Thu, 26 Feb 2009 13:19:48 +0100 Subject: [PATCH] This fixes an endless loop in duration.cc:67 when Duration::Duration(Rational r, bool scale) is called with r.num() >= 2 * r.den(

Re: [PATCH] Completion_heads_engraver broken?

2009-02-26 Thread David Kastrup
Michael Käppler writes: > Nevertheless, please test and critizize! > +inline int > +shift_left (int value, int shiftamount) > +{ > + if (shiftamount < 0) return (value >> abs(shiftamount)); > + else return (value << shiftamount); > +} I would not use abs(shiftamount) here, but -shiftamount si

Re: [PATCH] Completion_heads_engraver broken?

2009-02-26 Thread Michael Käppler
Hi all, I don't completely understand the way how Duration::Duration(Rational r, bool scale) converts a rational number into a note and dots, but it's clear that the Completion_heads issue with splitting up breve and longa notes was caused by the way << behaves when given a negative number as s