Re: Improve implementation of dashed slurs

2009-04-17 Thread Werner LEMBERG
> An example of a useful dashed bezier-sandwich arpeggio would be when > indicating arpeggios presumed to have been accidentally omitted from > a manuscript, within an urtext edition. I don't think so. The proper way would be rather to use an arpeggio typeset with a smaller design size. IMHO a

Re: Improve implementation of dashed slurs

2009-04-17 Thread Carl D. Sorensen
On 4/17/09 1:47 PM, "joenee...@gmail.com" wrote: > Very pretty slurs! Thanks! > > > http://codereview.appspot.com/41099/diff/1021/59 > File lily/bezier.cc (right): > > http://codereview.appspot.com/41099/diff/1021/59#newcode275 > Line 275: Bezier::subdivide (Real t, Bezier &left_part, Bez

Re: adding snippets manually

2009-04-17 Thread Carl D. Sorensen
On 4/17/09 9:16 PM, "Graham Percival" wrote: > On Fri, Apr 17, 2009 at 05:38:22PM -0600, Carl D. Sorensen wrote: >> >> In order to build my docs, I copied the file from input/new to input/lsr. >> >> I thought that the doc build process would get files from input/new if they >> didn't exist i

adding snippets manually

2009-04-17 Thread Graham Percival
On Fri, Apr 17, 2009 at 05:38:22PM -0600, Carl D. Sorensen wrote: > > In order to build my docs, I copied the file from input/new to input/lsr. > > I thought that the doc build process would get files from input/new if they > didn't exist in input/lsr. > > Can you summarize the process for me?

Re: Improve implementation of dashed slurs

2009-04-17 Thread Mark Polesky
Carl D. Sorensen wrote: > On 4/17/09 1:34 PM, "n.putt...@gmail.com" wrote: > > http://codereview.appspot.com/41099/diff/1021/58 > > File lily/arpeggio.cc (right): > > > > http://codereview.appspot.com/41099/diff/1021/58#newcode168 > > Line 168: Stencil mol (Lookup::slur (curve, lt, lt, SCM_UNDEF

Re: Improve implementation of dashed slurs

2009-04-17 Thread Carl D. Sorensen
On 4/17/09 1:34 PM, "n.putt...@gmail.com" wrote: Thanks for the review, Neil. > > > http://codereview.appspot.com/41099/diff/1021/52 > File Documentation/user/expressive.itely (right): > > http://codereview.appspot.com/41099/diff/1021/52#newcode634 > Line 634: @lilypondfile[verbatim,lilyqu

Re: PATCH -- Dashed Slurs

2009-04-17 Thread Carl D. Sorensen
On 4/17/09 1:58 PM, "Neil Puttock" wrote: > 2009/4/17 Carl D. Sorensen : > >> Does anybody *want* constant-thickness slurs or ties?  I thought that >> variable thickness was clearly better.  I think that keeping inferior output >> to avoid conversion problems is not a good decision.  I'd rath

Re: Fix key signatures with accidentals in specific octave.

2009-04-17 Thread n . puttock
On 2009/04/17 19:25:31, joeneeman wrote: http://codereview.appspot.com/11052/diff/3409/2410 File scm/music-functions.scm (right): http://codereview.appspot.com/11052/diff/3409/2410#newcode1047 Line 1047: ((and (equal? ignore-octave #f) I think eq? is more appropriate here Done. http://code

Re: PATCH -- Dashed Slurs

2009-04-17 Thread Neil Puttock
2009/4/17 Carl D. Sorensen : > Does anybody *want* constant-thickness slurs or ties?  I thought that > variable thickness was clearly better.  I think that keeping inferior output > to avoid conversion problems is not a good decision.  I'd rather force the > user to make a simple manual change and

Re: Improve implementation of dashed slurs

2009-04-17 Thread joeneeman
Very pretty slurs! http://codereview.appspot.com/41099/diff/1021/59 File lily/bezier.cc (right): http://codereview.appspot.com/41099/diff/1021/59#newcode275 Line 275: Bezier::subdivide (Real t, Bezier &left_part, Bezier &right_part) We only use references if they are const (for clarity), so ple

Improve implementation of dashed slurs

2009-04-17 Thread n . puttock
http://codereview.appspot.com/41099/diff/1021/52 File Documentation/user/expressive.itely (right): http://codereview.appspot.com/41099/diff/1021/52#newcode634 Line 634: @lilypondfile[verbatim,lilyquote,texidoc,doctitle] @ignore this unless you're going to run makelsr.py (or create input/lsr file

Re: Fix key signatures with accidentals in specific octave.

2009-04-17 Thread joeneeman
http://codereview.appspot.com/11052/diff/3409/2410 File scm/music-functions.scm (right): http://codereview.appspot.com/11052/diff/3409/2410#newcode1047 Line 1047: ((and (equal? ignore-octave #f) I think eq? is more appropriate here http://codereview.appspot.com/11052/diff/3409/2410#newcode1048

Re: PATCH -- Dashed Slurs

2009-04-17 Thread Carl D. Sorensen
On 4/17/09 1:05 PM, "Neil Puttock" wrote: > Carl, these are brilliant; they look wonderful. Thanks for the compliment. > > I'm just looking through the patch at the moment, so I'll post > comments (mainly trivial things) at Rietveld. I can't really comment > on the implementation itself,

Re: PATCH -- Dashed Slurs

2009-04-17 Thread Neil Puttock
2009/4/17 Carl Sorensen : > Carl D. Sorensen byu.edu> writes: > >> >> Please review my patch for dashed slurs on rietveld: >> >> http://codereview.appspot.com/40122/show >> > > I've revised my patch to eliminate some debug garbage that was > left in the files, and to make the bezier subdivide rout

lyrics for right-left writing systems such as hebrew or arabic

2009-04-17 Thread demery
Dumb question, some (perverse?) writing systems are contrary to western music notation, assuming we allow full unicode lyrics, how does one set hebrew or arabic lyrics to western music? Only way I can think of is to (have the user) transliterate phonetically into the roman alphabet, as in - hav

Re: (de)cresendi syntax

2009-04-17 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Freitag, 17. April 2009 schrieb Frédéric Bron: > > Attached is a sample file to show how the definition of spanners could > > work with my patch. I've also implemented two functions to give the text > > of the spanner directly in the postfix call. >

Re: GUB3 at the lilypond-installer stage

2009-04-17 Thread Patrick McCarty
On Fri, Apr 17, 2009 at 10:57:57AM +0200, Jan Nieuwenhuizen wrote: > Op vrijdag 17-04-2009 om 00:29 uur [tijdzone -0700], schreef Patrick > McCarty: > > Hi Patrick, > > > I just tried doing a fresh build with > > > > $ bin/gub tools::bison && bin/gub tools::flex && bin/gub > > mingw::lilypond-i

Re: (de)cresendi syntax

2009-04-17 Thread Frédéric Bron
> Attached is a sample file to show how the definition of spanners could work > with my patch. I've also implemented two functions to give the text of the > spanner directly in the postfix call. When I look at your dynamic_spanners_postfix.pdf file, it seems to me that on the second line (with the

Re: PATCH -- Dashed Slurs

2009-04-17 Thread Carl Sorensen
Carl D. Sorensen byu.edu> writes: > > Please review my patch for dashed slurs on rietveld: > > http://codereview.appspot.com/40122/show > I've revised my patch to eliminate some debug garbage that was left in the files, and to make the bezier subdivide routine work for any degree of bezier cu

Re: PATCH -- Dashed Slurs

2009-04-17 Thread Werner LEMBERG
>> Very nice! What do you think about making `dash-definition' either >> accept a list of four parameters or a list of lists (with four >> parameters each)? Then we could write >> >> #'(a b c d) >> >> and are not forced to use >> >> #'((a b c d)) >> >> if the slur is not split into diffe

Re: PATCH -- Dashed Slurs

2009-04-17 Thread Carl D. Sorensen
On 4/16/09 10:50 PM, "Werner LEMBERG" wrote: >> Please review my patch for dashed slurs on rietveld: > > Very nice! What do you think about making `dash-definition' either > accept a list of four parameters or a list of lists (with four > parameters each)? Then we could write > > #'(a b

Re: GUB3 at the lilypond-installer stage

2009-04-17 Thread Jan Nieuwenhuizen
Op vrijdag 17-04-2009 om 00:29 uur [tijdzone -0700], schreef Patrick McCarty: Hi Patrick, > I just tried doing a fresh build with > > $ bin/gub tools::bison && bin/gub tools::flex && bin/gub > mingw::lilypond-installer > > and I get two configure errors for linux-x86::cross/binutils. I'm > ju

Re: GUB3 at the lilypond-installer stage

2009-04-17 Thread Patrick McCarty
Hi Jan, On Thu, Apr 16, 2009 at 01:43:07PM +0200, Jan Nieuwenhuizen wrote: > Op donderdag 16-04-2009 om 13:10 uur [tijdzone +0200], schreef Jan > Nieuwenhuizen: > > >* it should -C change directory to target/installer/..., > > I see no reason for . to exist, be writable, much less > >