Patrick McCarty wrote:
I just compiled the docs, and it looks great!
Is it ready to apply?
- Mark
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Mark Polesky wrote Saturday, July 11, 2009 11:36 PM
Okay, here's a patch. Can someone test this?
Applies fine and output looks good.
My only comment is the heading - should this
not be changed to The Emmentaler font? See
On za, 2009-07-11 at 07:00 -0500, Jonathan Kulp wrote:
Jan Nieuwenhuizen wrote:
bzr diff -r29..30 sap.1 manpage.patch
Now, it worked, but to me this is harder than git.
I think the equiivalent is a bundle. Also, bzr supports
realative revisions, eg bzr diff -r-1: probably does it.
2009/7/12 Carl Sorensen c_soren...@byu.edu:
I've created a second patch set with the whitespace removed (along with
automatic removal of whitespace from the lines of the files that weren't
part of the patch).
Brilliant work, Carl!
I'll comment on individual issues in Rietveld shortly.
I
2009/7/12 Mark Polesky markpole...@yahoo.com:
Is it ready to apply?
Looks fine.
If I may sugget one refinement: use the quote environment (it produces
nicer looking examples in html).
@lilypond[quote]
Regards,
Neil
___
lilypond-devel mailing list
2009/7/11 Carl Sorensen c_soren...@byu.edu:
Does one then go and remove the snippet reference from the translated .itely
files as well?
This is what I've always done, otherwise you're left with broken documentation.
Regards,
Neil
___
From: Neil Puttock wrote:
@lilypond[quote]
Okay,
here's a new patch using @lilypond[quote]. I'm leaving it called
The Feta font for now. Changing it to The Emmentaler font
would require changing some 50 or so cross-references in the
source and I think that should be a different patch.
Please
On Sun, Jul 12, 2009 at 11:32:24AM -0700, Mark Polesky wrote:
From: Neil Puttock wrote:
@lilypond[quote]
Okay,
here's a new patch using @lilypond[quote]. I'm leaving it called
The Feta font for now. Changing it to The Emmentaler font
would require changing some 50 or so
2009/7/12 Mark Polesky markpole...@yahoo.com:
Please double-check once more and apply.
For some reason, I can't apply it.
Applying: Docs: NR B.6 The Feta font: Organize glyph list.
/home/neil/lilypond/.git/rebase-apply/patch:15: trailing whitespace.
On Sun, Jul 12, 2009 at 09:06:49PM +0100, Neil Puttock wrote:
2009/7/12 Mark Polesky markpole...@yahoo.com:
Please double-check once more and apply.
For some reason, I can't apply it.
Applying: Docs: NR B.6 The Feta font: Organize glyph list.
Patrick McCarty wrote:
Rather weirdly, your earlier patch won't apply now either.
Did you do
git rebase --abort
before trying to apply his earlier patch?
You've got push access now, haven't you? If so, you can do
it yourself.
He doesn't, but he should have access.
2009/7/12 Patrick McCarty pnor...@gmail.com:
Did you do
git rebase --abort
before trying to apply his earlier patch?
Of course. :) I just got confused with different patches and applied
the wrong one.
Regards,
Neil
___
lilypond-devel mailing
On Sun, Jul 12, 2009 at 01:07:22PM -0700, Patrick McCarty wrote:
On Sun, Jul 12, 2009 at 11:32:24AM -0700, Mark Polesky wrote:
From: Neil Puttock wrote:
@lilypond[quote]
Okay,
here's a new patch using @lilypond[quote]. I'm leaving it called
The Feta font for now. Changing it to
On Sun, Jul 12, 2009 at 01:14:23PM -0700, Mark Polesky wrote:
Patrick McCarty wrote:
Rather weirdly, your earlier patch won't apply now either.
Did you do
git rebase --abort
before trying to apply his earlier patch?
You've got push access now, haven't you? If so,
2009/7/10 Maximilian Albert maximilian.alb...@googlemail.com:
OK, thanks. Now the docs compiled fine and I could check that the
result of my patch is as intended. Any further comments or are they
ready to be applied?
Thanks, they're both applied.
Regards,
Neil
Patrick McCarty wrote:
Rechecking your patch, it did in fact have DOS line endings.
So, I changed them to UNIX line endings in Vim:
:set ff=unix
and then it applied cleanly. Maybe something happened between the
creation of the patch and sending the email that changed the line
On Sun, Jul 12, 2009 at 3:31 PM, Mark Polesky markpole...@yahoo.com wrote:
Patrick McCarty wrote:
Rechecking your patch, it did in fact have DOS line endings.
So, I changed them to UNIX line endings in Vim:
:set ff=unix
and then it applied cleanly. Maybe something happened
On Sat, Jul 11, 2009 at 8:25 PM, Maximilian
Albertmaximilian.alb...@googlemail.com wrote:
2009/7/11 Neil Puttock n.putt...@gmail.com:
How about using a `try' block to import conditionally?
Thanks for the suggestion. Here is an updated patch, in case peope
want to have this (otherwise please
Hello,
Here's errata for the LM. Some of these are very subjective, so just
pick and choose what seems appropriate. Others are just typos or
examples that aren't showing up.
Thanks for making the LM so nice!
-Jonathan
1.1 Background
Engraving
1st paragraph:
The plate would be inked,
On 7/12/09 11:13 AM, n.putt...@gmail.com n.putt...@gmail.com wrote:
http://codereview.appspot.com/88155/diff/43/1044
File Documentation/user/rhythms.itely (right):
http://codereview.appspot.com/88155/diff/43/1044#newcode1662
Line 1662: of the beam, e.g. @code{#'(1 . 16)}, or
On 7/12/09 9:43 AM, Neil Puttock n.putt...@gmail.com wrote:
2009/7/12 Carl Sorensen c_soren...@byu.edu:
I've created a second patch set with the whitespace removed (along with
automatic removal of whitespace from the lines of the files that weren't
part of the patch).
Brilliant work,
On 7/12/09 11:13 AM, n.putt...@gmail.com n.putt...@gmail.com wrote:
http://codereview.appspot.com/88155/diff/43/1045
File
input/lsr/automatic-beams-two-per-two-in-4-4-or-2-2-time-signature.ly
(right):
http://codereview.appspot.com/88155/diff/43/1045#newcode1
Line 1: %% Do not edit
On 7/12/09 11:13 AM, n.putt...@gmail.com n.putt...@gmail.com wrote:
http://codereview.appspot.com/88155/diff/43/1045
File
input/lsr/automatic-beams-two-per-two-in-4-4-or-2-2-time-signature.ly
(right):
http://codereview.appspot.com/88155/diff/43/1045#newcode1
Line 1: %% Do not edit
2009/7/13 Neil Puttock n.putt...@gmail.com:
Thanks, they're both applied.
Thanks a lot! So does this close issue 685? What's the status about
.log files being created on Windows mentioned there?
Max
___
lilypond-devel mailing list
24 matches
Mail list logo
