On 6/16/10 9:41 PM, "Han-Wen Nienhuys" wrote:
> [+lilypond-devel, can this be automatic for codereviews?]
Yes -- it's part of the git-cl configuration. Run
git-cl config
and add
lilypond-devel@gnu.org
for the cc: field.
Thanks,
Carl
___
lily
[+lilypond-devel, can this be automatic for codereviews?]
[+jan who may have more substantive arguments on signed vs. unsigned]
On Thu, Jun 17, 2010 at 12:34 AM, wrote:
>
> * can you split this up by type of change? ie. one commit doing
> cosmetics of comments, one changing inline functions, o
On 6/16/10 3:49 PM, "papu...@gmail.com" wrote:
> Reviewers: carl.d.sorensen_gmail.com,
>
> Message:
> I would have split it into chunks, but my main concern was warnings,
> which was present in most of the files. Most of the committed files only
> contain casts.
> Reviewing will take about 1-2 h
Carl, have you looked at the regtest output?
I've copied time-signature-settings.scm from the other set (I assume
it's correct) and run `make check'; there's a significant number of
changed tests showing up. In particular, 6/8, 9/8 and 12/8 tests are
mostly unbeamed.
There's some weirdness goin
Hi Jan,
On 2010/06/16 12:08:06, jan.nieuwenhuizen wrote:
On 2010/06/08 22:22:43, Neil Puttock wrote:
> -) A metronome mark at a full-bar rest should be aligned with the
barline
> instead of the paper column to the left of the rest.
This is not in Read or #684's description...
See http:
Hi Carl,
There's a file missing from this set: time-signature-settings.scm.
Cheers,
Neil
http://codereview.appspot.com/1667044/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Jan,
On 2010/06/15 08:55:49, jan.nieuwenhuizen wrote:
I just rebased the patch onto latest master and did
a fresh build and doc-build
make all all-doc
and cannot reproduce it, the doc builds without problems.
Do you compile with --disable-optimising?
I've done a few more tests,
On 6/16/10 3:18 AM, "Trevor Daniels" wrote:
>
>
> Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM
>
>> Description:
>> Revised autobeam settings patch -- cleaned up debug comments
>> in code and eliminated the irrelevant changes in
>> Documentation/snippets just due to running makelsr.p
My main concern was fixing the warnings (~150, mostly vsize vs. int), and
getting to know the codebase a bit.
However, during this procedure I have changed other things also, typedef-ed
enums, empty else statements, string repeating, unreferenced parameter names
and some random cosmetics
2010/6/16 Hajo Dezelski :
> Hello,
>
> working with windows I uninstalled version 2.13.20 from the menu,
> installed 2.13.24 and have problems.
>
> I use jedit as enviroment:
> 1. The converter to newer versions runs but does nothing.
> 2. More importent: after compiling the ly-code I get the mess
Copying to -devel to get developer feedback, and to bug to get the issue in
the tracker if it belongs there.
On 6/16/10 1:58 AM, "flup2" wrote:
>
> I would like to know if somebody knows how conductng signs (
> http://lsr.dsi.unimi.it/LSR/Item?id=259
> http://lsr.dsi.unimi.it/LSR/Item?id=259 ) a
On 6/16/10 3:18 AM, "Trevor Daniels" wrote:
>
>
> Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM
>
>> Description:
>> Revised autobeam settings patch -- cleaned up debug comments
>> in code and eliminated the irrelevant changes in
>> Documentation/snippets just due to running makelsr
On Tue, 2010-06-15 at 04:09 -0400, Boris Shingarov wrote:
> Hi Joe,
>
> > Could you send me a list of the unreviewed patches that you have on
> > rietveld? I should have time in the next week or so to review them.
> >
>
> This issue is not so much the patches being "unreviewed" but rather
>
Reviewers: Neil Puttock,
Message:
On 2010/06/08 22:22:43, Neil Puttock wrote:
Comments processed in patch 4 & 5.
Here are a few thoughts on positioning:
-) A metronome mark at a full-bar rest should be aligned with the
barline
instead of the paper column to the left of the rest.
This is
Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM
Description:
Revised autobeam settings patch -- cleaned up debug comments
in code and eliminated the irrelevant changes in
Documentation/snippets just due to running makelsr.py
Please review this at http://codereview.appspot.com/1667044/sho
15 matches
Mail list logo
