* David Kastrup wrote on Mon, Aug 16, 2010 at 04:16:49AM CEST:
The problem, as pointed out already, is that the commit affects the bulk
of the indentation in the respective functions, while changing only few
lines of substance.
And that means that it conflicts with any other ongoing work on
Am Sonntag 15 August 2010, um 17:15:55 schrieb David Kastrup:
Not the process per se, but try doing this on Rietveld. Those are lots
of changes in small files. For every single change, you need to tell
the web interface to show you the file difference. You look at it, it
looks ok. Now you
Am Sonntag 15 August 2010, um 15:48:26 schrieb David Kastrup:
What is the general stance towards cleanup (of unused dormant stuff
never documented for general use) like that as long as it is contained
in separate commits and not intermingled with other changes? Should it
be wrapped in a full
Looks mostly good.
http://codereview.appspot.com/2004041/diff/1/2
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/2004041/diff/1/2#newcode110
Documentation/notation/input.itely:110: @file{fandangoforelephants.pdf}
(or @file{fandangoforelephants.png},
or .eps, or
Reviewers: Graham Percival,
http://codereview.appspot.com/2004041/diff/1/2
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/2004041/diff/1/2#newcode110
Documentation/notation/input.itely:110: @file{fandangoforelephants.pdf}
(or @file{fandangoforelephants.png},
On
Looks good to me. Could you send me the patch (privately) so I can
push it correctly attributed to you?
David: yes, I've already complained about Rietveld's atrocious lack of
the real patch file.
Cheers,
- Graham
On Mon, Aug 16, 2010 at 2:48 PM, i...@hulin.org.uk wrote:
Reviewers: Graham
Le 16 août 2010 à 01:33, carl.d.soren...@gmail.com a écrit :
LGTM.
Further info: This code has been in the file since
114c05e7b0e992de7dbdd0958d23eb8d2ab1eaae
(the file name at that time was scm/new-markup.scm).
I think that the alternate syntax has never been used in the main source
Eluze wrote Sunday, August 15, 2010 10:20 AM
Trevor Daniels wrote:
The mingw binary of 2.13.30 gives the following error
under Vista on my system:
Running lilypond-book
Traceback (most recent call last):
File c:/program files/lilypond/usr/bin/lilypond-book.py, line
86, in ?
import
