On Sat, Aug 28, 2010 at 4:16 PM, Ian Hulin wrote:
> (define (make-music-type-predicate . music-types)
> (define ((make-music-type-predicate-aux mtypes) expr)
> (if (null? mtypes)
> #f
> (or (eqv? (car mtypes) (ly:music-property expr 'name))
> ((make-music-type-predicat
Am Montag, 30. August 2010, um 00:25:47 schrieben Sie:
> > I don't really see any other way to turn the input path to an
> > absolute path
> > than calling os.path.abspath, in particular, since the input path
> > can already
> > be an absolute path...
>
> But doesn't this solution create a worse p
Graham Percival wrote Sunday, August 29, 2010 9:48 PM
On Sun, Aug 29, 2010 at 07:09:01PM +0100, Trevor Daniels wrote:
I think we need to reorganise the first few sections
of Vocal a little.
I like it. You have slightly more inside 2.1.1 than I would have
initially guessed, but I've always
On 2010/08/29 22:02:18, Neil Puttock wrote:
On 2010/08/29 19:54:28, Reinhold wrote:
> First, great to see that this feature has finally been implemented
and pushed.
> Unfortunately, it seems that it needs some small tweaking, still.
The problem
is
> that the metronome mark is now placed direc
Graham Percival wrote Monday, August 30, 2010 12:02 AM
On Sun, Aug 29, 2010 at 11:25:47PM +0100, Trevor Daniels wrote:
I have to copy an old version of
lilypondbook into every new release in order to get
a working version. We can't expect users to do that.
I'm confused about what's going
On Sun, Aug 29, 2010 at 11:25:47PM +0100, Trevor Daniels wrote:
>
> I have to copy an old version of
> lilypondbook into every new release in order to get
> a working version. We can't expect users to do that.
I'm confused about what's going on. Are you talking about 1226
(which is claimed to b
Reinhold Kainhofer wrote Sunday, August 29, 2010 8:33 PM
Thanks, Trevor, for you bisecting... The culprit is actually not
the
refactoring, but a bug fix I did before the refactoring (commit
4da9fc65cbf74f4cbbdb01add4d5f341a16f5065 at 10.06.10 13:01).
The problem I fixed with it was quite ugl
On 2010/08/29 19:54:28, Reinhold wrote:
First, great to see that this feature has finally been implemented and
pushed.
Unfortunately, it seems that it needs some small tweaking, still. The
problem is
that the metronome mark is now placed directly above the key
signature, while
Gardner Read
On Sun, Aug 29, 2010 at 07:09:01PM +0100, Trevor Daniels wrote:
>
> Graham Percival wrote Friday, August 27, 2010 9:54 PM
>
> >I know you didn't say to look at NR 2.1.1, but I noticed that you
> >used
> >"Common references for vocal music" instead of the standard
> >"References for vocal music".
On Sun, Aug 29, 2010 at 5:21 PM, Jan Nieuwenhuizen
wrote:
> It's not cyclic, the idea was about not crashing when the data
> structure is not a list at all.
>
> I think Neil had a remark about this.
Most of the similar code uses scm_c_memq instead, which skips the
checking. On closer inspectio
Op zondag 29-08-2010 om 20:09 uur [tijdzone +], schreef
hanw...@gmail.com:
> http://codereview.appspot.com/1579041/diff/42001/43004
> File lily/metronome-engraver.cc (right):
>
> http://codereview.appspot.com/1579041/diff/42001/43004#newcode81
> lily/metronome-engraver.cc:81: }
> is there a re
http://codereview.appspot.com/1579041/diff/42001/43004
File lily/metronome-engraver.cc (right):
http://codereview.appspot.com/1579041/diff/42001/43004#newcode81
lily/metronome-engraver.cc:81: }
is there a reason you are worried about cyclical data structures? I
don't think we check for them any
First, great to see that this feature has finally been implemented and
pushed.
Unfortunately, it seems that it needs some small tweaking, still. The
problem is that the metronome mark is now placed directly above the key
signature, while Gardner Read says that it "is aligned over the meter
signatu
Op zondag 29-08-2010 om 18:04 uur [tijdzone +], schreef
hanw...@gmail.com:
> http://codereview.appspot.com/1579041/diff/42001/43004#newcode109
> lily/metronome-engraver.cc:109: }
> this is out of style with the rest of lilypond code base.
>
> The normal pattern is to use XXx_interface::has_in
Am Donnerstag, 26. August 2010, um 11:04:15 schrieb Trevor Daniels:
> "Phil Holmes" wrote in message
> news:i53pqa$tp...@dough.gmane.org...
> > Line 4 in the snippet map is
> > #(ly:add-file-name-alist '(("3e/lily-0cba8859.ly" .
> > "C:\Users\Trevor\LilyPond-git\Documentation\music-glossary.tely")
On Sun, Aug 29, 2010 at 3:54 PM, Jan Nieuwenhuizen
wrote:
> Op zondag 29-08-2010 om 18:04 uur [tijdzone +], schreef
> hanw...@gmail.com:
>
>> http://codereview.appspot.com/1579041/diff/42001/43004#newcode109
>> lily/metronome-engraver.cc:109: }
>> this is out of style with the rest of lilypond
Graham Percival wrote Friday, August 27, 2010 9:54 PM
Let's deal with 2.1.1 first.
I know you didn't say to look at NR 2.1.1, but I noticed that you
used
"Common references for vocal music" instead of the standard
"References for vocal music".
Yes, this was because there are specific refere
http://codereview.appspot.com/1579041/diff/42001/43004
File lily/metronome-engraver.cc (right):
http://codereview.appspot.com/1579041/diff/42001/43004#newcode109
lily/metronome-engraver.cc:109: }
this is out of style with the rest of lilypond code base.
The normal pattern is to use XXx_interfac
18 matches
Mail list logo
