Re: T1224: Avoid using deprecated %module-public-interface in initialization (issue2083043)

2010-09-03 Thread ianhulin44
http://www.codereview.appspot.com/2083043/diff/1/2 File lily/ly-module.cc (right): http://www.codereview.appspot.com/2083043/diff/1/2#newcode36 lily/ly-module.cc:36: SCM maker = ly_lily_module_constant(make-module); On 2010/09/02 00:24:02, Neil Puttock wrote: ly_lily_module_constant

Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread percival . music . ca
Reviewers: , Message: This isn't a miracle of clean scheme, but I don't think it's completely horrible, gets the job done, and makes the doc-editor's lives easier. Description: Build: un-nodify markup-*-commands.tely Please review this at http://codereview.appspot.com/2140041/ Affected files:

Re: Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread Carl . D . Sorensen
Looks acceptable to me, with one slight change if it's possible. THanks, Carl http://codereview.appspot.com/2140041/diff/2001/3006 File scm/documentation-generate.scm (right): http://codereview.appspot.com/2140041/diff/2001/3006#newcode56 scm/documentation-generate.scm:56: ;; magic number to

Re: Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread percival . music . ca
On 2010/09/03 17:41:37, Carl wrote: scm/documentation-generate.scm:56: ;; magic number to remove the initial part Can we have something in the comment that says what would have to change in order to change the magic number? Thanks for the comment; done. I should have done this math to

Re: Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread Carl Sorensen
LGTM. Carl On 9/3/10 12:01 PM, percival.music...@gmail.com percival.music...@gmail.com wrote: On 2010/09/03 17:41:37, Carl wrote: scm/documentation-generate.scm:56: ;; magic number to remove the initial part Can we have something in the comment that says what would have to change in

-dinclude-settings=INCLUDEFILE.ly

2010-09-03 Thread -Eluze
New option -dinclude-settings=INCLUDEFILE.ly, which causes lilypond to include the given file before the score is processed. This allows the user to change global settings without the need to change the score itself. That way, several different editions/version (e.g. different page sizes) can be

Re: -dinclude-settings=INCLUDEFILE.ly

2010-09-03 Thread Reinhold Kainhofer
Am Freitag, 3. September 2010, um 22:49:50 schrieb -Eluze: New option -dinclude-settings=INCLUDEFILE.ly, which causes lilypond to include the given file before the score is processed. This allows the user to change global settings without the need to change the score itself. That way, several

Re: -dinclude-settings=INCLUDEFILE.ly

2010-09-03 Thread -Eluze
Reinhold Kainhofer wrote: Am Freitag, 3. September 2010, um 22:49:50 schrieb -Eluze: New option -dinclude-settings=INCLUDEFILE.ly, which causes lilypond to include the given file before the score is processed. This allows the user to change global settings without the need to change the

Re: -dinclude-settings=INCLUDEFILE.ly

2010-09-03 Thread Reinhold Kainhofer
Am Samstag, 4. September 2010, um 00:03:56 schrieb -Eluze: thanks Reinhold it's strange - i tried \\, //, \/ with and without apostrophs …, -dinclude-settings= or without the equal sign - nothing works! How about a simple / ? Also, do you get any error message or warning in the log file?

Re: -dinclude-settings=INCLUDEFILE.ly

2010-09-03 Thread Trevor Daniels
Eluze wrote Friday, September 03, 2010 11:03 PM Reinhold Kainhofer wrote: Am Freitag, 3. September 2010, um 22:49:50 schrieb -Eluze: New option -dinclude-settings=INCLUDEFILE.ly, which causes lilypond to include the given file before the score is processed. This allows the i have tried

Re: -dinclude-settings=INCLUDEFILE.ly

2010-09-03 Thread -Eluze
Trevor Daniels wrote: Eluze wrote Friday, September 03, 2010 11:03 PM Reinhold Kainhofer wrote: Am Freitag, 3. September 2010, um 22:49:50 schrieb -Eluze: New option -dinclude-settings=INCLUDEFILE.ly, which causes lilypond to include the given file before the score is processed.