Re: [PATCH] Add a way to override the part-combination decision

2010-09-16 Thread Han-Wen Nienhuys
On Thu, Sep 16, 2010 at 2:24 PM, Reinhold Kainhofer wrote: > I have now implemented overriding the part-combine decisions. For this, I > abuse \set partcombineForced =... events to extract the desired combination > strategy in the \partcombine function (scheme code in scm/part-combine.scm), > befo

Re: Help understanding how code works (or doesn't)

2010-09-16 Thread Neil Puttock
On 15 September 2010 03:40, Carl Sorensen wrote: > Note that at this point, I haven't changed the value to which I am setting > 'measurePosition.  So, can anybody help me see why this code doesn't work? It looks like adding the extra iteration step (ApplyContext) delays the 'measurePosition sett

Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042)

2010-09-16 Thread n . puttock
Hi Marc, In hide-tab-note-head, you end up setting properties on bounds which aren't noteheads (i.e., for broken bounds, the ties are bound by a NonMusicalPaperColumn); till now you've got away with it, since the properties being set were from the grob-interface (unlike 'details). Try running `m

Part-combine: Add a way to override the part-combination decision by a ctx prop (issue1698054)

2010-09-16 Thread n . puttock
LGTM. http://codereview.appspot.com/1698054/diff/2001/input/regression/part-combine-force.ly File input/regression/part-combine-force.ly (right): http://codereview.appspot.com/1698054/diff/2001/input/regression/part-combine-force.ly#newcode4 input/regression/part-combine-force.ly:4: \partcombin

[PATCH] Add a way to override the part-combination decision

2010-09-16 Thread Reinhold Kainhofer
I have now implemented overriding the part-combine decisions. For this, I abuse \set partcombineForced =... events to extract the desired combination strategy in the \partcombine function (scheme code in scm/part-combine.scm), before the property_iterator actually gets a chance to set those prop

Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042)

2010-09-16 Thread Marc Hohl
carl.d.soren...@gmail.com schrieb: Looks good to me. Just a comment on the name of the new property to be added to details. Thanks, Carl Hello Carl, http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/219104

Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042)

2010-09-16 Thread Carl . D . Sorensen
Looks good to me. Just a comment on the name of the new property to be added to details. Thanks, Carl http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm#newcode1979 scm/defin

[PATCH] Improved behavior for tie/slur and tie/glissando

2010-09-16 Thread Marc Hohl
Hello, the following patch should hopefully remove problems in tablature when a tie is followed by either a slur or a glissando. http://codereview.appspot.com/2191042 Thanks, Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.g