Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread markpolesky
Reviewers: , Message: The vertical dimensions docs in NR 4.1.2 Page formatting are (in my opinion) incredibly confusing. Here's a patch to reorganize that section. One big disclaimer: the information here is presented according to *my* understanding of how these variables were *intended* to

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread tdanielsmusic
Looks a lot clearer to me, Mark, but I can't vouch for the accuracy as I've never tried to use vertical spacing. If the variable table came before the keys table giving a top-down approach it would be even clearer. Trevor http://codereview.appspot.com/2316042/

Re: What's with the spacing code?

2010-10-02 Thread David Kastrup
David Kastrup d...@gnu.org writes: With the current code, a score that used to take 5 pages now takes 8, really really spaced out. I don't see that we can release a version of Lilypond that takes up horrifically more space than the previous not-skyline-based code. Making use of the skyline

Re: What's with the spacing code?

2010-10-02 Thread Phil Holmes
David Kastrup d...@gnu.org wrote in message news:87pqvseosv@lola.goethe.zz... [lots of snipping] This contrived example shows two more issues: issue 1 is that we are estimating too short right now. Issue 2 is more disconcerting: even if things worked like intended, the visual

Re: What's with the spacing code?

2010-10-02 Thread Graham Percival
On Sat, Oct 2, 2010 at 4:36 PM, Phil Holmes m...@philholmes.net wrote: I'm putting together (for fun, and possibly as a large piece of music that can help debugging memory allocation problems) a copy of The Mikado from somewhere around 20 individual pieces of music.  I'm currently at only 2

Re: Style: don't break compiling freetype-errors.cc (issue2144047)

2010-10-02 Thread percival . music . ca
I just checked a second-order diff (i.e. produce a diff by running an unpatched fixcc, then produce a diff by running the patched fixcc, then compare those diffs), and the only two changes are: 1) don't change */ ; into: */; (this seems like a very good change) 2) keep

Re: Optimizations for pure-height approximations. (issue1817045)

2010-10-02 Thread percival . music . ca
Has this patch been pushed, or definitely rejected, or is it waiting for when Joe has some spare time (probably 2011 :) ? http://codereview.appspot.com/1817045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread markpolesky
http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely#newcode200 Documentation/notation/spacing.itely:200: @table @code On 2010/10/02

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Carl . D . Sorensen
On 2010/10/02 16:09:22, Mark Polesky wrote: On 2010/10/02 09:17:16, perpeduumimmobile wrote: Again, it's a reference. We can mentioned Hooke's law, don't we? Okay, here we go... Hooke's law: F=-kx x is the displacement of the end of the spring from its equilibrium position

Re: What's with the spacing code?

2010-10-02 Thread Phil Holmes
Graham Percival gra...@percival-music.ca wrote in message news:aanlktikgcnwttwnkzdtm7jdh_0r8b+mibjq-qgv06...@mail.gmail.com... On Sat, Oct 2, 2010 at 4:36 PM, Phil Holmes m...@philholmes.net wrote: I'm putting together (for fun, and possibly as a large piece of music that can help debugging

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Trevor Daniels
markpolesky wrote Saturday, October 02, 2010 5:09 PM Okay, here we go... Hooke's law: F=-kx x is the displacement of the end of the spring from its equilibrium position (in SI units: m); F is the restoring force exerted by the material (in SI units: N or kg·m/s^2); and k is

Re: What's with the spacing code?

2010-10-02 Thread Joe Neeman
On Sat, Oct 2, 2010 at 5:56 AM, David Kastrup d...@gnu.org wrote: David Kastrup d...@gnu.org writes: With the current code, a score that used to take 5 pages now takes 8, really really spaced out. I don't see that we can release a version of Lilypond that takes up horrifically more

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread markpolesky
On 2010/10/02 16:32:06, Carl wrote: When laying out a page, LilyPond makes a stack of the layout items (staves, lyrics lines, chordnames, etc.) on the page, with a variable spacing item between each pair of layout items. When calculating the desired location of each layout item, the code treats

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Carl . D . Sorensen
On 2010/10/03 02:49:30, Mark Polesky wrote: On 2010/10/02 16:32:06, Carl wrote: When laying out a page, LilyPond makes a stack of the layout items (staves, lyrics lines, chordnames, etc.) on the page, with a variable spacing item between each pair of layout items. When calculating the

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Joe Neeman
On Sat, Oct 2, 2010 at 8:08 PM, carl.d.soren...@gmail.com wrote: On 2010/10/03 02:49:30, Mark Polesky wrote: On 2010/10/02 16:32:06, Carl wrote: When laying out a page, LilyPond makes a stack of the layout items (staves, lyrics lines, chordnames, etc.) on the page, with a variable

Re: Optimizations for pure-height approximations. (issue1817045)

2010-10-02 Thread Joe Neeman
On Sat, Oct 2, 2010 at 9:01 AM, percival.music...@gmail.com wrote: Has this patch been pushed, or definitely rejected, or is it waiting for when Joe has some spare time (probably 2011 :) ? http://codereview.appspot.com/1817045/ I was just waiting to see if the memory problems are still