Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

On Sun, Oct 3, 2010 at 4:36 PM, wrote: > Latest patch set up. Okay to push? > > - Mark > > http://codereview.appspot.com/2316042/ > It's ok with me. ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-

Re: Regression test analysis - 2.13.35

On 4 October 2010 00:46, Carl Sorensen wrote: > I agree that it would be better to have warning messages show up in parsing > order, rather than translation order.  But if the error occurs in > translation, there's no way to make the warning messages show up in parsing > order, unless we force tr

Re: Regression test analysis - 2.13.35

On 10/3/10 5:39 PM, "Neil Puttock" wrote: > On 4 October 2010 00:19, Carl Sorensen wrote: > >> Is it a bug, or just different ordering of the output?  The warnings are >> proper, aren't they? >> >> Can't we just say the warnings have reversed order, so that the changes in >> the regtest out

Re: Regression test analysis - 2.13.35

On 4 October 2010 00:19, Carl Sorensen wrote: > Is it a bug, or just different ordering of the output?  The warnings are > proper, aren't they? > > Can't we just say the warnings have reversed order, so that the changes in > the regtest output can be ignored? I think users will expect warning me

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

Latest patch set up. Okay to push? - Mark http://codereview.appspot.com/2316042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Regression test analysis - 2.13.35

On 10/3/10 3:49 PM, "Neil Puttock" wrote: > On 30 September 2010 09:57, Phil Holmes wrote: > >> 1) In harp-pedals-sanity-checks.ly we get: >> >> +warning: Harp pedal diagram contains dividers at positions (4). Normally, >> there is only one divider after the third pedal. >> +warning: Harp p

Re: Passing the result of an ApplyOutputEvent to a music-function

On Sun, Oct 3, 2010 at 11:01 PM, Neil Puttock wrote: > ApplyOutput is useless for this since it's evaluated too late (though > in your code, it never gets the chance since it's not part of a > sequential block). That's what I feared. *sigh* > You could try basing it on the existing code for span

Re: Adds ly:define-event-class (issue1867050)

On 2010/10/02 16:02:37, Graham Percival wrote: As far as I can see, Mike has resolved all the known problems with this patch. Are there any other problems, or should we accept it? I'm working on it now. http://codereview.appspot.com/1867050/ ___ l

Re: Regression test analysis - 2.13.35

On 30 September 2010 09:57, Phil Holmes wrote: > 1) In harp-pedals-sanity-checks.ly we get: > > +warning: Harp pedal diagram contains dividers at positions (4). Normally, > there is only one divider after the third pedal. > +warning: Harp pedal diagram contains dividers at positions (1 3 5). > No

Re: Passing the result of an ApplyOutputEvent to a music-function

On 28 September 2010 20:07, Valentin Villenave wrote: > I've asked this question on -user but I suspect it got lost in the > flow. (Besides, it *might* belong on -devel since I'm actually trying > to implement a missing feature, see for instance > http://lists.gnu.org/archive/html/lilypond-user/2

[PATCH] Fix 888: Add ly:stencil-scale

HI everybody, This patch implements an exported function, ly:stencil-scale, which can be used to stretch/flip/mirror etc. stencils. Please review here: http://codereview.appspot.com/2275042/ Cheers, Neil <>___ lilypond-devel mailing list lilypond-deve

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

On Sun, Oct 3, 2010 at 10:59 AM, wrote: > I've uploaded a new patch set for review, but I still have > some questions. > > First, some questions for Joe Neeman: > > Joe, with commit 7d410b9 (from 2009-12-17), in NR 4.4.1 > "Vertical spacing inside a system - Spacing between staves", > you wrote:

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

New patch-set uploaded. I've added changes to dispatcher.cc as suggested by Patrick. scm_to_uint32 --> scm_to_int in guile-compatibility.hh and grob-array-scheme.cc, #else // comments changed as requested. Cheers, Ian http://codereview.appspot.com/2204044/diff/7001/flower/include/guile-compati

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

On Sun, Oct 3, 2010 at 11:26 AM, Carl Sorensen wrote: > On 10/2/10 10:50 PM, "Joe Neeman" wrote: > > > > On Sat, Oct 2, 2010 at 8:08 PM, wrote: > >> On 2010/10/03 02:49:30, Mark Polesky wrote: > >>> On 2010/10/02 16:32:06, Carl wrote: > >> > >> I don't think so. I think 'padding is added as a

Re: What am I doing wrong here?

Carl Sorensen writes: > On 10/3/10 10:29 AM, "Trevor Daniels" wrote: > >> David Kastrup wrote Sunday, October 03, 2010 3:22 PM >>> >>> push = -\tweak #'side-axis #X ^\markup { \musicglyph >>> #"accordion.push" } >>> pull = -\tweak #'side-axis #X ^\markup { \musicglyph >>> #"accordion.pull" } >>

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

On 10/2/10 10:50 PM, "Joe Neeman" wrote: > > On Sat, Oct 2, 2010 at 8:08 PM, wrote: >> On 2010/10/03 02:49:30, Mark Polesky wrote: >>> On 2010/10/02 16:32:06, Carl wrote: >> >> I don't think so.  I think 'padding is added as a rigid space interval, >> hence my saying that it is added to the la

Re: What am I doing wrong here?

On 10/3/10 10:29 AM, "Trevor Daniels" wrote: > > > David Kastrup wrote Sunday, October 03, 2010 3:22 PM >> >> push = -\tweak #'side-axis #X ^\markup { \musicglyph >> #"accordion.push" } >> pull = -\tweak #'side-axis #X ^\markup { \musicglyph >> #"accordion.pull" } >> \score { >> \repeat unf

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

I've uploaded a new patch set for review, but I still have some questions. First, some questions for Joe Neeman: Joe, with commit 7d410b9 (from 2009-12-17), in NR 4.4.1 "Vertical spacing inside a system - Spacing between staves", you wrote: If unset, stretchability defaults to space - minimu

Re: What am I doing wrong here?

David Kastrup wrote Sunday, October 03, 2010 3:22 PM push = -\tweak #'side-axis #X ^\markup { \musicglyph #"accordion.push" } pull = -\tweak #'side-axis #X ^\markup { \musicglyph #"accordion.pull" } \score { \repeat unfold 8 { c'-1\push c'-1\pull } } Why does this work nice with \push, and

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

LGTM, although I have no knowledge of the spacing code. http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely#newcode198 Documentation

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

On 2010/10/03 04:50:12, joeneeman wrote: On Sat, Oct 2, 2010 at 8:08 PM, wrote: > I think we should document what we have, and make enhancement requests > for what we would *like* to have. I don't think the exercise of "write > the documents for what we

What am I doing wrong here?

push = -\tweak #'side-axis #X ^\markup { \musicglyph #"accordion.push" } pull = -\tweak #'side-axis #X ^\markup { \musicglyph #"accordion.pull" } \score { \repeat unfold 8 { c'-1\push c'-1\pull } } Why does this work nice with \push, and not so nice with \pull? Is this supposed to work at all?