Re: Doc: NR 4: Minor edits. (issue3406041)

2010-12-02 Thread tdanielsmusic
LGTM; just a few nitpicks http://codereview.appspot.com/3406041/diff/6001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/3406041/diff/6001/Documentation/notation/spacing.itely#newcode1297 Documentation/notation/spacing.itely

ragged variables - paper{} or layout{}?

2010-12-02 Thread Phil Holmes
If you search in the NR for ragged, you'll find it is pretty much interchangeably used in the paper{} block and the layout{} block. Is one correct and the other deprecated? Are both correct, and if so why? -- Phil Holmes Bug Squad ___ lilypond-d

Re: ragged variables - paper{} or layout{}?

2010-12-02 Thread James
On 02/12/2010 09:42, Phil Holmes wrote: If you search in the NR for ragged, you'll find it is pretty much interchangeably used in the paper{} block and the layout{} block. Is one correct and the other deprecated? Are both correct, and if so why? Something for GLISS? James __

Another regtest question

2010-12-02 Thread Phil Holmes
Are the regtests that only produce midi output checked? How? -- Phil Holmes Bug Squad ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Position of cue clefs?

2010-12-02 Thread Reinhold Kainhofer
Am Mittwoch, 1. Dezember 2010, um 12:22:15 schrieben Sie: > On Mon, Nov 29, 2010 at 7:07 AM, Werner LEMBERG wrote: > > And it should be transposed to the instrument's transposition. I've > > seen untransposed cues too, especially in, say, Piano or Celesta parts > > with a mark `Klar. in A' , but

Re: Doc: NR 4: Minor edits. (issue3406041)

2010-12-02 Thread percival . music . ca
On 2010/12/02 08:34:52, Trevor Daniels wrote: LGTM; just a few nitpicks I agree with Trevor; I noticed (almost) everything he did, and didn't notice anything else. http://codereview.appspot.com/3406041/ ___ lilypond-devel mailing list lilypond-devel

Re: server down?

2010-12-02 Thread Francisco Vila
2010/12/2 Colin Campbell : > One wonders whether the -devel community has looked into gittorrent: > http://advogato.org/article/994.html > > Given the effect of putting all the eggs in one basket, distributed git > seems quite interesting. Git is already distributed and all the eggs are not in o

Re: Doc: NR 4: Minor edits. (issue3406041)

2010-12-02 Thread n . puttock
http://codereview.appspot.com/3406041/diff/6001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/3406041/diff/6001/Documentation/notation/spacing.itely#newcode1294 Documentation/notation/spacing.itely:1294: { c4 c c c2

Re: Another regtest question

2010-12-02 Thread Graham Percival
On Thu, Dec 02, 2010 at 04:04:50PM -, Phil Holmes wrote: > Are the regtests that only produce midi output checked? Not as far as I know. We do have any such regtests? (well, I guess the logfile would be generated) Cheers, - Graham ___ lilypond-de

Re: Doc: NR 4: Minor edits. (issue3406041)

2010-12-02 Thread Trevor Daniels
Neil http://codereview.appspot.com/3406041/diff/6001/Documentation/notation/spacing.itely#newcode1297 Documentation/notation/spacing.itely:1297: c4 c c~ | \break % this \break works On 2010/12/02 08:34:52, Trevor Daniels wrote: indent; needs another c adding another c will make the break

Fix 1252 by compressing page (issue3422041)

2010-12-02 Thread Carl . D . Sorensen
Reviewers: , Message: Here's a patch to fix issue 1252 (music overflows page) by compressing music together. It may cause collisions, but it should solve the critical overflow error. Description: Fix 1252 by compressing page Please review this at http://codereview.appspot.com/3422041/ Affect

Re: Fix 1252 by compressing page (issue3422041)

2010-12-02 Thread joeneeman
On 2010/12/02 20:52:00, Carl wrote: Here's a patch to fix issue 1252 (music overflows page) by compressing music together. It may cause collisions, but it should solve the critical overflow error. LGTM. It would still be nice to better estimate the heights (I actually have a little code fo

Re: Fix 1252 by compressing page (issue3422041)

2010-12-02 Thread n . puttock
http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc#newcode313 lily/page-layout-problem.cc:313: double overflow = spacer.configuration_length (spacer.force ())

Re: ragged variables - paper{} or layout{}?

2010-12-02 Thread Mark Polesky
James wrote: >> If you search in the NR for ragged, you'll find it is >> pretty much interchangeably used in the paper{} block >> and the layout{} block. Is one correct and the other >> deprecated? Are both correct, and if so why? > > Something for GLISS? I don't think anything needs to be chang

Polymetric spacing bug

2010-12-02 Thread Michael Käppler
Though polymetric notation is documented to work, it sometimes leads to unexpected page overflow. Then again, with other time signature combinations, it works very well. What is the reason for this variable behaviour? See the following example: \version "2.13.40" \include "deutsch.ly" stimmeI

Re: Polymetric spacing bug

2010-12-02 Thread Carl Sorensen
On 12/2/10 4:18 PM, "Michael Käppler" wrote: > Though polymetric notation is documented to work, it sometimes leads to > unexpected page overflow. > Then again, with other time signature combinations, it works very well. > What is the reason for this > variable behaviour? > I believe it's bec

Re: Fix 1252 by compressing page (issue3422041)

2010-12-02 Thread Carl . D . Sorensen
Thanks for the review, Neil. http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc#newcode313 lily/page-layout-problem.cc:313: double overflow = spacer.configura

Re: paper-defaults-init.ly questions

2010-12-02 Thread Patrick McCarty
On Wed, Dec 1, 2010 at 5:02 PM, Mark Polesky wrote: > I found these in paper-defaults-init.ly: > >  #(define make-header (...)) >  #(define make-footer (...)) >  #(define font-defaults '((...))) >  #(define text-font-defaults `((...))) > > 1) Do we need the quasiquote ` for text-font-defaults? >  

Re: Polymetric spacing bug

2010-12-02 Thread Michael Käppler
Hi Carl, I believe it's because the line can only break when both staves have a bar line at the end of the line. You can facilitate a break by adding \bar " " at the point where you'd like a break. thanks for this information. What I'd need is the possibility to allow line breaks at every point