Re: [Pseudo-patch] Add support for HairpinText indications. (issue3509041)

On 8 December 2010 08:09, wrote: > [I should probably subscribe the codereview mail address to Frogs- and > move the discussion there.] Sounds sensible to me. > Thanks Neil! I've now tried to make a proper Spanner, which raises more > questions of course (namely, how to properly start and finis

Don't make paper columns if skipTypesetting = ##t. (issue3598041)

LGTM. http://codereview.appspot.com/3598041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix bookpart identifier crash with page-marker. (issue3585042)

LGTM http://codereview.appspot.com/3585042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1336 (issue3594041)

On 2010/12/11 23:23:46, Neil Puttock wrote: I think it would be better to create the missing column rather than aborting. Like this: http://codereview.appspot.com/3598041 http://codereview.appspot.com/3594041/ ___ lilypond-devel mailing list lilypo

Fix bookpart identifier crash with page-marker. (issue3585042)

lgtm http://codereview.appspot.com/3585042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1336 (issue3594041)

On 11 December 2010 20:38, Graham Percival wrote: > What about: > \markup{foo} > > ?  how many paper columns does that create? None: toplevel markup doesn't create any grobs. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://

Re: `make doc' fails

On Sun, Dec 12, 2010 at 12:19 AM, Patrick McCarty wrote: > Okay, pushed. Thanks! That was embarrassing. Cheers, Valentin. ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1336 (issue3594041)

On 11 December 2010 17:40, wrote: > Here's a patch for issue 1336 that combine's Neil's idea of not creating > the paper columns with Graham's idea of erroring out when there are less > than 2 columns. I think it would be better to create the missing column rather than aborting. Though we can'

Re: `make doc' fails

On 2010-12-12, Valentin Villenave wrote: > On Sat, Dec 11, 2010 at 11:17 PM, Patrick McCarty wrote: > > The patch below seems to work.  Is this the correct fix? > > Of course! Please push asap. Okay, pushed. Thanks, Patrick ___ lilypond-devel mailing

Re: `make doc' fails

On Sat, Dec 11, 2010 at 11:17 PM, Patrick McCarty wrote: > The patch below seems to work.  Is this the correct fix? Of course! Please push asap. I ran make check but it didn't occur to me that the ukulele needed to be modified as well. Stupid me. Cheers, Valentin. __

Re: Doc: Various to LM and NR from user email threads (issue3581041)

http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely#newcode2115 Documentation/learning/fundamental.itely:2115: no note he

Re: `make doc' fails

On 2010-12-11, Patrick McCarty wrote: > > I can't run `make doc' due to a compile failure on git master (as of > commit 75cdeeefba1e4762a29b5f418b8d6294a0eba18e). > > Valentin, do you have a fix for this? The patch below seems to work. Is this the correct fix? diff --git a/ly/predefined-ukule

`make doc' fails

Hello, I can't run `make doc' due to a compile failure on git master (as of commit 75cdeeefba1e4762a29b5f418b8d6294a0eba18e). The relevant snippet that fails is in fretted-strings.itely: \version "2.13.42" \include "predefined-ukulele-fretboards.ly" myChords = \chordmode { a1 a:m a:aug }

Re: Add /chordGlissando to music functions (issue3530042)

On 2010/12/11 20:11:45, Carl wrote: On 2010/12/11 19:42:50, Graham Percival wrote: > Could it go in a separate optional-include > \include "guitar.ly" > file? I'd sign off with no qualms if it were optional. Absolutely, but it won't be guitar.ly, it'll be stringed-instruments.ly. I've tra

RE: LilyBuntu [don't read kainhofer.com!]

Hello, -Original Message- From: lilypond-devel-bounces+james.lowe=datacore@gnu.org on behalf of Carl Sorensen Sent: Sat 12/11/2010 0:23 To: Francisco Vila; Graham Percival Cc: lilypond-devel@gnu.org Subject: Re: LilyBuntu [don't read kainhofer.com!] ... Yes, but we contributors do

RE: VirtualBox/LilyBuntu and USB

Phil, -Original Message- From: lilypond-devel-bounces+james.lowe=datacore@gnu.org on behalf of Phil Holmes Sent: Sat 12/11/2010 15:13 To: lilypond-devel@gnu.org Subject: VirtualBox/LilyBuntu and USB I don't know if this is unique to me, but it's something that may be worth mentioni

Re: harmonics and slides (issue3590041)

On 12/11/10 1:35 PM, "Patrick Schmidt" wrote: > > > Am 11.12.2010 um 21:16 schrieb Carl Sorensen: > >> On 12/11/10 12:55 PM, "Carl Sorensen" wrote: >> >>> >>> >>> >>> On 12/11/10 12:44 PM, "Patrick Schmidt" wrote: >>> Am 11.12.2010 um 18:03 schrieb Carl Sorensen:

Re: Fix 1336 (issue3594041)

On Sat, Dec 11, 2010 at 08:33:52PM +, carl.d.soren...@gmail.com wrote: > >lily/simple-spacer.cc:397: error (_ ("no music remaining to > typeset")); > >"remaining" implies that something has been skipped. Are we sure that > this can > >only happen with skipTypesetting? > > If we run an empty sc

Re: harmonics and slides (issue3590041)

Am 11.12.2010 um 21:16 schrieb Carl Sorensen: On 12/11/10 12:55 PM, "Carl Sorensen" wrote: On 12/11/10 12:44 PM, "Patrick Schmidt" wrote: Am 11.12.2010 um 18:03 schrieb Carl Sorensen: On 12/11/10 9:54 AM, "Patrick Schmidt" wrote: IMHO I think we want to have \hideNotes apply to T

Re: Doc: Various to LM and NR from user email threads (issue3581041)

Sorry I didn't read Graham;s comment first time round. http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely#newcode2113 D

Re: Fix 1336 (issue3594041)

On 2010/12/11 20:28:18, Valentin Villenave wrote: I'm just not entirely sure about the error message: http://codereview.appspot.com/3594041/diff/1/lily/simple-spacer.cc File lily/simple-spacer.cc (right): http://codereview.appspot.com/3594041/diff/1/lily/simple-spacer.cc#newcode397 lily/si

Re: Fix 1336 (issue3594041)

Hi Carl, thanks for this patch! Hopefully we can close this skipTypesetting issue soon :-) I'm just not entirely sure about the error message: http://codereview.appspot.com/3594041/diff/1/lily/simple-spacer.cc File lily/simple-spacer.cc (right): http://codereview.appspot.com/3594041/diff/1/li

Re: harmonics and slides (issue3590041)

On 12/11/10 12:55 PM, "Carl Sorensen" wrote: > > > > On 12/11/10 12:44 PM, "Patrick Schmidt" wrote: > >> >> >> Am 11.12.2010 um 18:03 schrieb Carl Sorensen: >> >>> On 12/11/10 9:54 AM, "Patrick Schmidt" wrote: >>> IMHO I think we want to have \hideNotes apply to TabVoice. I tried t

Re: Add /chordGlissando to music functions (issue3530042)

On 2010/12/11 19:42:50, Graham Percival wrote: Could it go in a separate optional-include \include "guitar.ly" file? I'd sign off with no qualms if it were optional. Absolutely, but it won't be guitar.ly, it'll be stringed-instruments.ly. New patch coming soon. http://codereview.appspot.c

Re: Fix 1336 (issue3594041)

On 12/11/10 12:46 PM, "Graham Percival" wrote: > On Sat, Dec 11, 2010 at 05:40:20PM +, carl.d.soren...@gmail.com wrote: >> Message: >> Here's a patch for issue 1336 that combine's Neil's idea of not creating >> the paper columns with Graham's idea of erroring out when there are less >> tha

Re: Add /chordGlissando to music functions (issue3530042)

On 12/11/10 12:39 PM, "Graham Percival" wrote: > On Sat, Dec 11, 2010 at 07:04:20PM +, carl.d.soren...@gmail.com wrote: >> On 2010/12/11 18:52:28, Valentin Villenave wrote: >>> That being said, if we're to start accepting such tricks in the >> default >>> distribution, then I can think of

Re: harmonics and slides (issue3590041)

On 12/11/10 12:44 PM, "Patrick Schmidt" wrote: > > > Am 11.12.2010 um 18:03 schrieb Carl Sorensen: > >> On 12/11/10 9:54 AM, "Patrick Schmidt" wrote: >> >>> IMHO I think we want to have \hideNotes apply to TabVoice. I tried to >>> achieve glissandi with an indefinite beginning/ending (but

Re: Fix 1336 (issue3594041)

On Sat, Dec 11, 2010 at 05:40:20PM +, carl.d.soren...@gmail.com wrote: > Message: > Here's a patch for issue 1336 that combine's Neil's idea of not creating > the paper columns with Graham's idea of erroring out when there are less > than 2 columns. If nobody else wants to do a full regtest co

Re: harmonics and slides (issue3590041)

Am 11.12.2010 um 18:03 schrieb Carl Sorensen: On 12/11/10 9:54 AM, "Patrick Schmidt" wrote: IMHO I think we want to have \hideNotes apply to TabVoice. I tried to achieve glissandi with an indefinite beginning/ending (but in vain): You can test this really easily. Simply add \override Ta

Re: Add /chordGlissando to music functions (issue3530042)

Could it go in a separate optional-include \include "guitar.ly" file? I'd sign off with no qualms if it were optional. http://codereview.appspot.com/3530042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinf

Re: Add /chordGlissando to music functions (issue3530042)

On Sat, Dec 11, 2010 at 07:04:20PM +, carl.d.soren...@gmail.com wrote: > On 2010/12/11 18:52:28, Valentin Villenave wrote: > >That being said, if we're to start accepting such tricks in the > default > >distribution, then I can think of several great snippets that would > also make > >good cand

Re: Add /chordGlissando to music functions (issue3530042)

On 2010/12/11 19:16:13, Valentin Villenave wrote: On Sat, Dec 11, 2010 at 8:04 PM, wrote: > If we started doing this, though, how would we distinguish between hacks > that go only in the LSR and those that go in the hacks/ directory? I like this a lot!

Re: Add /chordGlissando to music functions (issue3530042)

On Sat, Dec 11, 2010 at 8:04 PM, wrote: > Maybe we could create a directory called hacks/, where items that we > don't really want in the main code base but are of use to users could be > stored.  We could then add snippets demonstrating those hacks to the > documentation, and they'd be accessed

Re: Doc: Various to LM and NR from user email threads (issue3581041)

http://codereview.appspot.com/3581041/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (right): http://codereview.appspot.com/3581041/diff/1/Documentation/notation/repeats.itely#newcode151 Documentation/notation/repeats.itely:151: of and in between the braces

Re: Add /chordGlissando to music functions (issue3530042)

I really like it. It is hackish indeed, and I can understand your concern. It certainly would make a great snippet, but I don't feel strongly against adding it to the default distribution. It probably depends whether this feature is used a lot or not (and I'm too unfamiliar with guitar music to be

Re: Add /chordGlissando to music functions (issue3530042)

On 2010/12/11 18:52:28, Valentin Villenave wrote: As it is, I can't see anything missing or any room for improvements. The only other option I can imagine would be to heavily modify the glissando engraver, but I suspect it would be overkill. Oh, I've just seen that Patrick S. suggested to p

Re: Add /chordGlissando to music functions (issue3530042)

On 2010/12/11 18:52:28, Valentin Villenave wrote: I really like it. [snip ..] That being said, if we're to start accepting such tricks in the default distribution, then I can think of several great snippets that would also make good candidates for inclusion :-) Maybe we could create a

Fix 1336 (issue3594041)

Reviewers: , Message: Here's a patch for issue 1336 that combine's Neil's idea of not creating the paper columns with Graham's idea of erroring out when there are less than 2 columns. Thanks, Carl Description: Fix 1336 Please review this at http://codereview.appspot.com/3594041/ Affected fi

New French PO file for 'lilypond' (version 2.13.42)

Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the French team of translators. The file is available at: http://translationproject.org/latest/lilypond/fr.po (We can arrange things so that

Re: harmonics and slides (issue3590041)

On 12/11/10 9:54 AM, "Patrick Schmidt" wrote: > > > Am 11.12.2010 um 17:34 schrieb carl.d.soren...@gmail.com: > >> Do we want to have\hideNotes apply to TabVoice? If so, we could >> change >> the definition of \hideNotes. That would probably be better than a >> known issue. > IMHO I think w

Re: Doc: Various to LM and NR from user email threads (issue3581041)

On 2010/12/11 16:33:48, pkx166h wrote: I hope this is the right method to have a discussion on Rietveld, I have added my own comments/responses to yours inline. Yes, this is a very good way to do it. You can also just add a comment in the patchset. http://codereview.appspot.com/3581041/diff

Re: harmonics and slides (issue3590041)

Am 11.12.2010 um 17:34 schrieb carl.d.soren...@gmail.com: Looks pretty good to me. Looks *excellent* for a first patch. Thanks, Carl http://codereview.appspot.com/3590041/diff/1/Documentation/notation/ fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): htt

Re: harmonics and slides (issue3590041)

Looks pretty good to me. Looks *excellent* for a first patch. Thanks, Carl http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/3590041/diff/1/Documentation/notation

Re: Doc: Various to LM and NR from user email threads (issue3581041)

Reviewers: Trevor Daniels, Valentin Villenave, carl.d.sorensen_gmail.com, Graham Percival, Message: I hope this is the right method to have a discussion on Rietveld, I have added my own comments/responses to yours inline. James http://codereview.appspot.com/3581041/diff/1/Documentation/notat

harmonics and slides (issue3590041)

Looks basically good. http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely#newcode383 Documentation/notation/

[Patch] NR: Documentation of harmonics and slides

Hi all, I uploaded a small patch to http://codereview.appspot.com/3590041. Thanks for reviewing it. patrick ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

VirtualBox/LilyBuntu and USB

I don't know if this is unique to me, but it's something that may be worth mentioning in the CG in relation to running LB in a VM on Windows (64 bit Vista, in my case). When LB is running in its VM, my USB-based scanner won't work, so the combination is obviously messing up the USB system some

Add /chordGlissando to music functions (issue3530042)

Reviewers: , Message: In response to requests from the tablatures list, I've added this function to ly/music-functions-init.ly. I'm not totally sure that this should be part of the default lilypond installation. It seems a bit hacky to me. Please review. Thanks, Carl Description: Add /chor

Re: Doc: Various to LM and NR from user email threads (issue3581041)

Thanks for this! I've slightly modified the git-cl instructions, to include "make the CC list lilypond-devel". That's part of the git-cl config stage, so you don't need to remember it for every individual patch you upload. http://codereview.appspot.com/3581041/diff/1/Documentation/learning/f

Re: LilyBuntu [don't read kainhofer.com!]

Il giorno sab, 11/12/2010 alle 12.02 +, Graham Percival ha scritto: > Then you need to run > ./autogen.sh > in the *source* tree, followed by > make distclean > in the *source* tree. FWIW, it's simpler and much faster to do two last steps with ./autogen.sh --noconfigure in the *source* t

Re: LilyBuntu [don't read kainhofer.com!]

On Sat, Dec 11, 2010 at 03:43:06AM +0100, Reinhold Kainhofer wrote: > Am Samstag, 11. Dezember 2010, um 00:38:54 schrieb Graham Percival: > > If you want to force a complete compile, then I recommend removing > > the build directory entirely and starting from scratch. This is > > very easy with an

Re: Contacting Translation Meister

On Sat, Dec 11, 2010 at 9:25 AM, Markus wrote: > I want to help to translate the notation reference to german. You recommend to > first contact Francisco before starting any work. CC-ing Francisco and Till (our only German translator so far)... You might also want to subscribe to our translators

Re: musescore

Il giorno ven, 10/12/2010 alle 09.21 +0100, Jan Nieuwenhuizen ha scritto: > Great stuff also being done by > http://scorio.org (and even http://etudeapp.com ). Scorio seems great. Even though LilyPond is not properly credited, IMO. I had to use the search bar to find it: http://www.scorio.com/w

Contacting Translation Meister

Hi, I want to help to translate the notation reference to german. You recommend to first contact Francisco before starting any work. So I am trying this with this mail. Thanks, Markus ___ lilypond-devel mailing list lilypond-devel@gnu.org http://list