Multimeasure rest print function

2011-01-27 Thread Mike Solomon
Hey all, I noticed the following lines of code in Multi_measure_rest::print (SCM smob): int measures = 0; SCM m (me->get_property ("measure-count")); if (scm_is_number (m)) measures = scm_to_int (m); It seems that the variable `measures' is unused in this function - can this be de

Re: Remove explicit origin setting from simple make-music calls (issue3847041)

2011-01-27 Thread n . puttock
LGTM. http://codereview.appspot.com/3847041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add the Instrument_name_engraver also to all group contexts (issue4031043)

2011-01-27 Thread n . puttock
http://codereview.appspot.com/4031043/diff/7001/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4031043/diff/7001/Documentation/notation/staff.itely#newcode939 Documentation/notation/staff.itely:939: @code{ChordNames}, @code{Fretb

Re: PATCHES: 48-hour notice for mensural and bar-extent

2011-01-27 Thread David Kastrup
Ian Hulin writes: > Hi Graham, > I'm replying off-list and slightly off-topic. Less off-list than off-topic, I'm afraid. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCHES: 48-hour notice for mensural and bar-extent

2011-01-27 Thread Graham Percival
On Wed, Jan 26, 2011 at 09:03:50PM +, Ian Hulin wrote: > I'm replying off-list and slightly off-topic. I think Benkö Pál's given > name is actually Pál (pron. almost exactly like English Paul). > > I think he's doing the Hungarian thing of signing his name with the > surname first like Bartók

Re: Remove explicit origin setting from simple make-music calls (issue3847041)

2011-01-27 Thread percival . music . ca
On 2011/01/27 13:30:32, reinhold_kainhofer.com wrote: Rebased to current master and re-uploaded the patch (the cueDuringWithClef patch messed things up a little bit, but really straightforward). Thanks. It looks ok, it compiles everything fine, and it's pretty simple. Please push. Cheers,

Re: [PATCH] Free type should be FreeType

2011-01-27 Thread Graham Percival
On Thu, Jan 27, 2011 at 05:10:16PM +0100, Francisco Vila wrote: > 2011/1/26 John Mandereau : > >> > "Free type error: %s" > >> > (why free? it's FreeType maybe?) > >> > >> I think yes, it's for an error in FreeType. > > > > If so, the message in English should be fixed, shouldn't it? > > The attac

Re: [Patch:] Alternative Jazz font for chords in lilypond

2011-01-27 Thread Graham Percival
On 1/25/11, Marc Hohl wrote: > this patch covers the inclusion of the jazz font mentioned in Thanks, added to the tracker as: http://code.google.com/p/lilypond/issues/detail?id=1494 > I assume that it is too late to get this stuff into 2.14, but nevertheless - > is this the right way to go? Is t

Re: NR 2.1.2 Lyrics and repeats, improvement proposals

2011-01-27 Thread Xavier Scheuer
On 27 January 2011 15:33, Carl Sorensen wrote: > > Xavier, > > Once an issue has been opened, you can certainly add comments yourself to > update it. Carl, I know and I certainly do not refrain from commenting usually. But I was thinking "update" in the sense of changing the status or adding a l

New Spanish PO file for 'lilypond' (version 2.13.42)

2011-01-27 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/lilypond/es.po (We can arrange things so tha

New Spanish PO file for 'lilypond' (version 2.13.42)

2011-01-27 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/lilypond/es.po (We can arrange things so tha

Re: NR 2.1.2 Lyrics and repeats, improvement proposals

2011-01-27 Thread Trevor Daniels
Xavier Scheuer wrote Thursday, January 27, 2011 1:06 PM Issue #1401: Doc: NR 2.1.2 Lyrics and repeats, improvement proposals http://code.google.com/p/lilypond/issues/detail?id=1401 has been opened further to my message. Could you update it accordingly? OK, I'll have a look. Also Mats poi

[PATCH] Free type should be FreeType

2011-01-27 Thread Francisco Vila
2011/1/26 John Mandereau : >> > "Free type error: %s" >> > (why free? it's FreeType maybe?) >> >> I think yes, it's for an error in FreeType. > > If so, the message in English should be fixed, shouldn't it? The attached patch would correct this. -- Francisco Vila. Badajoz (Spain) www.paconet.org

Re: NR 2.1.2 Lyrics and repeats, improvement proposals

2011-01-27 Thread Carl Sorensen
On 1/27/11 6:06 AM, "Xavier Scheuer" wrote: > On 27 January 2011 10:02, Trevor Daniels wrote: >> >> Thanks Xavier! I've now incorporated your suggestions in the docs. > > Thanks Trevor! > > Issue #1401: Doc: NR 2.1.2 Lyrics and repeats, improvement proposals > http://code.google.com/p/lil

Re: markup to string function?

2011-01-27 Thread Jan-Peter Voigt
Hello Reinhold, I'm a bit in a hurry, so this is not finished but an idea: I thought of my fine conversation about extracting lyrics with Jakob Lund a few days ago. I understand that markups are also lists and the strings are somewhere in this tree-list-structure. This doesn't get you the de

New patch set w/ expanded regtest

2011-01-27 Thread Mike Solomon
Hey all, 0003-Tweaks-regtest-and-adds-avoid-collisions-property.patch Description: Binary data 0002-Triggers-second-quant-pass-for-collisions.patch Description: Binary data 0001-Implements-a-more-robust-solution-to-issue-37.patch Description: Binary data I still can't post properly to Riet

Re: Remove explicit origin setting from simple make-music calls (issue3847041)

2011-01-27 Thread Reinhold Kainhofer
Am Donnerstag, 27. Januar 2011, um 14:17:19 schrieb percival.music...@gmail.com: > Sorry, does not apply cleanly to current git. Could you revise it? It > might be as simple as removing one part of the diff, but since I'm not > totally certain what you're trying to do here, I thought I should le

Re: [PATCH] removed unused macro "classname" , unused funcion "demangle_classname", unneccessary file "flower/rtti.cc"

2011-01-27 Thread Graham Percival
On 1/26/11, Bernard Hurley wrote: > The definition of the function "demangle_classname" is the only content > of flower/rtti.cc. This is only referenced in > flower/include/virtual-methods.hh, where it is used in the definition of > the macro "classname". > > Hence the references to "demangle_clas

Remove explicit origin setting from simple make-music calls (issue3847041)

2011-01-27 Thread percival . music . ca
Sorry, does not apply cleanly to current git. Could you revise it? It might be as simple as removing one part of the diff, but since I'm not totally certain what you're trying to do here, I thought I should leave it up to you. http://codereview.appspot.com/3847041/diff/1/ly/music-functions-ini

Re: NR 2.1.2 Lyrics and repeats, improvement proposals

2011-01-27 Thread Xavier Scheuer
On 27 January 2011 10:02, Trevor Daniels wrote: > > Thanks Xavier! I've now incorporated your suggestions in the docs. Thanks Trevor! Issue #1401: Doc: NR 2.1.2 Lyrics and repeats, improvement proposals http://code.google.com/p/lilypond/issues/detail?id=1401 has been opened further to my messag

Re: markup to string function?

2011-01-27 Thread Boris Shingarov
On 11-01-26 10:32 AM, Reinhold Kainhofer wrote: I need a function that extracts only the text (in this case "Title of the piece"). Many times, I also find myself in need of such function -- it would be absolutely awesome to have one. I have never gotten around to actually implementing one; but