Reviewers: ,
Message:
Regtest comes out clean.
Description:
Use queue for prioritizing slur scores.
This drops the number of scoring passes for
input/regression/slur-scoring.ly from 11.7k to 3.0k
Please review this at http://codereview.appspot.com/4073048/
Affected files:
M lily/include/sl
The reasonable score is to go in a subsequent patch. Stay tuned.
On Mon, Jan 31, 2011 at 11:44 PM, wrote:
> LGTM. Reads a lot cleaner and is much more extensible.
>
> This may be for another patch, but I think one problem that remains with
> the algorithm is that the "reasonable_score" paramete
LGTM. Reads a lot cleaner and is much more extensible.
This may be for another patch, but I think one problem that remains with
the algorithm is that the "reasonable_score" parameter may inadvertently
exclude certain quants from receiving a demerit they deserve because
they are not part of a for
On 2011/01/31 15:44:01, hanwenn wrote:
Note - there are some beam related regressions. I'll fix those
tonight.
cheers.
Fixed.
Please take another look.
http://codereview.appspot.com/4001046/
___
lilypond-devel mailing list
lilypond-devel@gnu.o
On Mon, Jan 31, 2011 at 11:57 AM, Reinhold Kainhofer wrote:
> Am Montag, 31. Januar 2011, um 20:09:01 schrieb Joe Neeman:
> > Guile's garbage collection generates many valgrind warnings (although a
> > quick google suggests that they've been improving the situation). I've
> > attached a suppressi
On Mon, Jan 31, 2011 at 11:52 AM, Reinhold Kainhofer
wrote:
> Due to the crash with the part-combiner (which I cannot reproduce,
> unfortunately), I'm currently taking a closer look at lilypond with valgrind.
>
> 1) Somehow the Rhythmic_head interface generates a "Conditional jump or move
> depend
On 31 January 2011 20:20, wrote:
> I had discounted the new property idea because of all the extra property
> lookups, but it seems your idea costs only one lookup per Column.
> For a name, default-clearance might better indicate that this is a
> vertical clearance maintained while choosing hori
On 2011-01-31 21:06, James Lowe wrote:
> -Original Message-
> From: Alexander Kobel
>> By the way: if you have { r2.. cis8( | c2!) r2 } all over the place,
>> and then there suddenly comes a { r2 cis2~ | cis2 r2 }, you'd expect an
>> additional sharp there too, don't you?
>
> Hmm...why
On 1/31/11 1:27 PM, "Reinhold Kainhofer" wrote:
> Am Mittwoch, 26. Januar 2011, um 20:00:31 schrieb David Kastrup:
>> Reinhold Kainhofer writes:
>>> I'm defining my own predicate symbol-or-markup? for the argument of a
>>> markup function.
> [...]
>>> but, as soon as I try to pass a markup, the
Am Donnerstag, 27. Januar 2011, um 14:58:18 schrieb Jan-Peter Voigt:
> I'm a bit in a hurry, so this is not finished but an idea:
>
> I thought of my fine conversation about extracting lyrics with Jakob
> Lund a few days ago. I understand that markups are also lists and the
> strings are somewhe
Am Donnerstag, 27. Januar 2011, um 12:09:09 schrieb Boris Shingarov:
> On 11-01-26 10:32 AM, Reinhold Kainhofer wrote:
> > I need a function that extracts only the text (in this
> > case "Title of the piece").
>
> Many times, I also find myself in need of such function -- it would be
> absolutely
Am Mittwoch, 26. Januar 2011, um 20:00:31 schrieb David Kastrup:
> Reinhold Kainhofer writes:
> > I'm defining my own predicate symbol-or-markup? for the argument of a
> > markup function.
[...]
> > but, as soon as I try to pass a markup, the parser complains that it
> > expects an SCM_IDENTIFIER
On 2011/01/31 19:50:38, Carl wrote:
We could then get the value of default-separation from the paper
column, and use
that value throughout separation-item.cc
I had discounted the new property idea because of all the extra property
lookups, but it seems your idea costs only one lookup per Col
hello
-Original Message-
From: Alexander Kobel
Date: Mon, 31 Jan 2011 19:14:23 +0100
To: Jan Warchoł
Cc: lilypond-user , bug-lilypond
, lilypond-devel
Subject: Re: Bug in ties over barlines
>By the way: if you have { r2.. cis8( | c2!) r2 } all over the place,
>and then there suddenly
On 2011/01/31 19:36:16, Keith wrote:
On 2011/01/31 11:20:39, hanwenn wrote:
> * this hardcodes 0.1 in several places. Make a property,
> so we can override this
Agreed in principle; the relevant property extra-spacing-height should
absorb
these magic numbers, but I am not willing to do so in
Am Montag, 31. Januar 2011, um 20:09:01 schrieb Joe Neeman:
> Guile's garbage collection generates many valgrind warnings (although a
> quick google suggests that they've been improving the situation). I've
> attached a suppression file that eliminates many of the bogus warnings.
Yes, I know about
On 2011/01/31 11:20:39, hanwenn wrote:
* this hardcodes 0.1 in several places. Make a property,
so we can override this
Agreed in principle; the relevant property extra-spacing-height should
absorb these magic numbers, but I am not willing to do so in this patch.
The 0.1s were in the previous
Guile's garbage collection generates many valgrind warnings (although a
quick google suggests that they've been improving the situation). I've
attached a suppression file that eliminates many of the bogus warnings.
Cheers,
Joe
On Mon, Jan 31, 2011 at 5:52 AM, Reinhold Kainhofer
wrote:
> Due to t
On 2011-01-31 11:04, Jan Warchoł wrote:
> [...] If the last note in the
> following example doesn't get a natural, it's *impossible* to tell
> that it's not another ces:
>
> ces'1~ | ces'
> ces'1( | c')
>
> It may be argued that the slur looks different than the tie, but it's
> not enough.
> I'm
On 1/31/11 3:04 AM, "Jan Warchoł" wrote:
> 2011/1/24 Phil Holmes
>>
>> If you use
>>
>> #(set-accidental-style 'modern-cautionary)
>> then you get the parenthesised accidental automatically, as requested.
>
> Indeed, thanks for the remainder.
> However, in my opinion it is necessary to *change
Reviewers: wl_gnu.org, reinhold_kainhofer.com, mike_apollinemike.com,
Message:
Hi,
this is a first step in making the beam scoring a bit saner and more
efficient.
Please review; i've been brainwashed by google's coding standards so
there are likely some style issues.
Description:
Cleanup bea
Note - there are some beam related regressions. I'll fix those tonight.
cheers.
http://codereview.appspot.com/4001046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Due to the crash with the part-combiner (which I cannot reproduce,
unfortunately), I'm currently taking a closer look at lilypond with valgrind.
1) Somehow the Rhythmic_head interface generates a "Conditional jump or move
depends on uninitialised value(s)" warning (none of the other ADD_INTERFA
LGTM
please make description more explicit. How about
"Add key-signature-interface::print to pure-print-callbacks"
http://codereview.appspot.com/3994045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/l
2 issues:
* this hardcodes 0.1 in several places. Make a property, so we can
override this
* rewrite the commit description so it explains what you are doing (ie.
what issues 1120, 1472, 1474 are). The desc. should be understandable
without access to the bug database.
http://codereview.appspot
Just some minor syntax changes to make it read better. I hope no one is
offended.
http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (left):
http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient
LGTM
http://codereview.appspot.com/4025044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
The set of modal transforms provided by Mike Ellis are now ready for
review. As the changes are all in Scheme code they are easy to test.
Patch set 1 are as originally provided by Mike; patch set 2 are after
some tidying up by me.
As yet there is no documentation. I'll b
Hi,
sorry for the delay - i was busy making new flags for Lily.
2011/1/24 Phil Holmes
>
> - Original Message - From: "Jan Warchoł"
>
>
>> I don't agree. *Theoretically* accidental is not needed, but if it
>> would be omitted, how can you tell the difference between aes~ | aes
>> and ae
29 matches
Mail list logo
