Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)

2011-02-01 Thread k-ohara5a5a
On 2011/01/31 19:50:38, Carl wrote: Since the 0.1s are all part of a Separation_item, what if we defined a new grob-property default-separation, and set the value to 0.1 for NonMusicalPaperColumn, NoteColumn, and PaperColumn, since these are the grobs having separation_item_interface? Done; and

Re: Bug in ties over barlines

2011-02-01 Thread Jan Warchoł
W dniu 31 stycznia 2011 17:06 użytkownik Carl Sorensen napisał: > On 1/31/11 3:04 AM, "Jan Warchoł" wrote: >> 2011/1/24 Phil Holmes >>> >>> If you use >>> >>> #(set-accidental-style 'modern-cautionary) >>> then you get the parenthesised accidental automatically, as requested. >> >> Indeed, thank

[PATCH] Avoid most double slashes

2011-02-01 Thread Francisco Vila
Hello. I've been very busy parsing doc logs and there is something thatkind of annoys me: double slashes everywhere. IMHO directories in build scripts should end in their bare names if they are going to be joined with a filename by means of a slash anyway, NOT end in slash 'just in case'. I know

Re: [PATCH] Avoid most double slashes

2011-02-01 Thread Francisco Vila
2011/2/1 Francisco Vila : > Hello.  I've been very busy parsing doc logs and there is something > thatkind of annoys me: double slashes everywhere.  IMHO directories in > build scripts should end in their bare names if they are going to be > joined with a filename by means of a slash anyway, NOT en

Messed up adding issue 1499

2011-02-01 Thread Trevor Daniels
While adding issue 1499 I inadvertently made John Mandereau the owner. Sorry John! Phil, could you please fix this up for me? Although I am listed as a contributor the entry for me that appears in the pull-down list for owner is not acceptable for some reason. Trevor

Re: Add Modal transformations (issue4126042)

2011-02-01 Thread tdanielsmusic
First stab at documentation now added. Comments from anyone familiar with these operations welcome. Trevor http://codereview.appspot.com/4126042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-de

Re: [PATCH] Avoid most double slashes

2011-02-01 Thread Werner LEMBERG
>> I know that you shouldn't fix what doesn't need fixing; at least >> this does not break anything, this is the test I've made with the >> patch applied: [...] IMHO, this is exactly the kind of a patch which you should directly apply without asking for approval... Werner _

Re: [PATCH] Avoid most double slashes

2011-02-01 Thread Francisco Vila
2011/2/1 Werner LEMBERG : > >>> I know that you shouldn't fix what doesn't need fixing; at least >>> this does not break anything, this is the test I've made with the >>> patch applied: [...] > > IMHO, this is exactly the kind of a patch which you should directly > apply without asking for approval

Re: Messed up adding issue 1499

2011-02-01 Thread Graham Percival
On Tue, Feb 01, 2011 at 04:18:38PM -, Trevor Daniels wrote: > Phil, could you please fix this up for me? Although I am listed as > a contributor the entry for me that appears in the pull-down list > for owner is not acceptable for some reason. He's on holiday, so I did it. Cheers, - Graham

Re: [PATCH] Avoid most double slashes

2011-02-01 Thread Graham Percival
On Tue, Feb 01, 2011 at 03:36:21PM +0100, Francisco Vila wrote: > 2011/2/1 Francisco Vila : > > Hello.  I've been very busy parsing doc logs and there is something > > thatkind of annoys me: double slashes everywhere.  IMHO directories in > > build scripts should end in their bare names if they are

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread Graham Percival
On Mon, Jan 31, 2011 at 11:17:46AM +, pkx1...@gmail.com wrote: > Just some minor syntax changes to make it read better. I hope no one is > offended. Not offended, but unfortunately I already pushed it. Could you make these changes to git? I don't want to slow down code development by asking

Re: [PATCH] Avoid most double slashes

2011-02-01 Thread Francisco Vila
2011/2/1 Graham Percival : > On Tue, Feb 01, 2011 at 03:36:21PM +0100, Francisco Vila wrote: >> 2011/2/1 Francisco Vila : >> > Hello.  I've been very busy parsing doc logs and there is something >> > thatkind of annoys me: double slashes everywhere.  IMHO directories in >> > build scripts should en

Re: [PATCH] Avoid most double slashes

2011-02-01 Thread Graham Percival
On Tue, Feb 01, 2011 at 09:13:59PM +0100, Francisco Vila wrote: > 2011/2/1 Graham Percival : > >> -     $(buildscript-dir)/output-distance --create-images --output-dir > >> $(RESULT_DIR) input/regression/out-test-baseline input/regression/out-test/ > >> +     $(buildscript-dir)/output-distance --c

Re: Messed up adding issue 1499

2011-02-01 Thread Trevor Daniels
Graham Percival wrote Tuesday, February 01, 2011 7:16 PM On Tue, Feb 01, 2011 at 04:18:38PM -, Trevor Daniels wrote: Phil, could you please fix this up for me? Although I am listed as a contributor the entry for me that appears in the pull-down list for owner is not acceptable for some

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread benko . pal
sorry Graham; next time I'll try to remember to open a new issue after pushing. p http://codereview.appspot.com/3989049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread Benkő Pál
(I don't know what happened to my reply, trying again.) 2011/1/31 : > Just some minor syntax changes to make it read better. I hope no one is > offended. on the contrary! > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely > File Documentation/notation/ancient

Re: Messed up adding issue 1499

2011-02-01 Thread Graham Percival
On Tue, Feb 01, 2011 at 09:09:50PM -, Trevor Daniels wrote: > > Graham Percival wrote Tuesday, February 01, 2011 7:16 PM > >He's on holiday, so I did it. > > Any idea why my entry as contributor fails? It looks right. If you mean "why couldn't I edit that field", then I'd double-check that

Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)

2011-02-01 Thread percival . music . ca
LGTM http://codereview.appspot.com/4095041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleanup beam scoring code. (issue4001046)

2011-02-01 Thread percival . music . ca
I see some fairly crazy beams in input/regression/spacing-to-grace.ly input/regression/accidental-contemporary.ly ... etc... there's some really steep slopes. I know you said there was another patch coming, so all well and good. http://codereview.appspot.com/4001046/ ___

Re: Use queue for prioritizing slur scores. (issue4073048)

2011-02-01 Thread percival . music . ca
LGTM, and I can confirm clean regtest comparison. http://codereview.appspot.com/4073048/diff/1/lily/include/slur-configuration.hh File lily/include/slur-configuration.hh (right): http://codereview.appspot.com/4073048/diff/1/lily/include/slur-configuration.hh#newcode68 lily/include/slur-configur

Re: scheme extension for playback experiments

2011-02-01 Thread peter
> "Bernard" == Bernard Hurley writes: Bernard> Hi On Fri, Jan 28, 2011 at 11:14:56PM -0800, Dennis Raddle Bernard> wrote: >> I am completely new to LilyPond, but it seems like a good way to >> get beautiful notation, and, I hope, experiment with playback >> algorithms that add human touch. Wh

Re: Fix Issue 1035 -- Add context property for negative frets (issue4056041)

2011-02-01 Thread percival . music . ca
LGTM, and passes regtests. http://codereview.appspot.com/4056041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add Modal transformations (issue4126042)

2011-02-01 Thread percival . music . ca
Might it be worth having some predefined scales, i.e. \diatonicScale and \pentatonicScale and the like? http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4126042/diff/4002/Documen

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread Graham Percival
On Tue, Feb 01, 2011 at 10:33:17PM +0100, Benkő Pál wrote: > 2011/1/31 : > > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode966 > > Documentation/notation/ancient.itely:966: \[ d\longa > > Can we put note durations for the first note of every new line (

Re: Use queue for prioritizing slur scores. (issue4073048)

2011-02-01 Thread Han-Wen Nienhuys
Thanks. Pushed. On Tue, Feb 1, 2011 at 8:55 PM, wrote: > LGTM, and I can confirm clean regtest comparison. > > > http://codereview.appspot.com/4073048/diff/1/lily/include/slur-configuration.hh > File lily/include/slur-configuration.hh (right): > > http://codereview.appspot.com/4073048/diff/1/lil

Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)

2011-02-01 Thread Han-Wen Nienhuys
LGTM On Tue, Feb 1, 2011 at 7:49 PM, wrote: > LGTM > > http://codereview.appspot.com/4095041/ > -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailm

Re: Cleanup beam scoring code. (issue4001046)

2011-02-01 Thread hanwenn
On 2011/02/01 22:12:13, Graham Percival wrote: I see some fairly crazy beams in input/regression/spacing-to-grace.ly input/regression/accidental-contemporary.ly ... etc... there's some really steep slopes. 0 Fixed for real now. http://codereview.appspot.com/4001046/ ___

Re: Cleanup beam scoring code. (issue4001046)

2011-02-01 Thread Han-Wen Nienhuys
There is one diff remaining: see the attached file. I introduced some streamlining of an inner loop, which affects the way we handle beams that start/end with invisible stems. The compare image is the new one. I have no examples of tremolo beams handy, but the new layout actually looks better t

Re: Cleanup beam scoring code. (issue4001046)

2011-02-01 Thread Carl Sorensen
On 2/1/11 8:34 PM, "Han-Wen Nienhuys" wrote: > There is one diff remaining: see the attached file. I introduced > some streamlining of an inner loop, which affects the way we handle > beams that start/end with invisible stems. > > The compare image is the new one. I have no examples of tremol

Re: Cleanup beam scoring code. (issue4001046)

2011-02-01 Thread Werner LEMBERG
> There is one diff remaining: see the attached file. I introduced > some streamlining of an inner loop, which affects the way we handle > beams that start/end with invisible stems. > > The compare image is the new one. I have no examples of tremolo beams > handy, but the new layout actually loo