Re: exact inversion (issue4173065)

2011-02-20 Thread benko . pal
Just minor stuff for the NR. all implemented. http://codereview.appspot.com/4173065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: transition between full-length and shortened stems - please discuss

2011-02-20 Thread Graham Percival
On 2/13/11, Janek Warchoł lemniskata.bernoull...@gmail.com wrote: This is the first part of a series of changes to the stems and flags. The suggested change is small, but in my opinion important. Thanks you for creating such an excellent report on the matter. You took the time to create two

Re: a present for Graham

2011-02-20 Thread Phil Holmes
- Original Message - From: Janek Warchoł lemniskata.bernoull...@gmail.com To: Graham Percival gra...@percival-music.ca Cc: lilypond-devel@gnu.org; Han-Wen Nienhuys hanw...@gmail.com Sent: Saturday, February 19, 2011 9:58 PM Subject: Re: a present for Graham 2011/2/19 Graham Percival

[PATCH] Setting minimum-length on DynamicTextSpanner did not have any effect

2011-02-20 Thread Reinhold Kainhofer
The DynamicTextSpanner grob was missing the springs-and-rods callback, so setting minimum-length didn't have any effect so far. Here's the fix: http://codereview.appspot.com/4187054 Okay to push? Cheers, Reinhold -- -- Reinhold

Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

2011-02-20 Thread Ian Hulin
Hi Patrick, On 18/02/11 02:13, pnor...@gmail.com wrote: LGTM. Can you email me your patch so I can apply it? Thanks, Patrick http://codereview.appspot.com/2219044/ Here's the patch. Cheers, Ian From d5854eabd3618476bc0cd06eb09effba68806acd Mon Sep 17 00:00:00 2001 From: Ian Hulin

New Italian PO file for 'lilypond' (version 2.13.48)

2011-02-20 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Italian team of translators. The file is available at: http://translationproject.org/latest/lilypond/it.po (We can arrange things so

Re: HACK DO NOT PUSH markuplines fix (Neil) (issue4160059)

2011-02-20 Thread k-ohara5a5a
On 2011/02/17 22:49:07, Graham Percival wrote: Neil's fix for a critical crash with markuplines. What's not to love? It is recognizable even to a non-lexer like me as an illegal-value trap, and it uses the same scm_is_pair idiom as similar tests in this file.

Re: pdfTex failure

2011-02-20 Thread Graham Percival
On Thu, Feb 17, 2011 at 11:47:17PM -, Trevor Daniels wrote: Graham (or any TeX wizard) ~ That's not me, then! make doc was failing for me with TeX capacity exceeded, sorry [save size=5000]. I hacked etc/texmf/texmf.cnf to increase save size, which allowed

Re: Add springs-and-rods callback to DynamicTextSpanner, so minimum-length has an effect (issue4187054)

2011-02-20 Thread percival . music . ca
lgtm, passes regtests, please push. http://codereview.appspot.com/4187054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Footnotes in lilypond patch

2011-02-20 Thread Mike Solomon
Hey all, I've sketched out the following code for footnotes in Lilypond (thank you very much Joe for your suggestions!). If people could please apply the attached patch, run the attached ly file just to make sure it works, and then play around with it, your suggestions would be appreciated.

Re: transition between full-length and shortened stems - please discuss

2011-02-20 Thread Han-Wen Nienhuys
2011/2/13 Janek Warchoł lemniskata.bernoull...@gmail.com: This is the first part of a series of changes to the stems and flags. The suggested change is small, but in my opinion important. Look at the attached transition testing.pdf - it illustrates the problem: the 'b' stem is definately too

Re: transition between full-length and shortened stems - please discuss

2011-02-20 Thread Han-Wen Nienhuys
2011/2/20 Han-Wen Nienhuys hanw...@gmail.com: This change is default over current lily, so let's put it in. I can't this change is an improvement over current lily [time to go to bed, I guess] -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen

Re: Footnotes in lilypond patch

2011-02-20 Thread Graham Percival
On Sun, Feb 20, 2011 at 06:31:09PM -0500, Mike Solomon wrote: I've sketched out the following code for footnotes in Lilypond (thank you very much Joe for your suggestions!). Thanks, added here: http://code.google.com/p/lilypond/issues/detail?id=737 The issue claims to have a bounty from Jiri

Re: a present for Graham

2011-02-20 Thread Graham Percival
On 2/19/11, Han-Wen Nienhuys hanw...@gmail.com wrote: The regtest also compares for memory and cpu use, but this test does not work very well. We should probably disable it by default. The cpu regtest *is* disabled by default. We're considering a patch to re-enable it:

Re: a present for Graham

2011-02-20 Thread Graham Percival
On 2/19/11, Han-Wen Nienhuys hanw...@gmail.com wrote: Also, could we dispense on esthetic changes on developer-only parts (like the regtest) ? This was not an esthetic proposal. I honestly (but mistakenly!) thought that the lack of complete bars made the spacing more fragile, which made it

Contributors: beware of invalid issues

2011-02-20 Thread Graham Percival
Hi all, Many new contributors look through our google issue tracker to find an open issue, then start working on it. One person recently did this, sent in a very nice patch, but then it turned out that the issue (which I had added) was actually invalid. This is extremely unfortunate, to say the

contributors / mentors

2011-02-20 Thread Graham Percival
Hi all, A year ago, I added a section to the CG about having mentors for contributors: http://lilypond.org/doc/v2.13/Documentation/contributor/mentors Sadly, it didn't take off -- I took on two doc contributors (just like the Grand Documentation Project, albeit on a small scale), but there

Footnotes now on Rietveld (issue 4167063)

2011-02-20 Thread m...@apollinemike.com
http://codereview.appspot.com/4167063 I got it up to a semi-unembarassing state. You can the same .ly I sent out to the list previously to test it. It draws a line now whenever there are footnotes and takes this line's Y extent into account for the page breaking algorithm. Cheers, MS

patch handlers

2011-02-20 Thread Graham Percival
I'm looking for volunteers to be patch handlers or patch helpers (or some other name). Description is in CG 8.6 Patch handling if you have the latest git master, or here if you don't: http://kainhofer.com/~lilypond/Documentation/contributor/patch-handling.html I'll be Path Meister for now, but

Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

2011-02-20 Thread Patrick McCarty
On Sun, Feb 20, 2011 at 4:38 AM, Ian Hulin ianhuli...@gmail.com wrote: Hi Patrick, On 18/02/11 02:13, pnor...@gmail.com wrote: LGTM. Can you email me your patch so I can apply it? Here's the patch. I retested everything, and the patch checks out just fine. I've pushed it. Thanks,