Re: exact inversion (issue4173065)

2011-02-21 Thread pkx166h
NR edits LGTM - can't comment on the other .ly files. Sorry. http://codereview.appspot.com/4173065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Question about @lilypond options for creating smaller page examples within our Doc

2011-02-21 Thread James Lowe
Hello, While editing the NR 3.2 section on Titles and Headers it seems it would be nice to be able to create 'smaller' (or rather, shorter) ' whole page output' when processing @lilypond examples, so as to show simple things like page breaks, tag lines and headers and footers without having to

Re: Fret diagram fixes (issue4176056)

2011-02-21 Thread neziap
I have added new tracker issue for this patch: http://code.google.com/p/lilypond/issues/detail?id=1530 http://codereview.appspot.com/4176056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Draws a line above footnotes (issue4167063)

2011-02-21 Thread bordage . bertrand
Wow, nice job Mike ! I am also currently trying to solve this issue. With Scheme only I managed to do a good solution for endnotes. I have some suggestions for your work : * There should be more space between separator line and footnotes. * Maybe a smaller separator, like LaTeX does. line-width

Re: transition between full-length and shortened stems - please discuss

2011-02-21 Thread Bernard Hurley
On Sun, Feb 20, 2011 at 11:08:05PM -0300, Han-Wen Nienhuys wrote: 2011/2/20 Han-Wen Nienhuys hanw...@gmail.com: This change is default over current lily, so let's put it in. I can't this change is an improvement over current lily It took me a lng time see any difference between the

Re: transition between full-length and shortened stems - please discuss

2011-02-21 Thread Janek Warchoł
2011/2/21 Han-Wen Nienhuys hanw...@gmail.com: Can you make your code be less hardcoded?  I propose something like:  factor = (1+abs(hp[dir])) / (2*staff_radius + 1)  shorten *= min(factor, 1.0) What staff_radius is? I tried to find an explanation, but to no avail... this way, it will work

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-02-21 Thread pkx166h
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846 Documentation/notation/simultaneous.itely:846:

Re: transition between full-length and shortened stems - please discuss

2011-02-21 Thread Han-Wen Nienhuys
2011/2/21 Janek Warchoł lemniskata.bernoull...@gmail.com: 2011/2/21 Han-Wen Nienhuys hanw...@gmail.com: Can you make your code be less hardcoded?  I propose something like:  factor = (1+abs(hp[dir])) / (2*staff_radius + 1)  shorten *= min(factor, 1.0) What staff_radius is? I tried to find

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-02-21 Thread ColinPKCampbell
revised patch uploaded. http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846

Re: transition between full-length and shortened stems - please discuss

2011-02-21 Thread Janek Warchoł
2011/2/21 Han-Wen Nienhuys hanw...@gmail.com: 2011/2/21 Janek Warchoł lemniskata.bernoull...@gmail.com: 2011/2/21 Han-Wen Nienhuys hanw...@gmail.com: Can you make your code be less hardcoded?  I propose something like:  factor = (1+abs(hp[dir])) / (2*staff_radius + 1)  shorten *= min(factor,

Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-21 Thread Han-Wen Nienhuys
On Fri, Feb 18, 2011 at 7:46 PM, k-ohara5...@oco.net wrote: Why not use a sequence of Rationals [..] to represent the alteration? A single Rational can hold the series as a sum, and preserve the separability of the terms, if we use mutually prime denominators. In scales where cih is

Re: Draws a line above footnotes (issue4167063)

2011-02-21 Thread joeneeman
http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc#newcode189 lily/note-head.cc:189: footnote Any particular reason this belongs to note-head-interface (rather than, say,

Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-21 Thread Felipe Gonçalves Assis
Hey, lilypond-devel complained about the recipient list of this message, so I am resending it. Sorry for those who are receiving it for the second time. -- Forwarded message -- Hello everyone, First of all, thanks for the extensive comments made on this. I will try to address

Re: Question about @lilypond options for creating smaller page examples within our Doc

2011-02-21 Thread Graham Percival
On Mon, Feb 21, 2011 at 11:47:18AM +, James Lowe wrote: It seems to me that I cannot create an explicit output size by specifying height and width dimensions, like I can specify a line length within a @lilypond [xxx] variable. Hmm. Is there a difference between width dimension and line

PATCHES: 48-hour notice for markuplines crash and toc lines

2011-02-21 Thread Graham Percival
Thurs 9am. Assuming we want \markuplines { } to behave like \markup { } (i.e., produce a \null toplevel markup), then this patch works, since it ensures a valid Paper_score in paper-book.cc: http://codereview.appspot.com/4160059/ Add dots to tocItemMarkup http://codereview.appspot.com/4182056/