On Sun, Feb 27, 2011 at 09:23:00PM +0100, Reinhold Kainhofer wrote:
Am Sonntag, 27. Februar 2011, um 21:03:35 schrieb Graham Percival:
git rebase -i origin/master
are there any dangers with that?
That's why a do a git rebase origin/master (non-interactive)
first, where I only have to
On Sun, 27 Feb 2011 23:58:45 -0800, Graham Percival gra...@percival-music.ca
wrote:
Did you intend to remove the dodecaphonic accidentals snippet from our
docs? If so (i.e. it's been replaced with 2.13 functionality), then
we needs some magic in Documentation/snippets/new/ .
Yes; it was
Reviewers: ,
Message:
We've had a doc editor doing bugger-all for the past two weeks because
nobody cooked up this 8-line python patch.
Please review. I'm pushing it in 24 hours unless somebody screams.
Description:
lilypond-book: add [pagesize=xyz] option.
This will be *extremely* useful
Test case: foo.tely:
\input texinfo @node Top
@top
Texinfo text
@lilypond[papersize=a8]
\book{
\score {
\relative c' {
a4 b c d
a4 b c d
a4 b c d
a4 b c d
a4 b c d
a4 b c d
a4 b c d
a4 b c d
a4 b c d
a4 b c d
}
}}
@end lilypond
@bye
I'd like a bug to be open about this, if possible. Translated docs
used to make all comments, context IDs and variable names in lilypond
code to become translated from strings in
Documentation/po/language.po files. This does not work anymore and
we are not able to determine when did stop working.
/main/src/gub/target/freebsd-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/beam-quanting.cc:638:
error: 'round' was not declared in this scope
I'm guessing that you need to explicitly include some other header
because round() is in default in glibc but not in freebsd libc,
Graham Percival schreef op ma 28-02-2011 om 09:35 [+]:
/main/src/gub/target/freebsd-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/beam-quanting.cc:638:
error: 'round' was not declared in this scope
I'm guessing that you need to explicitly include some other header
On 2/28/11, Jan Nieuwenhuizen jann...@gnu.org wrote:
Graham Percival schreef op ma 28-02-2011 om 09:35 [+]:
/main/src/gub/target/freebsd-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/beam-quanting.cc:638:
error: 'round' was not declared in this scope
I'm guessing
Reviewers: Graham Percival,
Message:
Hi Graham,
here is a revised patch.
Cheers,
patrick
Description:
harmonics and slides
new patch
# This will displayed on the codereview site.
harmonics-and-slides-V
include file for chord glissando
harmonics-and-slides-IV
new snippets
I had to run
scripts/makelsr.py
before I could compile this patch. Please do the same, then do:
git add Documentation/snippets/*.ly
git commit .
and upload a new patch.
Other than that, LGTM.
http://codereview.appspot.com/4186049/
___
http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh
File scripts/auxiliar/doc-section.sh (right):
http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh#newcode33
scripts/auxiliar/doc-section.sh:33: FROMDIR=$HOME/lilypond-git
I totally
I've changed scripts/auxiliar/doc-section.sh to use ~/lilypond-git/ by
default, since this was confusing some contributors and the change had
snuck into a patch they were proposing.
Sorry for the inconvenience if you use a different dir, but we should
make it simple for beginners and
Is it ok, now?
Thanks,
patrick
http://codereview.appspot.com/4186049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On Feb 27, 2011, at 11:27 PM, hanw...@gmail.com wrote:
On 2011/02/28 04:06:03, hanwenn wrote:
There are two issues in the regtest: it gets confused by x-staff
beams, and it
tries to avoid the start of staff clef when the beam crosses a line
breaks.
fixed.
LGTM
http://codereview.appspot.com/4186049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Graham Percival wrote Monday, February 28, 2011 7:39 AM
On 2/27/11, Janek Warchoł lemniskata.bernoull...@gmail.com
wrote:
Here you are. This contains all the changes and should apply
cleanly
to origin/master.
Thanks, pushed.
This commit causes many changes to the reg tests due to the
2011/2/28 Trevor Daniels t.dani...@treda.co.uk
Graham Percival wrote Monday, February 28, 2011 7:39 AM
On 2/27/11, Janek Warchoł lemniskata.bernoull...@gmail.com wrote:
Here you are. This contains all the changes and should apply cleanly
to origin/master.
Thanks, pushed.
This commit
On Mon, Feb 28, 2011 at 8:21 AM, m...@apollinemike.com
m...@apollinemike.com wrote:
fixed.
http://codereview.appspot.com/4239047/
Several of the tests that I've been running work better with this new version
- large collisions are now handled no problem.
The only things that don't work
One comment.
Thanks for your time.
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode427
LGTM.
Just one trivial nitpick.
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode389
LGTM.
Thanks,
Carl
http://codereview.appspot.com/4239048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Great work! Two comments below concerning beam properties.
http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc#newcode1156
lily/beam.cc:1156: Real min_y_size = 2.0;
here, we should have something
Attached is the type of note-on-beam thing I was talking about in my previous
comments, which can be fixed w/ a padding property.
Cheers,
MS
inline: beamnote.png
On Feb 28, 2011, at 9:48 AM, mts...@gmail.com wrote:
Great work! Two comments below concerning beam properties.
Graham, thanks.
Do we not want to make a custom edit in the .scm file also?
Perhaps, with a size of height 35mm. This was about the minimum size I
was able to create the default 'This is a scale in LilyPond' PDF created
from the first time you run the binary that also includes space for the
On Mon, Feb 28, 2011 at 11:48 AM, mts...@gmail.com wrote:
Great work! Two comments below concerning beam properties.
http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc#newcode1156
lily/beam.cc:1156: Real min_y_size = 2.0;
here, we should have something like
if (to_boolean
On 2/28/11, pkx1...@gmail.com pkx1...@gmail.com wrote:
Do we not want to make a custom edit in the .scm file also?
Perhaps, with a size of height 35mm.
a10 is 26mm by 37m. c10 is 28 by 40mm. pa10 is 26mm by 35mm.
*shrug*
if one of those isn't small enough (also don't forget about landscape
On Mon, Feb 28, 2011 at 11:48 AM, mts...@gmail.com wrote:
Great work! Two comments below concerning beam properties.
http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc#newcode1156
- Original Message -
From: Graham Percival gra...@percival-music.ca
a10 is 26mm by 37m.
Must be like very thin toilet tissue. Is it perforated?
--
Phil Holmes
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Le 28/02/2011 18:27, Phil Holmes disait :
- Original Message - From: Graham Percival
gra...@percival-music.ca
a10 is 26mm by 37m.
Must be like very thin toilet tissue. Is it perforated?
Just for information:
http://en.wikipedia.org/wiki/Paper_format
Cheers,Jean-Charles
Reviewers: ,
Message:
This is a patch from Phil. I've made some minor formatting changes to
bring it in line with the CG.
http://codereview.appspot.com/4250044
Description:
Doc: NR @Knownissues for Grace Notes in many Voices
This is http://code.google.com/p/lilypond/issues/detail?id=667
LGTM
http://codereview.appspot.com/4250044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Am 28.02.2011 um 14:21 schrieb pkx1...@gmail.com:
One comment.
Thanks for your time.
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
Hi all,
here is a revised patch. I hope everything is ok now. I don't know why
two files I did not alter are part of this patch:
hymn-template.ly and partcombine-and-autobeamoff.ly.
BTW I accidentally created another issue number (4245047). Sorry for
that. How can I delete it?
Thanks for your
Patrick
-Original Message-
From: p.l.schm...@gmx.de
Reply-To: p.l.schm...@gmx.de, percival.music...@gmail.com,
pkx1...@gmail.com, tdanielsmu...@googlemail.com, lilypond-devel
lilypond-devel@gnu.org, re...@codereview.appspotmail.com
Date: Mon, 28 Feb 2011 21:00:15 +
To:
Am 28.02.2011 um 22:14 schrieb James Lowe:
Patrick
-Original Message-
From: p.l.schm...@gmx.de
Reply-To: p.l.schm...@gmx.de, percival.music...@gmail.com,
pkx1...@gmail.com, tdanielsmu...@googlemail.com, lilypond-devel
lilypond-devel@gnu.org, re...@codereview.appspotmail.com
On 28 February 2011 21:06, m...@apollinemike.com m...@apollinemike.com wrote:
I found a problem w/ my footnote work. Check out the 2nd example in bad.ly
and bad.pdf . Why do you think the annotation is placed so far to the left
here but not in other cases?
You're setting the spanner
On 28 February 2011 00:32, mts...@gmail.com wrote:
For now, I'm just gonna remove this kludge and leave it as is. It means
that certain spanners may budge when annotations are attached to them,
but I'll need more time to figure out a sustainable way to get the axis
engraver to ignore the
On Feb 28, 2011, at 5:42 PM, Neil Puttock wrote:
On 28 February 2011 00:32, mts...@gmail.com wrote:
For now, I'm just gonna remove this kludge and leave it as is. It means
that certain spanners may budge when annotations are attached to them,
but I'll need more time to figure out a
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc
File lily/balloon.cc (right):
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc#newcode77
lily/balloon.cc:77: Grob *commonx = bounds[LEFT]-common_refpoint
(bounds[RIGHT], X_AXIS);
You might as well say
Grob
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc
File lily/balloon.cc (right):
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc#newcode77
lily/balloon.cc:77: Grob *commonx = bounds[LEFT]-common_refpoint
(bounds[RIGHT], X_AXIS);
On 2011/02/28 23:04:21, Neil
http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc
File lily/footnote-engraver.cc (right):
http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode67
lily/footnote-engraver.cc:67: b-set_property (footnote-text,
event-get_property
http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc
File lily/footnote-engraver.cc (right):
http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode67
lily/footnote-engraver.cc:67: b-set_property (footnote-text,
event-get_property
Hey mike,
have a look at the .ly below
In this case, the 2nd beam and a note from the 2nd beam get added to
the 1st beam. Can you make sure this does not happen?
thanks,
\context PianoStaff
\new Staff = one \relative c'{
\autoBeamOff
\stemUp c8 c \change Staff=two \stemUp c c
This does the trick.
\score {
\new PianoStaff
\new Staff = one \relative c'{
\autoBeamOff
\stemUp c8 c \change Staff=two \stemUp c c
c c c c
\change Staff=one
\stemDown c8 c \change Staff=two \stemUp c c
r2
\stemDown c8[ c \change Staff=one \stemDown c c]
r2
44 matches
Mail list logo
