Re: improving the transition between full-length and shortenedstems. (issue4210051)

2011-03-02 Thread Trevor Daniels
Janek Warchoł wrote Wednesday, March 02, 2011 8:53 PM 2011/3/1 Trevor Daniels Yes, they are longer, but the stems on the full-size notes look too long in this context to my eye. I've attached the output from 2.13.52. In my opinion it is ok. It's OK; just not optimum when isolated like

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread Joe Neeman
On Thu, Mar 3, 2011 at 3:08 AM, Mike Solomon wrote: > On Mar 2, 2011, at 8:05 AM, Mike Solomon wrote: > > > On Mar 2, 2011, at 7:23 AM, joenee...@gmail.com wrote: > > > >> I haven't had time to look at this carefully, but I'll have closer look > >> later. What I don't understand, though, is why t

Re: PATCHES: 48-hour notice for fret diagrams and hamonics+chord glissando

2011-03-02 Thread Nicolas Sceaux
Le 2 mars 2011 à 08:08, Graham Percival a écrit : > Friday, 9am UK time. > > > Fret diagram fixes > http://codereview.appspot.com/4176056/ I'm still taking care of this one... but my pace regarding LilyPond dev is just really slow. ___ lilypond-deve

Re: Cleaning Feta flags code (issue4236043)

2011-03-02 Thread lemniskata . bernoullego
Indents fixed. Sorry it took so long - i had limited access to my lilydev-enabled machine. http://codereview.appspot.com/4236043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: improving the transition between full-length and shortenedstems. (issue4210051)

2011-03-02 Thread Janek Warchoł
2011/3/1 Trevor Daniels > > Janek Warchoł wrote Monday, February 28, 2011 1:02 PM > >> 2011/2/28 Trevor Daniels >> >>> This commit causes many changes to the reg tests due to the small >>> increase in some of the stems that protrude beyond the staff. >>> Virtually all of the changes look good, bu

Re: Commit df1b639baf "Fixes round problem" appears wrong to me.

2011-03-02 Thread Han-Wen Nienhuys
On Tue, Mar 1, 2011 at 7:51 PM, David Kastrup wrote: > The diff says something like > >    { >       Real yshift = config->y[LEFT] - 0.5 * staff_space; > -      if (abs (round(yshift) - yshift) < 0.01 * staff_space) > +      if (abs ((int)(yshift + 0.5) - yshift) < 0.01 * staff_space) >         co

Re: 13.52 regtests

2011-03-02 Thread Keith OHara
Trevor Daniels treda.co.uk> writes: > > lyrics-bar.png - > > This is OK. The "no" is part of the lyrics to the lower staff, > "no Bar_Engraver_Bar_Engraver_Bar_Engraver" :) > > It still shows the bar being pushed out to accommodate the > long syllable, as it should. > LilyPond passes what tha

Re: 13.52 regtests

2011-03-02 Thread Phil Holmes
- Original Message - From: "Neil Puttock" To: "Phil Holmes" Cc: Sent: Wednesday, March 02, 2011 6:16 PM Subject: Re: 13.52 regtests On 2 March 2011 16:48, Phil Holmes wrote: > full-measure-rest-fermata.ly - this shows that markup attached to a note > is > kept within the music, bu

Re: 13.52 regtests

2011-03-02 Thread Neil Puttock
On 2 March 2011 16:48, Phil Holmes wrote: > full-measure-rest-fermata.ly - this shows that markup attached to a note is > kept within the music, but not markup attached to a FMR.  I'd suggest this > is a bug, although not a regression.  Anyone other views? Markup attached to a full-bar rest is a

Re: 13.52 regtests

2011-03-02 Thread Trevor Daniels
"Phil Holmes" wrote in message news:iklsd6$r1v$1...@dough.gmane.org... lyrics-bar.png - the music now breaks over the line to accommodate the text (which is OK), but see the "no" now sitting in the stave. Anyone know what's going on here? This is OK. The "no" is part of the lyrics to t

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread Mike Solomon
On Mar 2, 2011, at 8:05 AM, Mike Solomon wrote: > On Mar 2, 2011, at 7:23 AM, joenee...@gmail.com wrote: > >> I haven't had time to look at this carefully, but I'll have closer look >> later. What I don't understand, though, is why this problem needs such >> extensive changes. If it's just a matt

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread Mike Solomon
On Mar 2, 2011, at 7:23 AM, joenee...@gmail.com wrote: > I haven't had time to look at this carefully, but I'll have closer look > later. What I don't understand, though, is why this problem needs such > extensive changes. If it's just a matter of preventing repeated > footnotes at the beginning/e

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread joeneeman
I haven't had time to look at this carefully, but I'll have closer look later. What I don't understand, though, is why this problem needs such extensive changes. If it's just a matter of preventing repeated footnotes at the beginning/end of a line, it should be enough to examine footnote->get_colu

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread Mike Solomon
On Mar 1, 2011, at 10:19 PM, pnor...@gmail.com wrote: > Hi Mike, > > I have a quick comment for you below. > > Thanks, > Patrick > > > http://codereview.appspot.com/4213042/diff/24035/scm/define-stencil-commands.scm > File scm/define-stencil-commands.scm (right): > > http://codereview.appspot