Re: 13.52 regtests

2011-03-06 Thread Keith OHara
Phil Holmes philholmes.net> writes: > > lyrics-bar.png - the music now breaks over the line to accommodate the text > mensural-ligatures.ly - one of the staves now disappears over the edge of > the page. These two tests suffered somewhat from making keep-inside-line = ##t, so I adjusted to c

Re: Wrong loop boundaries when iterating over markup list (issue4236047)

2011-03-06 Thread k-ohara5a5a
Boris, This is the last remaining critical bug preventing version 2.14. I applied the suggestions above to your patch, resulting in http://codereview.appspot.com/4253061/ Would you either comment there, or adopt the revisions, whichever is appropriate given the amount of time you can give to Li

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-03-06 Thread ColinPKCampbell
On 2011/03/06 12:13:15, Reinhold wrote: http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871 Doc

Re: shortened flags affair, part 4 - downstem 8th flag

2011-03-06 Thread Carl Sorensen
On 3/6/11 2:44 AM, "Janek Warchoł" wrote: > 2011/3/6 Carl Sorensen : >> >>> bars 8,9,11: ugly slurs, bad placement in bar 8 >> >> I agree with 9 and 11 having ugly slurs -- too sharply peaked. >> >> I've changed the slur scoring so that it doesn't try to move slurs away from >> staff lines.

Re: Modifies the Staff_symbol::print function to address Issue 1506 (issue4253059)

2011-03-06 Thread Neil Puttock
On 7 March 2011 00:17, m...@apollinemike.com wrote: > Blech... Couldn't have put it better myself. ;) Try the attached patch. I can't test it properly until tomorrow evening, but it doesn't appear to break anything. Cheers, Neil From 920eedbe36b465e8a17b30d6b41474a73197f217 Mon Sep 17 00:00:00

Modifies the Staff_symbol::print function to address Issue 1506 (issue4253059)

2011-03-06 Thread m...@apollinemike.com
Blech... http://codereview.appspot.com/4253059 But it works! Cheers, MS___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix to Issue 1506 (issue4243060)

2011-03-06 Thread m...@apollinemike.com
On Mar 6, 2011, at 19:04, Neil Puttock wrote: > On 6 March 2011 23:30, m...@apollinemike.com wrote: >> It's dirt simple, and perhaps breaks other things, but it works. > > Judging by the original commit > (http://repo.or.cz/w/lilypond/mirror.git/commit/2f47e632d869f7adfffa656b79a6f76cfa31a11e?f

Re: Fix to Issue 1506 (issue4243060)

2011-03-06 Thread Neil Puttock
On 6 March 2011 23:30, m...@apollinemike.com wrote: > It's dirt simple, and perhaps breaks other things, but it works. Judging by the original commit (http://repo.or.cz/w/lilypond/mirror.git/commit/2f47e632d869f7adfffa656b79a6f76cfa31a11e?f=lily/staff-symbol.cc), it will break this snippet: http

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

2011-03-06 Thread mtsolo
Reviewers: Neil Puttock, Message: Thanks Neil! New patch set uploaded. Cheers, Mike http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc File lily/balloon.cc (right): http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode38 lily/balloon.cc:38: static SCM internal_balloo

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

2011-03-06 Thread n . puttock
http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode180 scm/define-grobs.scm:180: (annotation-balloon . #f) On 2011/03/06 23:35:28, Neil Puttock wrote: remove Oops, I mean

Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

2011-03-06 Thread n . puttock
Hi Mike, Just a few minor nitpicks for you. Cheers, Neil http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc File lily/balloon.cc (right): http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode38 lily/balloon.cc:38: static SCM internal_balloon_print (Grob *me, Grob *p,

Fix to Issue 1506 (issue4243060)

2011-03-06 Thread m...@apollinemike.com
It's dirt simple, and perhaps breaks other things, but it works. If someone could run the reg-tests, I'd be much obliged! It's also possible to include the deleted code but gate it via some sorta boolean grob property set for the StaffSymbol, but I wouldn't know what to call this property. http

13.53 regtests

2011-03-06 Thread Phil Holmes
All looking pretty good. A number have changed since it looks like lyrics are placed slightly further from the staff than before - this pushes lower staves down. completion-heads-factor.ly has had some more notes added to the test. page-spacing-staff-group-nested.ly now sets the nested staves

2nd stage of footnote patch (issue 4254055)

2011-03-06 Thread m...@apollinemike.com
http://codereview.appspot.com/4254055 This implements the annotation part. No real new stuff, but smaller and easier to digest. Let me know what you think! Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman

Re: Toolchain to get scores into video?

2011-03-06 Thread Neil Puttock
On 6 March 2011 17:33, David Kastrup wrote: > James Lowe writes: > >> The google tracker issue does work in as much as the main point of this is >> to split the Lilypond score into 'lines' and each line is exported to an >> EPS file - this bit is done by Lilypond (IIR) you can then manually put >

Re: Toolchain to get scores into video?

2011-03-06 Thread m...@apollinemike.com
On Mar 6, 2011, at 12:33, David Kastrup wrote: > James Lowe writes: > >> The google tracker issue does work in as much as the main point of this is >> to split the Lilypond score into 'lines' and each line is exported to an >> EPS file - this bit is done by Lilypond (IIR) you can then manually

Re: Toolchain to get scores into video?

2011-03-06 Thread David Kastrup
James Lowe writes: > The google tracker issue does work in as much as the main point of this is > to split the Lilypond score into 'lines' and each line is exported to an > EPS file - this bit is done by Lilypond (IIR) you can then manually put > each line into a video using most standard video e

Re: Toolchain to get scores into video?

2011-03-06 Thread James Lowe
The google tracker issue does work in as much as the main point of this is to split the Lilypond score into 'lines' and each line is exported to an EPS file - this bit is done by Lilypond (IIR) you can then manually put each line into a video using most standard video editing software, this bit is

Clarification for footnotes push commit message

2011-03-06 Thread m...@apollinemike.com
Hey all, In the commit message about the footnote push, you'll see a line about TEST ONLY. What I mean here is that it is only 1/2 of the feature and thus should not yet be documented or considered complete (as discussed in previous emails). There is nothing test-ish about the implementation, ho

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-06 Thread Mike Solomon
On Mar 5, 2011, at 10:43 AM, Neil Puttock wrote: > On 5 March 2011 14:38, Mike Solomon wrote: > >> Done - thanks for bearing with me as I learn about break-visibility. It is >> a corner of the code that I never had to deal with directly, so I'm still >> getting my sea legs. > > I suggest you

Potential fix for issue 1504 (issue4237057)

2011-03-06 Thread m...@apollinemike.com
Hey all, A potential fix for issue 1504 is posted here: http://codereview.appspot.com/4237057/ I haven't had time to run the regtests yet (traveling), but will in the next few days. There is, however, an additional regtest (see patch) that shows this patch in action. Lemme know what you thin

Re: Toolchain to get scores into video?

2011-03-06 Thread Graham Percival
On Sun, Mar 06, 2011 at 03:55:50PM +0100, David Kastrup wrote: > > But the question is how to get this kind of thing out of Lilypond and > into a video stream. http://code.google.com/p/lilypond/issues/detail?id=965 If you can make a dvd, then you can certainly make a plain old video. (I haven't

Toolchain to get scores into video?

2011-03-06 Thread David Kastrup
Here is an example of what I mean: http://www.youtube.com/watch?v=gMBJowDdFq4> This is organized as a vertically scrolling endless paper strip with a running cursor. It would also be conceivable to just have a horizontally scrolling endless staffgroup. But the question is how to get this kind

LilyPond speed. Idea for Schikkers list

2011-03-06 Thread Janek Warchoł
Hi, how fast would be LilyPond if we turned off collision detecting, optical spacing, line breaking, beam quanting and sloping, slur shaping, etc etc etc - basically everything except placing symbols on paper in one infinately long system? I thought this can be checked by remowing all possible eng

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-03-06 Thread reinhold . kainhofer
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871 Documentation/notation/simultaneous.itely:871:

PATCHES: 48-hour notice for feta flag code and key signatures

2011-03-06 Thread Graham Percival
Tues, 9am. Cleaning Feta flags code http://codereview.appspot.com/4236043/ One-line fix for key signatures should be inherited by all Voices http://code.google.com/p/lilypond/issues/detail?id=897 Cheers, - Graham ___ lilypond-devel mailing list lilyp

Re: a list of manually fine-tuned beaming exceptions?

2011-03-06 Thread Trevor Daniels
wrote Saturday, March 05, 2011 11:05 PM On Mar 5, 2011, at 17:33, Janek Warchoł wrote: 2011/3/5 Trevor Daniels : When I suggested investigating the automatic beaming I didn't mean messing with the code. But there are a number of parameters in the #'details property of beam which might

Re: shortened flags affair, part 4 - downstem 8th flag

2011-03-06 Thread Trevor Daniels
Janek Warchoł wrote Sunday, March 06, 2011 1:54 AM I was curious too, so i wrote it down. Indeed it looks like he used non-default layout (by default Lily uses 3 systems), but i won't call it non-optimal. In my opinion fitting this music in two systems is perfectly reasonable here (and maybe

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-03-06 Thread tdanielsmusic
LGTM, apart from a minor nitpick in original text http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (left): http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#oldcode8