Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread Han-Wen Nienhuys
On Mon, Mar 28, 2011 at 8:13 AM, hanw...@gmail.com wrote: http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread mtsolo
Fixed w/ Han-Wen's suggestions. http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55 lily/beam-collision-engraver.cc:55: if

using the feta font in a GPL2 application

2011-03-28 Thread Florian Jung
Hi we'd like to use the feta font, or actually single glyphs rendered to png-files, in a muse2, a GPL2 linux sequencer. i've added a score editor to the sequencer, however it's using the feta font, and we don't know if we may use a GPL3-ed font in our GPL2 application. may we :)? Greetings

Re: using the feta font in a GPL2 application

2011-03-28 Thread Carl Sorensen
On 3/28/11 7:06 AM, Florian Jung florian.a.j...@web.de wrote: Hi we'd like to use the feta font, or actually single glyphs rendered to png-files, in a muse2, a GPL2 linux sequencer. i've added a score editor to the sequencer, however it's using the feta font, and we don't know if we may

Re: using the feta font in a GPL2 application

2011-03-28 Thread Florian Jung
Am 28.03.2011 15:33, schrieb Carl Sorensen: On 3/28/11 7:06 AM, Florian Jungflorian.a.j...@web.de wrote: Hi we'd like to use the feta font, or actually single glyphs rendered to png-files, in a muse2, a GPL2 linux sequencer. i've added a score editor to the sequencer, however it's

Re: Don't set 'tieMelismaBusy until old waiting heads have been cleared (issue4309052)

2011-03-28 Thread percival . music . ca
Time for complaints is over; please push. http://codereview.appspot.com/4309052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Suppress continuing LyricHyphen under grace note at start of line (issue4313047)

2011-03-28 Thread percival . music . ca
Time for complaints is over; please push. http://codereview.appspot.com/4313047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: using the feta font in a GPL2 application

2011-03-28 Thread Graham Percival
On 3/28/11, Florian Jung florian.a.j...@web.de wrote: Am 28.03.2011 15:33, schrieb Carl Sorensen: As far as permission to use it the current font under GPL2, I think Han-Wen and Jan need to give that permission. i assume Han-Wen and Jan also read that mailing list, so i'm asking for

Re: Allows glissandi to be continuous at line breaks (issue4273098)

2011-03-28 Thread percival . music . ca
LGTM http://codereview.appspot.com/4273098/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allows glissandi to be continuous at line breaks (issue4273098)

2011-03-28 Thread m...@apollinemike.com
On Mar 28, 2011, at 10:08 AM, percival.music...@gmail.com wrote: LGTM Pushed. 94860164493ab3a209986b0e3662ff7bd8958cb5 Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Suppress continuing LyricHyphen under grace note at start of line (issue4313047)

2011-03-28 Thread tdanielsmusic
Pushed. 2fb262fb403b75907bdebbaf7fbb819733bf6355 http://codereview.appspot.com/4313047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Don't set 'tieMelismaBusy until old waiting heads have been cleared (issue4309052)

2011-03-28 Thread Trevor Daniels
percival.music...@gmail.com wrote Monday, March 28, 2011 3:02 PM Time for complaints is over; please push. http://codereview.appspot.com/4309052/ Actually the time-out is 23.59 tonight. I'll wait 'til then. (But I already pushed http://codereview.appspot.com/4313047/, which times out

Re: using the feta font in a GPL2 application

2011-03-28 Thread Han-Wen Nienhuys
On Mon, Mar 28, 2011 at 11:08 AM, Graham Percival gra...@percival-music.ca wrote: As far as permission to use it the current font under GPL2, I think Han-Wen and Jan need to give that permission. i assume Han-Wen and Jan also read that mailing list, so i'm asking for permission to use the

[PATCH]: Doc: NR more examples to Repeats for beat slashes

2011-03-28 Thread James Lowe
Doc: NR more examples to Repeats for beat slashes This is for Tracker Issue #1574 (also updated with a link to this Rietveld issue) Showing short-duration repeats and beat slashes along with mixed length notes. http://codereview.appspot.com/4273125 James attachment:

Re: using the feta font in a GPL2 application

2011-03-28 Thread Florian Jung
Am 28.03.2011 20:21, schrieb Han-Wen Nienhuys: On Mon, Mar 28, 2011 at 11:08 AM, Graham Percival gra...@percival-music.ca wrote: As far as permission to use it the current font under GPL2, I think Han-Wen and Jan need to give that permission. i assume Han-Wen and Jan also read

Re: Allows glissandi to be continuous at line breaks (issue4273098)

2011-03-28 Thread n . puttock
Hi Mike, Can you add a regression test for this please? BTW, I've just done a quick test with this snippet pair; don't you think they look a bit weird? \version 2.13.56 % heavily damped at both broken bounds \score { \relative c' { \override Glissando #'after-line-breaking = ##t

Re: using the feta font in a GPL2 application

2011-03-28 Thread Carl Sorensen
On 3/28/11 12:48 PM, Florian Jung florian.a.j...@web.de wrote: Am 28.03.2011 20:21, schrieb Han-Wen Nienhuys: On Mon, Mar 28, 2011 at 11:08 AM, Graham Percival gra...@percival-music.ca wrote: As far as permission to use it the current font under GPL2, I think Han-Wen and Jan need to

Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread n . puttock
Hi James, Thanks for doing this. It LGTM (but don't forget to remove the @knownissue) Just two suggestions for you: a changes.itely entry is probably a good idea, and the @seealso for the Internals Reference needs the following items added: DoublePercentEvent DoubleRepeatSlash

Re: Allows glissandi to be continuous at line breaks (issue4273098)

2011-03-28 Thread m...@apollinemike.com
On Mar 28, 2011, at 3:27 PM, n.putt...@gmail.com wrote: Hi Mike, Can you add a regression test for this please? BTW, I've just done a quick test with this snippet pair; don't you think they look a bit weird? \version 2.13.56 % heavily damped at both broken bounds \score {

Re: Don't set 'tieMelismaBusy until old waiting heads have been cleared (issue4309052)

2011-03-28 Thread n . puttock
LGTM. http://codereview.appspot.com/4309052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Suppress continuing LyricHyphen under grace note at start of line (issue4313047)

2011-03-28 Thread n . puttock
Hi Trevor, I hope you don't mind the following late comments. :) Cheers, Neil http://codereview.appspot.com/4313047/diff/1/input/regression/lyric-hyphen-grace.ly File input/regression/lyric-hyphen-grace.ly (right):

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread n . puttock
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode50 lily/beam-collision-engraver.cc:50: sort (covered_grobs_.begin (),

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread Graham Percival
On Sun, Mar 27, 2011 at 11:03:19AM +, lemniskata.bernoull...@gmail.com wrote: New patch set uploaded. Font size is now taken into account when calculating flag variants (one TODO eliminated). Thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1582 Cheers, - Graham

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread percival . music . ca
LTGM, and I agree with Neil's comments. http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Fixes bug for glissando spanning, adds regtest. (issue4303059)

2011-03-28 Thread mtsolo
Reviewers: , Message: Sorry again for the premature push - this adds a regtest and clears up the bug Neil pointed out. Description: Fixes bug for glissando spanning, adds regtest. Please review this at http://codereview.appspot.com/4303059/ Affected files: A

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread pkx166h
Reviewers: Neil Puttock, Graham Percival, Message: On 2011/03/28 20:04:37, Neil Puttock wrote: Hi James, Thanks for doing this. It LGTM (but don't forget to remove the @knownissue) Thanks, I missed that. Done. Just two suggestions for you: a changes.itely entry is probably a good

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread pkx166h
Second Draft. http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread percival . music . ca
LGTM http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread mtsolo
New patch set uploaded. http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode50 lily/beam-collision-engraver.cc:50: sort

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread lemniskata . bernoullego
http://codereview.appspot.com/4312057/diff/10001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4312057/diff/10001/lily/stem.cc#newcode744 lily/stem.cc:744: flag_style = standard; Of course this will be properly encoded like other flag variants, as soon as i fint out how.

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread lemniskata . bernoullego
Sorry, i clicked publish button too fast. New patch set uploaded, 1 TODO partly eliminated. cheers, Janek http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread percival . music . ca
Looks much more readable, thanks! http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode59 lily/beam-collision-engraver.cc:59: //

Re: Suppress continuing LyricHyphen under grace note at start of line (issue4313047)

2011-03-28 Thread Trevor Daniels
n.putt...@gmail.com wrote Monday, March 28, 2011 9:17 PM I hope you don't mind the following late comments. :) Not at all; I pushed it earlier than I should anyway. Thanks! http://codereview.appspot.com/4313047/diff/1/input/regression/lyric-hyphen-grace.ly#newcode15

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread m...@apollinemike.com
On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote: Looks much more readable, thanks! http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right):

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread lemniskata . bernoullego
New patch set uploaded, minor bugfix. http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel