http://codereview.appspot.com/4384050/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):
http://codereview.appspot.com/4384050/diff/1/scm/music-functions.scm#newcode1007
scm/music-functions.scm:1007: (define (accidental-voided?
alteration-def)
On 2011/04/12 03:39:18, Keith wrot
On 2011/04/12 07:04:42, Keith wrote:
This solves the critical bug,
but I would like a future patch to replace this with a mapping to
replace ( by
\( etc.
(string-delete has arguments in the order opposite to Scheme
documentation to
compensate for a bug in Guile, fixed in Guile 1.9.)
Don'
http://codereview.appspot.com/4382052/diff/1/scm/framework-ps.scm
File scm/framework-ps.scm (right):
http://codereview.appspot.com/4382052/diff/1/scm/framework-ps.scm#newcode412
scm/framework-ps.scm:412: (markup->string val) illegals)
Apart from creating a new char set on every round, this s
n.putt...@gmail.com:
There was a discussion last year about dynamics in polyphony which
you
might find interesting:
http://lists.gnu.org/archive/html/bug-lilypond/2010-09/msg00253.html
I'm afraid I agree with Trevor's reply in that thread.
Your memory is better than mine, Neil! Thanks for
Hello (taken from a thread on 'user')
)-Original Message-
)From: lilypond-user-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-user-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Keith OHara
)Sent: 12 April 2011 06:22
)To: lilypond-u...@gnu.org
)Subject: Re: status of rel
Ok. But you agree with the other grobs ?
http://codereview.appspot.com/4387046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
James, you wrote Tuesday, April 12, 2011 10:07 AM
)bruys . gmail.com> writes:
)
)> I wondered if
)> \partcombine is supposed to work with more than two parts. The
)> documentation refers to combining "several" parts, but only shows
)> examples with two parts.
The word "several" is used only i
On Apr 12, 2011, at 12:20 AM, Werner LEMBERG wrote:
>
>> \ No newline at end of file
>
> You should adjust your editor's text mode to automatically insert a
> newline at the end of the file if it isn't present yet... IIRC, I've
> seen this diff message a few times already in your patches. :-)
>
On Apr 12, 2011, at 12:32 AM, Colin Campbell wrote:
> On 11-04-11 05:11 PM, mts...@gmail.com wrote:
>> Reviewers: ,
>>
>> Message:
>> I was able to figure out a way to do this w/o an extra offset (I think).
>> Please, read, test, & report back.
>>
>> Cheers,
>> MS
>
> Mike, is this a new patch
On Apr 12, 2011, at 12:53 AM, Colin Campbell wrote:
> On 11-04-11 05:11 PM, mts...@gmail.com wrote:
>> Reviewers: ,
>>
>> Message:
>> I was able to figure out a way to do this w/o an extra offset (I think).
>> Please, read, test, & report back.
>>
>> Cheers,
>> MS
>>
>> Description:
>> Changes
Reviewers: ,
Message:
This fixes issue 1605. Keith's patch takes the "\" bug into account. But
this bug also occures with simple markups, so I assume this hasn't to be
fixed.
Description:
Fix issue 1605
PDF metadata for titles now handle unclosed parentheses.
Please review this at http://coder
I made another patch here :
http://codereview.appspot.com/4377054/
http://codereview.appspot.com/4382052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Trevor,
)-Original Message-
)From: Trevor Daniels [mailto:t.dani...@treda.co.uk]
)Sent: 12 April 2011 10:56
)To: James Lowe; Keith OHara
)Cc: lilypond-devel@gnu.org
)Subject: Re: Partcombine clarification
)
)
)James, you wrote Tuesday, April 12, 2011 10:07 AM
)
))bruys . gmail.com> writes
Mistake : this produces the right output when we have title = "\a", but
PDF metadata is wrong and only shows "a". I'll include \\ in my next
update of the patch.
http://codereview.appspot.com/4377054/
___
lilypond-devel mailing list
lilypond-devel@gnu.
On Tue, Apr 12, 2011 at 10:30:39AM +, bordage.bertr...@gmail.com wrote:
> Mistake : this produces the right output when we have title = "\a", but
> PDF metadata is wrong and only shows "a". I'll include \\ in my next
> update of the patch.
I liked David's idea of having a separate function tha
Done. I don't know if this is the correct place for ps-quote.
http://codereview.appspot.com/4377054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Besides, I noticed two special markups :
\markup "\n" and \markup "\t"
What is their use ? I know \n stands for UNIX carriage return and \t
stands for tab.
But here...
By the way, this doesn't cause any problem with metadata.
http://codereview.appspot.com/4377054/
___
On 2011/04/12 03:39:17, Keith wrote:
There is already a regtest 'accidental-clef-change.ly' that you could
just
update. Instead of
texidoc = "Accidentals are reset for clef changes.", we want
texidoc = "Accidentals are repeated after clef changes."
You could put a c-natural in the final chord
I'd recommend that the new function be placed in scm/output-ps.scm
Thanks,
Carl
http://codereview.appspot.com/4377054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
How ? output-ps is dependant of framework-ps... When I move it to
output-ps, it doesn't work.
Thanks !
Bertrand
http://codereview.appspot.com/4377054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypon
Hey all,
For the past couple weeks, when running the regtests, all of the midi files
have failed on my system:
GNU LilyPond 2.13.60
Changing working directory to: `./out-test'
Processing `voice-4.ly'
Parsing...
Interpreting music...
Preprocessing graphical objects...
Interpreting music...
MI
On 2011/04/12 13:33:05, Bertrand Bordage wrote:
How ? output-ps is dependant of framework-ps... When I move it to
output-ps, it
doesn't work.
Never mind. I don't know what I was thinking when I made that comment.
Sorry,
Carl
http://codereview.appspot.com/4377054/
___
On 2011/04/12 07:30:09, Valentin Villenave wrote:
Don't we risk losing data because of this?
Yes, but only in the PDF information fields, the printed words are
unchanged. But the correct solution is...
On 2011/04/12 07:50:45, dak wrote:
I think one should define a function ps-quote
On 2011/0
Works well for me.
We should probably slip an unmatched parenthesis into the existing
input/regression/pdfmark-metadata.ly
I tested with
\header {title = "A )little( \"night\" music\nfrom Mozart" }
On 2011/04/12 11:51:01, Bertrand Bordage wrote:
\markup "\n" and \markup "\t"
The newline and
On 2011/04/12 12:55:01, dak wrote:
On 2011/04/12 03:39:17, Keith wrote:
> \key g\major
> cis dis f!
is there a particular
reason you write f! above? f would get a natural anyway.
Only to assure us humans that F-natural was not a mistake.
The '!' was not testing for anything, because
I added a line to the test. And I don't think we need to do something
about newlines.
http://codereview.appspot.com/4377054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/04/12 18:38:11, Keith wrote:
The '!' was not testing for anything, because ...
... because it changes neither the printed signs nor the state of
localKeySignature.
http://codereview.appspot.com/4384050/
___
lilypond-devel mailing list
lilypon
bordage.bertr...@gmail.com
Ok. But you agree with the other grobs ?
I'm not sure (best be cautious this time :)
In keyboard music multiple voices have to be used
when notes with different durations occur at the
same time, but normally a cautionary accidental
would be placed above the staff
On 2011/04/12 18:38:11, Keith wrote:
On 2011/04/12 12:55:01, dak wrote:
Only to assure us humans that F-natural was not a mistake.
I think writing f! is a mistake then, because it assures Lilypond that
f-natural should be spelled out. Assurances for humans belong in
comments, not in code th
Hi guys,
It seems that the midi regtests are badly broken; I've seen a
change in partcombine-midi.ly in "make check" simply by running it
immediately after "make test-baseline". I'll investigate in more
detail in a few hours, but at the moment my first instinct is just
to revert the commit that a
30 matches
Mail list logo
