Re: Start towards fixing the tie / time signature collision problem. (issue4528061)

2011-05-12 Thread Carl . D . Sorensen
I didn't follow everything you've done, because I didn't have time to look through it all in detail. You should be aware, however, that the points for the tie are different from the extents. The left end of a tie will be at t = -delta, rather than at t=0. This is because of the width of the cur

Start towards fixing the tie / time signature collision problem. (issue4528061)

2011-05-12 Thread mtsolo
Reviewers: , Message: I recently tried to redo a score such that my ties did not intersect with time signatures. I got it to work with buggy code and a lot of kludges, so I thought I'd propose a modified version with less kludges (though still buggy code). The code is getting the bezier t point

Re: Fixes the assert problem coming from ledger-line-spanner.cc. (issue4535055)

2011-05-12 Thread m...@apollinemike.com
On May 12, 2011, at 4:08 PM, carl.d.soren...@gmail.com wrote: > LGTM. > > Carl > > > http://codereview.appspot.com/4535055/ Passes the regtests, so pushed as 69580da523384fc207043e4bad297d7560e24268. Cheers, MS ___ lilypond-devel mailing list lily

Re: Fixes the assert problem coming from ledger-line-spanner.cc. (issue4535055)

2011-05-12 Thread Carl . D . Sorensen
LGTM. Carl http://codereview.appspot.com/4535055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fixes the assert problem coming from ledger-line-spanner.cc. (issue4535055)

2011-05-12 Thread mtsolo
Reviewers: , Message: This seems like a quick, easy, and reasonable fix for Issue 1652. Lemme know if it's OK! Cheers, MS Description: Fixes the assert problem coming from ledger-line-spanner.cc. Please review this at http://codereview.appspot.com/4535055/ Affected files: M lily/ledger-lin

Re: Where to merge Translations now?

2011-05-12 Thread Carl Sorensen
On 5/12/11 12:28 PM, "Francisco Vila" wrote: > 2011/5/12 Carl Sorensen : >> >> >> >> On 5/10/11 1:30 AM, "Francisco Vila" wrote: >> >>> Well. Here is my list.  Carl, please, cherry-pick these commits from >>> lilypond/translation to stable/2.14. >> >> I have cherry-picked the commits.  I

Re: Where to merge Translations now?

2011-05-12 Thread Francisco Vila
2011/5/12 Carl Sorensen : > > > > On 5/10/11 1:30 AM, "Francisco Vila" wrote: > >> Well. Here is my list.  Carl, please, cherry-pick these commits from >> lilypond/translation to stable/2.14. > > I have cherry-picked the commits.  I'm a bit concerned that > Documentation/es/changes.tely may be wro

Re: Where to merge Translations now?

2011-05-12 Thread Francisco Vila
2011/5/12 Carl Sorensen : > > > > On 5/10/11 1:30 AM, "Francisco Vila" wrote: > >> Well. Here is my list.  Carl, please, cherry-pick these commits from >> lilypond/translation to stable/2.14. > > I have cherry-picked the commits.  I'm a bit concerned that > Documentation/es/changes.tely may be wro

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread k-ohara5a5a
http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1092 Documentation/notation/staff.itely:1092: that have the same sounding

Re: Where to merge Translations now?

2011-05-12 Thread Carl Sorensen
On 5/10/11 1:30 AM, "Francisco Vila" wrote: > Well. Here is my list. Carl, please, cherry-pick these commits from > lilypond/translation to stable/2.14. I have cherry-picked the commits. I'm a bit concerned that Documentation/es/changes.tely may be wrong as a result of some merge conflicts

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread tdanielsmusic
http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1044 Documentation/notation/staff.itely:1044: quotation begins. It is fol

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread percival . music . ca
On 2011/05/12 15:20:55, J_lowe wrote: Number 4. oops, I didn't mean that you had to upload a new draft -- if Trevor and Keith don't complain, then go ahead and push this. http://codereview.appspot.com/4518053/ ___ lilypond-devel mailing list lilypon

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Trevor Daniels
Graham Percival wrote Thursday, May 12, 2011 1:06 PM Also, isn't the (Hons) decided when you graduate, not when you appy? ;) Many UK universities have both Hons and Ord courses from the outset (or at least they used to when I was involved with them.) Students can also opt to drop from Hon

Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)

2011-05-12 Thread Trevor Daniels
Neil wrote Wednesday, May 11, 2011 7:28 PM LGTM. Thanks! I'll push after a couple of days if there are no more comments. http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode3 input/regression/clef-octavation.ly:3: \header{ \header { Done http://co

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Carl Sorensen
On 5/12/11 10:10 AM, "Trevor Daniels" wrote: > > > Colin Campbell wrote Thursday, May 12, 2011 2:19 PM > > >> On 11-05-12 05:08 AM, Phil Holmes wrote: >>> I've just received an unconditional offer to study a part-time >>> BA(Hons) in music from a local university. I'm well pleased :-) >>

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Trevor Daniels
Colin Campbell wrote Thursday, May 12, 2011 2:19 PM On 11-05-12 05:08 AM, Phil Holmes wrote: I've just received an unconditional offer to study a part-time BA(Hons) in music from a local university. I'm well pleased :-) Up the geezers! Good for you, Phil. Make us old farts proud! I'll

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Thursday, May 12, 2011 1:06 PM Subject: Re: Might understand this music stuff a bit better in the future On Thu, May 12, 2011 at 12:08:23PM +0100, Phil Holmes wrote: I've just received an unconditional offer t

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread pkx166h
Number 4. James http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely#newcode1144 Documentation/notation/staff.itely:1144: Quotes can

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread percival . music . ca
LGTM http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely#newcode1144 Documentation/notation/staff.itely:1144: Quotes can also be tag

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Colin Campbell
On 11-05-12 05:08 AM, Phil Holmes wrote: I've just received an unconditional offer to study a part-time BA(Hons) in music from a local university. I'm well pleased :-) Up the geezers! Good for you, Phil. Make us old farts proud! Colin Campbell -- The test of our progress is not whether

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread pkx166h
Nearly there I hope. Third draft. James http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely#newcode1090 Documentation/notation/sta

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Graham Percival
On Thu, May 12, 2011 at 12:08:23PM +0100, Phil Holmes wrote: > I've just received an unconditional offer to study a part-time > BA(Hons) in music from a local university. I'm well pleased :-) Congratulations! Is this one hour a day, two hours a day, or what? And does it include music (performan

Might understand this music stuff a bit better in the future

2011-05-12 Thread Phil Holmes
I've just received an unconditional offer to study a part-time BA(Hons) in music from a local university. I'm well pleased :-) -- Phil Holmes Bug Squad ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/l