Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-23 Thread m...@apollinemike.com
On Jun 13, 2011, at 1:03 PM, m...@apollinemike.com wrote: > On Jun 12, 2011, at 5:49 PM, n.putt...@gmail.com wrote: > >> On 2011/06/05 10:18:18, mike_apollinemike.com wrote: >>> On Jun 2, 2011, at 9:00 PM, mailto:n.putt...@gmail.com wrote: >> http://codereview.appspot.com/4527086/diff

Re: Fix for issue 1706. (issue4662047)

2011-06-23 Thread mtsolo
On 2011/06/23 17:48:23, hanwenn wrote: * Test missing. * Should print programming_error if dir == CENTER. * I'd use linear_combination on dir instead, so it is symmetric in up/down. Done, done, and done. Cheers, MS http://codereview.appspot.com/4662047/ _

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-23 Thread Carl . D . Sorensen
LGTM http://codereview.appspot.com/4627062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch meister

2011-06-23 Thread Colin Campbell
On 11-06-23 05:38 AM, Graham Percival wrote: Do either of you have 2-3 hours a week to spend shuffling patches? More directed at Colin than James, but I figured I'd include James in case he was getting sick of doc work and wanted a challenge. I'd like somebody else to be Patch Meister. The most

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-23 Thread pkx166h
Reviewers: Keith, Message: Second go. Thanks Keith. Description: Replace Tab with 8 Spaces for .py files As per GOP Prop 1 - Python formatting. All files in /python/ and /scripts/ were checked. Please review this at http://codereview.appspot.com/4627062/ Affected files: M python/convertrul

Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-23 Thread k-ohara5a5a
The bad news is, you replaced tabs by 4 columns when we needed 8 column. The good news is, so far as I can see, there were no un-wanted changes (no cases were we needed a literal tab). http://codereview.appspot.com/4627062/ ___ lilypond-devel mailing l

RE: question about mod dates in my git tree for resetted files

2011-06-23 Thread James Lowe
Keith, From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Keith OHara [k-ohara5...@oco.net] Sent: 24 June 2011 03:31 To: lilypond-devel@gnu.org Subject: Re: question about mod

RE: GOP-PROP 1: python formatting (accepted)

2011-06-23 Thread James Lowe
Hello (again) __ From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Graham Percival [gra...@percival-music.ca] Sent: 23 June 2011 23:48 To: lilypond-devel@gnu.org Subject: GOP-PROP

Re: question about mod dates in my git tree for resetted files

2011-06-23 Thread Keith OHara
James Lowe datacore.com> writes: > > I made the patch and then aborted my changes. > I noticed however that the mod dates were still the same as the time > I made the patch, even though the files themselves are the original files That is normal. The file system reports the last time the file

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread k-ohara5a5a
On 2011/06/24 00:56:43, Bertrand Bordage wrote: You have to remove mf/out/feta* before compiling. That made everything work. Looks good to me. I was failing to find a glyph for rests.-1o , saw you were creating a new rests.M1o and thought "Oh, 'M' must mean mensural" but I see it really does

question about mod dates in my git tree for resetted files

2011-06-23 Thread James Lowe
Hello, Perhaps this is expected, but I wondered if someone could verify it. Usually when I make some patches and post on Rietveld, I make a .patch file, save it somewhere safe and then 'reset' my tree (abort in Lilygit.tcl). This means I can work on other stuff without having to do complicated

RE: GOP-PROP 1: python formatting (accepted)

2011-06-23 Thread James Lowe
Hello, From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Graham Percival [gra...@percival-music.ca] Sent: 23 June 2011 23:48 To: lilypond-devel@gnu.org Subject: GOP-PROP 1: py

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread bordage . bertrand
Maybe I should have been more clear in the description. The glyph I added in feta-rests.mf is for the default style. You have to remove mf/out/feta* before compiling. There's no problem when I try this patch with your example. But again, maybe I don't understand what you mean. Thanks http://code

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread k-ohara5a5a
On 2011/06/23 09:34:23, Bertrand Bordage wrote: For the moment, the exception is handled by the next "if", line 100. But don't forget to let /something/ print if the ledgered version is missing in the chosen style -- especially default : \relative c''' { \time 4/1 << { b\breve\rest g\bre

GOP-PROP 1: python formatting (accepted)

2011-06-23 Thread Graham Percival
We have now accepted the final version of GOP-PROP 1. The unofficial page will remain online for the duration of GOP: http://lilypond.org/~graham/gop/gop_1.html but the offical version is now in the CG and was pushed as bde5d50a10ab68e864c161fb98478c3803b6d409 Are there any volunteers to do t

Re: Fix for issue 1706. (issue4662047)

2011-06-23 Thread Han-Wen Nienhuys
* Test missing. * Should print programming_error if dir == CENTER. * I'd use linear_combination on dir instead, so it is symmetric in up/down. On Thu, Jun 23, 2011 at 11:00 AM, wrote: > Reviewers: , > > Message: > I think this'll do it. > > Cheers, > MS > > Description: > Fix for issue 1706. > >

Re: Fix for issue 1706. (issue4662047)

2011-06-23 Thread Carl . D . Sorensen
LGTM http://codereview.appspot.com/4662047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix for issue 1706. (issue4662047)

2011-06-23 Thread mtsolo
Reviewers: , Message: I think this'll do it. Cheers, MS Description: Fix for issue 1706. Please review this at http://codereview.appspot.com/4662047/ Affected files: M lily/beam.cc Index: lily/beam.cc diff --git a/lily/beam.cc b/lily/beam.cc index 8a30752c386eccd8294b181c5dd18159c2b492d

RE: Patch meister

2011-06-23 Thread James Lowe
Hello )-Original Message- )From: Graham Percival [mailto:gra...@percival-music.ca] )Sent: 23 June 2011 12:38 )To: Colin Campbell; James Lowe )Cc: lilypond-devel@gnu.org )Subject: Patch meister ) )Do either of you have 2-3 hours a week to spend shuffling patches? )More directed at Colin tha

Re: PATCHES: 48-hour countdown for new breve and bound-info

2011-06-23 Thread m...@apollinemike.com
On Jun 23, 2011, at 1:40 PM, Graham Percival wrote: > Sat, 13:00 > > (not quit certain what this patch is doing now) > 1: Attaches bound info to beam for better normalized-endpoint > calculations > 2: Removes changing of beam extent and keeps bound-info > http://codereview.appspot.com/4605047 >

Re: Dynamic + text aligned: BEST solution?

2011-06-23 Thread Graham Percival
On Sun, Jun 19, 2011 at 11:30:25PM +0200, Xavier Scheuer wrote: > The following snippets are providing different solutions (some with > important drawbacks) to this issue/request (useful in many cases!): > http://lsr.dsi.unimi.it/LSR/Item?id=393 > http://lsr.dsi.unimi.it/LSR/Item?id=739 > > but th

PATCHES: 48-hour countdown for new breve and bound-info

2011-06-23 Thread Graham Percival
Sat, 13:00 New breve rest with ledger lines http://codereview.appspot.com/4650052/ (not quit certain what this patch is doing now) 1: Attaches bound info to beam for better normalized-endpoint calculations 2: Removes changing of beam extent and keeps bound-info http://codereview.appspot.com/46

Patch meister

2011-06-23 Thread Graham Percival
Do either of you have 2-3 hours a week to spend shuffling patches? More directed at Colin than James, but I figured I'd include James in case he was getting sick of doc work and wanted a challenge. I'd like somebody else to be Patch Meister. The most important job is as described under "You can h

Re: Patch: small reduction in output from make doc

2011-06-23 Thread Jan Nieuwenhuizen
Carl Sorensen writes: >>> it should redirect non-error output to the file, and errors should appear >>> in the terminal. Stdout is used for valuable program output, stderr for any kind of message, including progress. The name stdERR is possibly somewhat unfortunate and comes from the days that u

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread percival . music . ca
thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1705 http://codereview.appspot.com/4650052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes himidtom to highmidtom. (issue4633064)

2011-06-23 Thread percival . music . ca
On 2011/06/23 09:49:05, t.daniels_treda.co.uk wrote: mailto:m...@apollinemike.com wrote Thursday, June 23, 2011 9:56 AM The names in LilyPond should conform to those defined in General MIDI Level 1 - see http://www.midi.org/techspecs/gm1sound.php These are unfortunately inconsistent as you obs

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread bordage . bertrand
Updated with the good bounds. The problem with mensural/neomensural/Petrucci styles is that they often have different ledger line thicknesses. The best solution is to get these ledger lines out of metafont. But this requires much more work. For the moment, the exception is handled by the next "i

Re: Changes himidtom to highmidtom. (issue4633064)

2011-06-23 Thread Trevor Daniels
m...@apollinemike.com wrote Thursday, June 23, 2011 9:56 AM On Jun 23, 2011, at 10:53 AM, k-ohara5...@oco.net wrote: On 2011/06/23 06:46:49, MikeSol wrote: Pretty self explanatory - it seems to be in keeping w/ the other tom names. That it is. Could you be persuaded to make a converting r

Re: Changes himidtom to highmidtom. (issue4633064)

2011-06-23 Thread m...@apollinemike.com
On Jun 23, 2011, at 10:53 AM, k-ohara5...@oco.net wrote: > On 2011/06/23 06:46:49, MikeSol wrote: >> Pretty self explanatory - it seems to be in keeping w/ the other tom > names. > > That it is. > Could you be persuaded to make a converting rule in > python/convertrules.py ? > I could. But befo

Re: enharmonic problem with \transpose - should we modify it?

2011-06-23 Thread Benkő Pál
>> well, it was nastier than I thought because of the current pitch >> representation, >> so I haven't done it as a patch but a standalone hack; there's also a >> non-standard (E31) example. >> >> [...] >> > 2011/6/21 Felipe Gonçalves Assis : >> Enharmonicity is just an equivalence relation respec

Re: Changes himidtom to highmidtom. (issue4633064)

2011-06-23 Thread k-ohara5a5a
On 2011/06/23 06:46:49, MikeSol wrote: Pretty self explanatory - it seems to be in keeping w/ the other tom names. That it is. Could you be persuaded to make a converting rule in python/convertrules.py ? http://codereview.appspot.com/4633064/ ___ li