This was just pushed by Mike.
I close the issue.
thanks,
Janek
http://codereview.appspot.com/4625067/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
lemniskata.bernoull...@gmail.com wrote:
Graham,
I'm worried that i don't hear anything from you since 2
weeks! Do you experience any problems with fixing code
style issues pointed to by Neil?
Is that me? I'm supposed to do something? Here's a patch
Graham
From
Reviewers: Neil Puttock, J_lowe,
Message:
On 2011/07/10 23:03:21, J_lowe wrote:
This passes a make but fails a reg test check
New patch uploaded that uses Neil's suggestions about
extract-named-music. That function also correctly works with repeated
chords, so the crash also goes away with
LGTM
http://codereview.appspot.com/4675048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
http://codereview.appspot.com/4636082/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New patch set uploaded - the suggested clef is a bit higher now. Images
can be found in tracker issue:
http://code.google.com/p/lilypond/issues/detail?id=1752
http://codereview.appspot.com/4664070/
___
lilypond-devel mailing list
Please review:
http://codereview.appspot.com/4693043
Cheers,
Reinhold
--
--
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
* Financial Actuarial Math., Vienna Univ. of Technology, Austria
*
2011/7/11 Graham Breed gbr...@gmail.com:
Is that me? I'm supposed to do something? Here's a patch
Perfect!
Mike: please push this.
Colin: sorry for overlooking that the countdown was over. We
definately need an integrated patch/issue tracker!
cheers,
Janek
From
I'd like to pull in all local branches in one command, is this possible?
I've searched CG but it doesn't seem to mention it, also official git
manual on pull (http://www.kernel.org/pub/software/scm/git/docs/git-pull.html)
says git-pull - Fetch from and merge with another repository or a
local
2011/7/11 Janek Warchoł lemniskata.bernoull...@gmail.com:
2011/7/11 Graham Breed gbr...@gmail.com:
Is that me? I'm supposed to do something? Here's a patch
Perfect!
Mike: please push this.
Please don't push without adding a commit message.
Thanks,
Neil
http://codereview.appspot.com/4685049/diff/5001/scm/music-functions.scm
File scm/music-functions.scm (right):
http://codereview.appspot.com/4685049/diff/5001/scm/music-functions.scm#newcode249
scm/music-functions.scm:249: (define (note-count music-elements)
remove
http://codereview.appspot.com/4654090/diff/16002/lily/context.cc
File lily/context.cc (right):
http://codereview.appspot.com/4654090/diff/16002/lily/context.cc#newcode496
lily/context.cc:496: bool type_check_ok;
?
assert (type_check_ok);
http://codereview.appspot.com/4654090/
2011/7/11 Janek Warchoł lemniskata.bernoull...@gmail.com:
Sorry, i didn't notice.
Attached is a nicely described patch.
Thanks, pushed to master.
Cheers,
Neil
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Passes Make and Reg tests. James
http://codereview.appspot.com/4685049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Pass Make and reg tests - James
http://codereview.appspot.com/4686047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
15 matches
Mail list logo
