Re: Fix #1507: Inconsistent \festival output in regression testing. (issue4693046)

2011-07-15 Thread k-ohara5a5a
Works good for me. http://codereview.appspot.com/4693046/diff/1/scm/song.scm File scm/song.scm (right): http://codereview.appspot.com/4693046/diff/1/scm/song.scm#newcode222 scm/song.scm:222: #:unfinished (and (not (*syllabify*)) (find-child-named music 'HyphenEvent)) On 2011/07/16 04:59:50, Kei

Re: Fix #1507: Inconsistent \festival output in regression testing. (issue4693046)

2011-07-15 Thread k-ohara5a5a
http://codereview.appspot.com/4693046/diff/1/scm/song.scm File scm/song.scm (right): http://codereview.appspot.com/4693046/diff/1/scm/song.scm#newcode222 scm/song.scm:222: #:unfinished (and (not (*syllabify*)) (find-child-named music 'HyphenEvent)) The regtest that caused the initial trouble

Re: Fix 1563: System start bars interpreted collapse-height as absolute length. (issue4693043)

2011-07-15 Thread k-ohara5a5a
Looks good to me. The differences in beam-skip.ly were not due to this patch. On 2011/07/12 23:40:54, J_lowe wrote: Pass Make but I get a difference in one reg test http://codereview.appspot.com/4693043/ ___ lilypond-devel mailing list lilypond-de

Re: Fixes error for tuplet bracket direction calculation when tuplets contain rests. (issue4668045)

2011-07-15 Thread k-ohara5a5a
Looks good and works good for me. On 2011/06/29 16:32:33, mike_apollinemike.com wrote: The only issue with this may be one of sight reading. If I am reading at quaver=200 and I see \relative c''' { \times 2/3 { c4 b,, b } } , I'm likely going to want to see the tuplet above the staff so th

PATCH: Bonus 72-hour countdown

2011-07-15 Thread Colin Campbell
21:00 MST Monday July 18 As I'm taking the World's Finest Grand-nipper to see the Badlands Passion Play in Drumheller this weekend, here is an extended list with extended time: Issue 1563 : strange vertical line at staff begin using St

Re: Checks for grobs with circular parentage in the regtests. (issue4747045)

2011-07-15 Thread hanwenn
http://codereview.appspot.com/4747045/diff/2001/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/4747045/diff/2001/lily/grob.cc#newcode528 lily/grob.cc:528: Grob::in_own_family_tree (Grob *g, Grob *orig) I think this should take an axis argument, and check only one axis. ht

Re: change in treble clef - do you accept?

2011-07-15 Thread Han-Wen Nienhuys
2011/7/15 Janek Warchoł : > Surprisingly, CueClef currently uses regular clef glyph scaled down > 1.5874 times (font-size -4), not a scaled down change clef.  Maybe we Almost; IIRC the -4 will end up in another font, so it will be the normal clef from feta13 (?). -- Han-Wen Nienhuys - han...@xs4

Re: Fix 1390: slashedGrace function (graces with slashed stems but no slur, e.g. when grace is tied) (issue4670056)

2011-07-15 Thread k-ohara5a5a
Looks good and works well for me. http://codereview.appspot.com/4670056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Grobs that are their own ancestors.

2011-07-15 Thread Neil Puttock
On 15 July 2011 23:00, Neil Puttock wrote: > Axis_group_interface::add_element () sets the DynamicLineSpanner as > X-parent (depends on 'axes setting). This should read `as Y-parent'. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://list

Re: Grobs that are their own ancestors.

2011-07-15 Thread Neil Puttock
On 15 July 2011 18:28, wrote: > I've now gone on a quest for parental loops in the source, and I've found > some: > > chord-repetition.ly > chord-tremolo-articulations.ly > dynamics-alignment-breaker.ly > dynamics-alignment-no-line.ly > dynamics-glyphs.ly > dynamics-line.ly > dynamics-rest-posit

Checks for grobs with circular parentage in the regtests. (issue4747045)

2011-07-15 Thread mtsolo
Reviewers: , Message: This gets rid of all circular parentage in LilyPond (at least all that's in the regtests...). Description: Checks for grobs with circular parentage in the regtests. Eliminates all circular parenting cases from the code base, allowing for null pointers to be parents but iss

Grobs that are their own ancestors.

2011-07-15 Thread mike
I've now gone on a quest for parental loops in the source, and I've found some: chord-repetition.ly chord-tremolo-articulations.ly dynamics-alignment-breaker.ly dynamics-alignment-no-line.ly dynamics-glyphs.ly dynamics-line.ly dynamics-rest-positioning.ly dynamics-text-right-padding.ly dynamics-te

Re: 2.15.5 regtests

2011-07-15 Thread Phil Holmes
- Original Message - From: "Reinhold Kainhofer" To: "Phil Holmes" ; Sent: Friday, July 15, 2011 5:36 PM Subject: Re: 2.15.5 regtests On Fr., 15. Jul. 2011 15:35:37 CEST, Phil Holmes wrote: Looks pretty clean. Continuing midi warnings from http://code.google.com/p/lilypond/issue

Re: 2.15.5 regtests

2011-07-15 Thread Reinhold Kainhofer
On Fr., 15. Jul. 2011 15:35:37 CEST, Phil Holmes wrote: > Looks pretty clean.  Continuing midi warnings from > http://code.google.com/p/lilypond/issues/detail?id=1678 > > An interesting change from mozart-hrn-3.log > > "+/main/src/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.git

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-15 Thread mtsolo
On 2011/07/14 20:23:03, Neil Puttock wrote: On 14 July 2011 21:01, mailto:m...@apollinemike.com wrote: > I'll run the regtests tonight or tomorrow and report back. I've just tried this and I think you've got an infinite loop somewhere (I had to kill the proces

Re: Does type checking for all context property sets. (issue4654090)

2011-07-15 Thread mtsolo
On 2011/07/14 14:56:00, Carl wrote: LGTM. With Neil's approval I think we can go ahead and push. Thanks. Pushed as a811a3c91c05f33474c1d447bedaa1e089522532. Cheers, MS http://codereview.appspot.com/4654090/ ___ lilypond-devel mailing list lilypo

Re: GOP-PROP 5: build system output (update)

2011-07-15 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Friday, July 15, 2011 4:43 PM Subject: Re: GOP-PROP 5: build system output (update) On Fri, Jul 15, 2011 at 02:20:51PM +0100, Phil Holmes wrote: - Original Message - From: "Graham Percival" > * All o

Re: GOP-PROP 5: build system output (update)

2011-07-15 Thread Graham Percival
On Fri, Jul 15, 2011 at 02:20:51PM +0100, Phil Holmes wrote: > - Original Message - From: "Graham Percival" > > * All output will be saved to various log files. (including > > output from make(1)) > > * We will still display the output of make(1) on the console. > > I read these as

Re: 2.15.5 regtests

2011-07-15 Thread Phil Holmes
"Phil Holmes" wrote in message news:ivpfnb$n5p$1...@dough.gmane.org... Looks pretty clean. Continuing midi warnings from http://code.google.com/p/lilypond/issues/detail?id=1678 An interesting change from mozart-hrn-3.log "+/main/src/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.

Re: Adds redirect-lilypond-output option tolilypond-book(issue4664060)

2011-07-15 Thread Graham Percival
On Fri, Jul 15, 2011 at 02:04:56PM +0100, Phil Holmes wrote: > - Original Message - From: "Graham Percival" > > > > >Perhaps, in yet another stunning example of mis-management, this > > As it stands, this patch does nothing unless you turn on the > redirect-lilypond-output for lilypond bo

2.15.5 regtests

2011-07-15 Thread Phil Holmes
Looks pretty clean. Continuing midi warnings from http://code.google.com/p/lilypond/issues/detail?id=1678 An interesting change from mozart-hrn-3.log "+/main/src/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/input/regression/mozart-hrn3-allegro.ily:129:17: wa

Re: GOP-PROP 5: build system output (update)

2011-07-15 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: Sent: Thursday, July 14, 2011 5:09 PM Subject: GOP-PROP 5: build system output (update) Update on this; I'm not ready to call it a "probable decision" yet. http://lilypond.org/~graham/gop/gop_5.html (proposal written by Phil Holmes, m

Re: Adds redirect-lilypond-output option tolilypond-book(issue4664060)

2011-07-15 Thread Phil Holmes
- Original Message - From: "Graham Percival" Perhaps, in yet another stunning example of mis-management, this entire patch should be withdrawn pending the GOP stdout/stderr discussion. The introduction of that discussion is pending us finally finishing the C++ question, which itself is

Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060)

2011-07-15 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; "David Kastrup" Sent: Wednesday, July 13, 2011 5:57 PM Subject: Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060) On Wed, Jul 13, 2011 at 03:26:18PM +0100, Phil Holmes wrote: - Original

Re: Adapt fixcc.py to use Astyle and/or emacs (issue4662074)

2011-07-15 Thread Trevor Daniels
Keith OHara wrote Friday, July 15, 2011 4:50 AM On Thu, 14 Jul 2011 00:47:58 -0700, Trevor Daniels wrote: I was hoping to recommend going with this, so we could wrap up this issue, but then I found - new_context->event_source ()-> - add_listener (GET_LISTENER (new_context->create_conte

Re: GOP-PROP 5: build system output (update)

2011-07-15 Thread Jan Warchoł
2011/7/14 Graham Percival : > ** Proposal summary > > When you run make or make doc, > >    * All output will be saved to various log files. (including >      output from make(1)) >    * We will still display the output of make(1) on the console. >    * No other output will be displayed on the cons