http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1555
Documentation/notation/rhythms.itely:1555: shown durations ar
2011/8/8 Graham Percival :
> On Mon, Aug 08, 2011 at 03:52:52AM +, k-ohara5...@oco.net wrote:
>> >If any of the above is incorrect,
>> >then maybe consider adding some
>> >comment(s) where you define the variables,
>>
>> Now, Mike created none of these variables, nor does his added code use
>>
Hi,
2011/8/8 Aleksandr Andreev :
> Hi everybody,
>
> Back to the topic of adding support for East Slavic (aka Kievan) music
> notation.
Great to see you working on this!
> I've rewritten our font for Kievan notation (called Suprasl) in
> Metafont. Now, I am trying to figure out how to incorpora
Question: on line 722 of axis-group-interface.cc, I see:
while (i + 1 < elements.size ()
&& scm_eq_p (elements[i + 1]->get_property
("outside-staff-priority"), priority))
Shouldn't this be:
while (i + 1 < elements.size ()
&& to_boolean (scm_eq_p (elements[i
2011/8/7 Phil Holmes :
> I've prepared some changes for the web search box in line with what I
> suggested in http://code.google.com/p/lilypond/issues/detail?id=1806 -
> screenshot attached. It requires changes to search-box.ihtml and
> lilypond-website.css (to make room for the new box).
>
> Prob
Hello, gentle maintainer.
This is a message from the Translation Project robot.
A revised PO file for textual domain 'lilypond' has been submitted
by the Italian team of translators. The file is available at:
http://translationproject.org/latest/lilypond/it.po
(We can arrange things so tha
Hello,
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Graham Percival
)Sent: 08 August 2011 01:52
)To: lilypond-devel@gnu.org
)Subject: Re: test macosx 10.7 binaries
)
)On Wed,
Hello,
)-Original Message-
)From: Trevor Daniels [mailto:t.dani...@treda.co.uk]
)Sent: 07 August 2011 23:04
)To: James Lowe; Neil Puttock
)Cc: Lily-Devel List
)Subject: Re: NR 5.5.4 - Modifying ties and slurs
)
)
)James Lowe wrote Sunday, August 07, 2011 10:24 PM
)
)>> If I navigate to Tie
In an attempt to figure out whether my coredumps were related to lying
to the compiler about const, I tried checking the effects of not using
casts to non-const in const member functions. Nothing came off it.
However, there was one not-just-declarational change that seemed like a
sensible thing t
Hi Jan,
Thanks for your comments.
> In case of noteheads, i suppose that everything would be best defined in
> staff_space. For stems (as i understand there are special characters for
> stems) stafflinethickness will be more appropriate.
Right now, I've got the notehead and stem being drawn a
On Sun, Aug 7, 2011 at 4:02 PM, Graham Percival
wrote:
> On Sun, Aug 07, 2011 at 11:46:51AM +0200, m...@apollinemike.com wrote:
>> I'm certainly not against adding comments, but I think that when
>> the code does a good job of explaining stuff via variable names,
>> comments can clutter what's goi
Changes done.
Passes make, regtest comparison and make doc.
Bertrand
http://codereview.appspot.com/4808074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
- Original Message -
From: "Graham Percival"
To: "Phil Holmes"
Cc: "Jean-Charles Malahieude" ; "David Kastrup"
;
Sent: Sunday, August 07, 2011 11:37 PM
Subject: Re: Ugliness in the Learning Manual
On Sun, Aug 07, 2011 at 11:22:48AM +0100, Phil Holmes wrote:
- Original Message
- Original Message -
From:
To: ; ;
;
Cc: ;
Sent: Sunday, August 07, 2011 11:42 PM
Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
LGTM. My comment is a tiny nitpick; I don't think it needs to hold up
pushing this.
http://codereview.appspot.com/4811066/diff/8003/input
- Original Message -
From: "Trevor Daniels"
To: "Graham Percival"
Cc: "Phil Holmes" ; "Lily-Devel List"
Sent: Monday, August 08, 2011 12:11 AM
Subject: Re: Search box changes
Grahamm you wrote Sunday, August 07, 2011 11:47 PM
On Sun, Aug 07, 2011 at 06:35:34PM +0100, Trevor Dan
- Original Message -
From: "Jan Warchoł"
[snip]
Thanks for this excellent guide, Jan. Looks like I won't need to use it
since I just sent a patch for my regtest to GP, but I may need it in
future...
--
Phil Holmes
___
lilypond-devel m
I'll push it.
james
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Phil Holmes
)Sent: 08 August 2011 15:54
)To: philehol...@googlemail.com; percival.music...@gmail.com;
)n.put
Can we have a regtest, please?
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
commit 403e66a45e752231fb49deea2e8ccb1976505c7c
Thanks Mr Holmes!
James
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of James Lowe
)Sent: 08 August 2011 16:13
)To: Phil Holmes
Woh. There's an error - \url isn't part of Lilypond syntax! I'd corrected
this to GP, but here's a corrected patch.
--
Phil Holmes
- Original Message -
From: "James Lowe"
To: "Phil Holmes" ; ;
; ; ;
;
Sent: Monday, August 08, 2011 4:13 PM
Subject: RE: Rewrite regtest mozart-h
In website_post.py, we have the following:
if (line.find('2.12') >= 0):
line = line.replace('a href=', 'a
onClick=\"javascript:urchinTracker(\'/download/v2.12\');\" href=')
elif (line.find('2.13') >= 0):
line = line.replace('a href=', 'a
onCl
Am Montag, 8. August 2011, 02:59:31 schrieb Graham Percival:
> - will will ***NOT*** display any errors from g++. (second point)
> - exception: we ***MIGHT*** display some portion(s) of the
> relevant log file(s). The policy uses the word "might" here,
> not "must". There is a huge dif
Am Sonntag, 7. August 2011, 11:11:13 schrieb Phil Holmes:
> There's no intention of stopping make showing errors. There is an issue
> with warnings - make doc produces so many that the output is pretty much
> unreadable, and they've been ignored for a long time - so having warnings
> turned off by
no problem. I'll do it now.
James
)-Original Message-
)From: Phil Holmes [mailto:m...@philholmes.net]
)Sent: 08 August 2011 16:46
)To: James Lowe; philehol...@googlemail.com;
)percival.music...@gmail.com; n.putt...@gmail.com; lilypond-
)de...@gnu.org; re...@codereview.appspotmail.com
)Sub
Phil,
From: Phil Holmes [m...@philholmes.net]
Sent: 08 August 2011 16:45
To: James Lowe; philehol...@googlemail.com; percival.music...@gmail.com;
n.putt...@gmail.com; lilypond-devel@gnu.org; re...@codereview.appspotmail.com
Subject: Re: Rewrite regtest moza
On Mon, Aug 08, 2011 at 04:45:49PM +0100, Phil Holmes wrote:
>
> Woh. There's an error - \url isn't part of Lilypond syntax! I'd
> corrected this to GP, but here's a corrected patch.
apparently the command is called
\with-url
instead.
Cheers,
- Graham
___
- Original Message -
From: "James Lowe"
To: "Phil Holmes" ; ;
; ;
;
Sent: Monday, August 08, 2011 4:58 PM
Subject: RE: Rewrite regtest mozart-hrn-3.ly (issue4811066)
Phil,
From: Phil Holmes [m...@philholmes.net]
Sent: 08 August 2011 16:45
To:
Second time's the charm
;)
commit 6f818c30809d32c10b33d13e51f0910788ac0493
James
)-Original Message-
)From: Phil Holmes [mailto:philehol...@googlemail.com] On Behalf Of
)Phil Holmes
)Sent: 08 August 2011 17:03
)To: James Lowe; philehol...@googlemail.com;
)percival.music...@gmail.com; n
On Mon, Aug 08, 2011 at 05:48:47PM +0200, Reinhold Kainhofer wrote:
> Am Montag, 8. August 2011, 02:59:31 schrieb Graham Percival:
> > ... if we are still this unclear about precisely what the policy
> > states,
>
> No, the policy is clear in that regard. It's just that this is a decision I
> sim
On 8/8/11 6:07 AM, "Aleksandr Andreev" wrote:
> Hi Jan,
>
> Thanks for your comments.
>
>> In case of noteheads, i suppose that everything would be best defined in
>> staff_space. For stems (as i understand there are special characters for
>> stems) stafflinethickness will be more appropriate.
Phil, you wrote Monday, August 08, 2011 4:07 PM
I do use Windows mail's newsgroups interface to post to devel, and
it's possible I'm unique in that, and that Trevor is unique in
that he also uses Windows mail, but without subscribing. I'll see
how I can avoid the problem in future.
Thanks
- Original Message -
From: "Trevor Daniels"
To: "Phil Holmes" ; "Graham Percival"
Cc: "Lily-Devel List"
Sent: Monday, August 08, 2011 6:10 PM
Subject: Re: Search box changes
Phil, you wrote Monday, August 08, 2011 4:07 PM
I do use Windows mail's newsgroups interface to post to de
On 2011/08/08 15:19:06, Carl wrote:
Can we have a regtest, please?
Regtest added.
Cheers,
MS
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
This fixes Issue 509 and passes regtests.
Cheers,
MS
Description:
Prevents nested tuplets from colliding.
Please review this at http://codereview.appspot.com/4808082/
Affected files:
M input/regression/tuplet-nest.ly
M lily/tuplet-bracket.cc
M scm/define-grob-prope
Phil, you wrote Monday, August 08, 2011 6:30 PM
From: "Trevor Daniels"
For my part I'm happy to investigate subscribing to the
lily-dev newsgroup to see if that fixes the problem.
But the only newsgroups Windows Mail presents to me
are MS ones. How do I get at the lily ones?
Slightly di
On 11-08-07 01:03 AM, Graham Percival wrote:
Sorry for the delay; Colin's away this week, and he asked me to
keep it rolling, but now that I'm in Canada I suddenly (and
unexpectedly!) have a social life, so I'm not keeping stuff
together all that well.
Colin's back today, and can't decide how t
Hi all,
>> 2) list all environment variables used (both internally and
>> externally) in the build system in the CG.
>>
>> Advantage: at least this knowledge is written down somewhere.
>> Disadvantage: the list will not be kept up-to-date. (don't argue;
>> there's absolutely nothing you can say t
LGTM.
Thanks,
Carl
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Passes make and reg tests
http://codereview.appspot.com/4822046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 08/08/11 21:36, Maximilian Albert wrote:
> I don't know anything about the build system, but isn't it possible to
> do this automatically? Say, if you rename all lilypond-related
> environment variables so that they start with LILY_ then why can't you
> say something like 'env | grep LILY_' and
Passes make and reg tests
http://codereview.appspot.com/4808074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
For some reason Hans won't email the group ;)
From: Hans Aberg [haber...@telia.com]
Sent: 08 August 2011 21:54
To: James Lowe
Cc: Floris van Manen
Subject: Re: New Binary for LilyPond on MacOSX 10.7 available
On 8 Aug 2011, at 20:39, James Lowe wrote:
> )>
Passes make and reg test diff looks ok
see
http://code.google.com/p/lilypond/issues/detail?id=509#c4
for attached png
http://codereview.appspot.com/4808082/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinf
On Mon, Aug 08, 2011 at 09:36:34PM +0100, Maximilian Albert wrote:
> P.S.: Since Graham mentioned getting rid of environment variables:
> only very recently have I started to appreciate the enormous value
> they have once you work on systems where things are just slightly
> different than what ever
On Mon, Aug 08, 2011 at 04:48:46PM +0100, Phil Holmes wrote:
> In website_post.py, we have the following:
>
>if (line.find('2.12') >= 0):
>line = line.replace('a href=', 'a
> onClick=\"javascript:urchinTracker(\'/download/v2.12\');\" href=')
>elif (line.find
Since you pushed it, James, could you correct the \typewriter to
\with-url ? Before you push, compile it on the command-line to
make sure you have the right syntax and you have a clickable link.
Cheers,
- Graham
On Mon, Aug 08, 2011 at 04:08:16PM +, James Lowe wrote:
> Second time's the char
Draft 5 - removed all translation docs with this snippet in it too (for
when it is removed from LSR).
have at it.
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/dif
Graham Percival wrote Monday, August 08, 2011 6:06 AM
** Proposal summary
Let’s get rid of priorities. We will simply describe bugs in
neutral terms; each contributor can search and interpret the
results as he or she sees fit.
This is a better approach than haggling over priority.
We will
LGTM
Although I'm not sure about editing the other language files. Best wait
for Francisco to comment.
http://codereview.appspot.com/4837050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 8 Aug 2011, at 23:11, James Lowe wrote:
> For some reason Hans won't email the group ;)
So then don't forward my mail to the lists! - The reason is that I can't verify
it, so I do not want unreliable information spread around. Wait until you find
someone who can do it.
Hans
_
On Mon, Aug 08, 2011 at 10:50:02PM +0100, Trevor Daniels wrote:
>
> Graham Percival wrote Monday, August 08, 2011 6:06 AM
>
> > * anything which stops contributors from helping out (e.g.
> > lily-git.tcl not working, source tree(s) not being
> > available). To limit this scope of this p
On 08/08/11 16:04, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
>
> To: "Phil Holmes"
> Cc:
> Sent: Sunday, August 07, 2011 11:45 PM
> Subject: Re: Search box changes
>
>
>> On Sun, Aug 07, 2011 at 05:33:45PM +0100, Phil Holmes wrote:
>>> I've prepared some changes
2011/8/7 Bertrand Bordage :
>> I've done a very dirty test which showed that a properly set glyph
>> bounding box solves this perfectly (see in the attachment how the
>> bounding box should change).
>> However, there is a problem. Currently bounding box is set by
>> procedure draw_outside_ellipse
I'd make the tie slightly shorter. I find it awkward that two adjacent
ties collide so easily, for example here
{
\time 3/4
\relative c' { c2 e4 g2 e4 }
\addlyrics { gran- de_a- mi- go }
\addlyrics { pu- "ro y ho-" nes- to }
\addlyrics { pu- ro~y~ho- nes- to }
}
(example from documentat
2011/8/8 Trevor Daniels :
>
> Graham Percival wrote Monday, August 08, 2011 6:06 AM
>> Type-critical:
>> * anything which stops contributors from helping out (e.g.
>> lily-git.tcl not working, source tree(s) not being
>> available). To limit this scope of this point, we will
>> assume
LGTM
note that image of the issue will also require a minimum distance
setting, otherwise, the glissando will be shortened into a dot?
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/
On 2011/08/09 05:08:56, hanwenn wrote:
LGTM
note that image of the issue will also require a minimum distance
setting,
otherwise, the glissando will be shortened into a dot?
Done. New patchset uploaded.
Cheers,
MS
http://codereview.appspot.com/4801083/
_
On 2011/08/02 21:45:52, Neil Puttock wrote:
http://codereview.appspot.com/4832046/diff/2001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):
http://codereview.appspot.com/4832046/diff/2001/lily/page-layout-problem.cc#newcode282
lily/page-layout-problem.cc:282: warning ("
Reviewers: ,
Message:
Pushed as 7cd9444ea5dfc80782befa6b64bae015bddbd967.
Cheers,
MS
Description:
Correctly parses nan from scheme in output-distance
Please review this at http://codereview.appspot.com/4835049/
Affected files:
M scripts/build/output-distance.py
Index: scripts/build/output
59 matches
Mail list logo
