Re: pulling and rebasing. Problem with resolving conflict

2011-08-22 Thread Janek Warchoł
2011/8/22 Reinhold Kainhofer reinh...@kainhofer.com: Am Sunday, 21. August 2011, 23:43:21 schrieb Janek Warchoł: janek@janek-lilydev5:~/lilypond-git$ git status ##now this looks strange - shouldn't it say something like modified: this, this and this? Nope, after you manually resolved all

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread mtsolo
On 2011/08/22 01:56:23, hanwenn wrote: quick remarks - Why are the flags called maybeflags in the engraver? Because we don't know if they are for-real flags until auto beaming has finished doing its thing (and all of the flags with beams are killed). I can change it to flags_ or

Re: Fixes issue 40. (issue 4801083)

2011-08-22 Thread mtsolo
Pushed as b3c0b773bde05b3971f087ed6c5f4fb40a1b20b1. http://codereview.appspot.com/4801083/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

dotcol_ variable in rhythmic-column-engraver.cc

2011-08-22 Thread Mike Solomon
This variable is unused - is it OK to get rid of it, or is someone planning on building around it (I'm pretty sure it has been just hanging out not doing anything for at least a year). Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-22 Thread percival . music . ca
Yes, definitely do the pushing stuff in a separate patch. But here's an outline: 1. update with git pull -r 2. check you only have 1 patch ready with git status 3. upload your changes with git push http://codereview.appspot.com/4898058/ ___

Re: changing shape of the G clef (issue 4664070)

2011-08-22 Thread lemniskata . bernoullego
pushed as e795110331497fbf46a7d61ed6ed73a9da4ae9c5 http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: fixing website translations

2011-08-22 Thread Graham Percival
On Mon, Aug 22, 2011 at 12:57:41AM +0200, Federico Bruni wrote: Il giorno ven, 12/08/2011 alle 09.07 -0700, Graham Percival ha scritto: WARNING: Unable to find node 'Text editor support' in book usage. WARNING: Unable to find node 'Troubleshooting' in book usage. WARNING: Unable to

Re: GOP-PROP 8: issue priorities (probable 2)

2011-08-22 Thread Graham Percival
On Sun, Aug 21, 2011 at 10:19:23AM +0100, Phil Holmes wrote: Think we need to change the description of this on the tracker to make it clear it's not just collisions. ok,done. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-22 Thread Janek Warchoł
2011/8/22 percival.music...@gmail.com: Yes, definitely do the pushing stuff in a separate patch.  But here's an outline: 1. update with  git pull -r 2. check you only have 1 patch ready with  git status git status shows patches?? Didn't you mean check that your work is nicely packed in one

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-22 Thread Reinhold Kainhofer
Am Monday, 22. August 2011, 09:49:41 schrieben Sie: Yes, definitely do the pushing stuff in a separate patch. But here's an outline: 1. update with git pull -r 2. check you only have 1 patch ready with git status That's the step where I like qgit, because it gives you a really good

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread Reinhold Kainhofer
Am Monday, 22. August 2011, 08:16:47 schrieb mts...@gmail.com: I'm a fan of this. git blame already shows who did what (that said, I was git blaming the other day and a lot of things show up as Graham Percival because of the great indenting push of 2011 - is there a way to see multiple layers

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread reinhold . kainhofer
http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly File input/regression/color.ly (right): http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 input/regression/color.ly:24: \override Flag #'color = #blue Why don't you choose a different color to

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread Mike Solomon
On Aug 22, 2011, at 12:06 PM, reinhold.kainho...@gmail.com wrote: http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly File input/regression/color.ly (right): http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 input/regression/color.ly:24:

Re: modifying default behaviour of tremolo slashes (issue 4636081)

2011-08-22 Thread lemniskata . bernoullego
Regtest added. http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc File lily/stem-tremolo.cc (right): http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc#newcode118 lily/stem-tremolo.cc:118: shape = ly_symbol2scm (beam-like); On 2011/08/11 20:05:10, Neil

[PATCH] Lilypond-book: get rid of lilyquote snippet option, use quote instead

2011-08-22 Thread Reinhold Kainhofer
Here's a patch that removes the lilyquote snippet option, since it doesn't really give any benefit over using the quote option. The only difference between the lilyquote and quote options so far was that with lilyquote the texinfo and doctitle was outside the example block. However, we didn't

Lilypond-book: Get rid of lilyquote option, use quote instead (issue 4921050)

2011-08-22 Thread lemzwerg
LGTM. http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py#newcode250 python/book_texinfo.py:250: if (QUOTE in snippet.option_dict): Why parentheses? Similar lines in

[PATCH] Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode

2011-08-22 Thread Reinhold Kainhofer
Please review: http://codereview.appspot.com/4938044 This patch adds autodetection of linewidth and exampleindent to the texinfo mode. This works by simply running a test file (with the layout settings extracted from the original tely file) through texi2pdf, which prints out the value of the

Re: fixing website translations

2011-08-22 Thread Federico Bruni
Il giorno lun, 22/08/2011 alle 00.57 -0700, Graham Percival ha scritto: There is NO SUCH @node called {Text editor support}. You have named that @node LilyPond e gli editor di testo. So fix your Documentation/it/web/introduction.itexi Do the same for the other two lines as well. Ok,

Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

2011-08-22 Thread dak
http://codereview.appspot.com/4938044/diff/7001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4938044/diff/7001/python/book_texinfo.py#newcode228 python/book_texinfo.py:228: val = float (m.group (1))/72 This would be wrong. TeX's principal unit, the

Re: [PATCH] Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode

2011-08-22 Thread David Kastrup
Reinhold Kainhofer reinh...@kainhofer.com writes: Please review: http://codereview.appspot.com/4938044 This patch adds autodetection of linewidth and exampleindent to the texinfo mode. This works by simply running a test file (with the layout settings extracted from the original tely

Re: Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

2011-08-22 Thread reinhold . kainhofer
Reviewers: dak, Message: On 2011/08/22 11:51:37, dak wrote: python/book_texinfo.py:228: val = float (m.group (1))/72 This would be wrong. TeX's principal unit, the pt or printer's point, is 1in/72.27. You are confusing this with PostScript points, 1in/72, which TeX calls bp (big points).

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread Han-Wen Nienhuys
On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon mike...@ufl.edu wrote: http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 scm/define-grob-properties.scm:276: (flag-style ,symbol? A symbol determining what style of flag rename to style? Unfortunately, then we

[PATCH] Properly work around 1816: Reduce the linewidth by 1mm

2011-08-22 Thread Reinhold Kainhofer
Please review: http://codereview.appspot.com/4940043 Fix 1816: Lilypond-book: Give images 1mm less linewidth lilypond creates images that are wider than allowed (~0.5-1mm too wide, e.g. 160.51mm instead of 160mm), so workaround this by removing 1mm from the linewidth. Also remove code that

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread mtsolo
On 2011/08/22 12:52:05, hanwenn wrote: On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon mailto:mike...@ufl.edu wrote: http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 scm/define-grob-properties.scm:276: (flag-style ,symbol? A symbol determining what

Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

2011-08-22 Thread lemzwerg
LGTM. Perhaps you should mention that reducing the line width by 1mm is a temporary hack. http://codereview.appspot.com/4940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: dotcol_ variable in rhythmic-column-engraver.cc

2011-08-22 Thread Han-Wen Nienhuys
Unused things can be thrown away. Period. If people need them, we can resurrect them from the git logs. On Mon, Aug 22, 2011 at 4:27 AM, Mike Solomon mike...@ufl.edu wrote: This variable is unused - is it OK to get rid of it, or is someone planning on building around it (I'm pretty sure it

Re: Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

2011-08-22 Thread reinhold . kainhofer
Reviewers: lemzwerg, http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (right): http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#newcode178 python/book_snippets.py:178: %% offset the left padding and tex2pdf needs a bit of on

Re: [PATCH] Lilypond-book: get rid of lilyquote snippet option, use quote instead

2011-08-22 Thread Phil Holmes
- Original Message - From: Reinhold Kainhofer reinh...@kainhofer.com To: LilyPond Development lilypond-devel@gnu.org Sent: Monday, August 22, 2011 12:01 PM Subject: [PATCH] Lilypond-book: get rid of lilyquote snippet option,use quote instead Here's a patch that removes the lilyquote

Re: Ends of barlines are hidden in staff lines. (issue 4809057)

2011-08-22 Thread janek . lilypond
Does this qualify for a regtest? http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc File lily/bar-line.cc (right): http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc#newcode48 lily/bar-line.cc:48: SCM staff_color = Staff_symbol_referencer::color (me); On 2011/08/13

[OT] Hungry?

2011-08-22 Thread Janek Warchoł
We should definately prepare some of those if we ever organize a LilyPond developers meeting http://www.cuisine.com.au/recipe/Frogs-in-the-lily-pond :) Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-08-22 Thread Janek Warchoł
Hi, after disappearing for some time (sorry for that) i'm reading my inbox and found that guitar capo transposer isn't finished! Wol, how can i help you? Would you like me to investigate the scheme function about which you wrote on frogs list (After capo handler comes capo key)? Maybe it would

patches for LilyPond issues 1503 and 1572

2011-08-22 Thread Janek Warchoł
Hi Adam, apparently you didn't receive my previous e-mail, so i'm writing again. I'd like to help you with your patches about jazz chords display (issue 1503, and also you said that you have some patches for 1572). It looks like they are being overlooked. We should upload them to Rietveld so

Re: Remove special case in staff-spacing (issue 4188051)

2011-08-22 Thread janek . lilypond
Keith, can you close Rietveld issue 4188051? thanks, Janek http://codereview.appspot.com/4188051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GOP-PROP 9: behavior of make doc (probable decision)

2011-08-22 Thread Janek Warchoł
Hm, LGTM? Phil, i'm amazed by your patience. thanks, Janek 2011/8/17 Graham Percival gra...@percival-music.ca: Not much discussion, not much change from the last version. http://lilypond.org/~graham/gop/gop_9.html Proposal summary If there are build problems, then it should be easier to

Re: GOP-PROP 9: behavior of make doc (probable decision)

2011-08-22 Thread Phil Holmes
- Original Message - From: Janek Warchoł janek.lilyp...@gmail.com To: Graham Percival gra...@percival-music.ca Cc: lilypond-devel@gnu.org Sent: Monday, August 22, 2011 5:18 PM Subject: Re: GOP-PROP 9: behavior of make doc (probable decision) Hm, LGTM? Phil, i'm amazed by your

Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-22 Thread Janek Warchoł
LGTM (yeah, i'm quite late) 2011/8/16 Graham Percival gra...@percival-music.ca: On Sat, Aug 13, 2011 at 05:26:09PM +0100, Trevor Daniels wrote: I like Keith's Needs. This easily extends to several labels if we find that is desirable.  Other suggestions: Thanks, I like Needs_evidence; it's

Fixes missing images in web-big-page (issue 4922046)

2011-08-22 Thread PhilEHolmes
Reviewers: Graham Percival, Message: Patch fixes the missing images in web-big-page.html. Please review. Description: This patch works by adding an extra part (web/) to the path to the css link and the example images links, and then using postprocess_html.py to get rid of this for the split

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-22 Thread janek . lilypond
Just to make things clear, LGTM (and sorry for my long absence) Thanks for your work and your patience, James! Janek http://codereview.appspot.com/4837050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: T1349 - Fix load order for running with Guile V2 (issue 4849054)

2011-08-22 Thread ianhulin44
Pushed to master with commit - f41963f0b6135c02c363f8401628e85b9bc60def Ian Hulin http://codereview.appspot.com/4849054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add hihat halfopen glyph to font (issue 4714043)

2011-08-22 Thread janek . lilypond
LGTM! (and sorry for delay) thanks, Janek http://codereview.appspot.com/4714043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

2011-08-22 Thread Janek Warchoł
Hi, i'm very interested in this, i've spotted this problem some time ago. Why is this Rietveld issue marked as closed? I'm adding a link in T issue 706 http://code.google.com/p/lilypond/issues/detail?id=706 I've tried it and it ate some ledger lines, but maybe i have dirty tree. Try this { c'!

Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

2011-08-22 Thread Han-Wen Nienhuys
2011/8/22 Janek Warchoł janek.lilyp...@gmail.com: I wholeheartedly disagree, i think that this issue isn't negligible (or did i misunderstood you, Han-Wen?). My impression is that the patch was not actually changing output. If it was intended to, I couldn't tell from a read of the patch. --

can't reproduce issue 1732 in lilypond/translation (but 'make doc' still fails)

2011-08-22 Thread Federico Bruni
As I've reported in the comment here: http://code.google.com/p/lilypond/issues/detail?id=1732 now input/regression/midi/key-initial.ly is *always* compiled successfully in the lilypond/translation branch (while it still fails in master). I hoped that I could finally run 'make doc' but I still

Re: not all doc clean-ups are good

2011-08-22 Thread Graham Percival
On Sun, Aug 21, 2011 at 07:13:30AM +0200, Werner LEMBERG wrote: Well, it helps in situations like this ... which looks better with a break after the backslash: This is a paragraph with some text to demonstrate that a path name like /usr/ local/share/lilypond/foo.bar should

Re: oops! I've changed files in the `snippet' directory

2011-08-22 Thread Graham Percival
On Sun, Aug 21, 2011 at 07:53:35AM +0200, Werner LEMBERG wrote: I think the commit message is enough for that? LSR: local import LSR: full import ? Is the format of this commit message fixed? I'm asking because a script might search for it. No, because we don't have any fixed people

Re: Adds a site search to website and improves doc search (issue 4894053)

2011-08-22 Thread Graham Percival
On Mon, Aug 22, 2011 at 11:06:04PM +0200, Janek Warchoł wrote: Phil, could you compile the website with your changes and host it somewhere? (or tell me how to do this properly) Partial instructions are buried in http://code.google.com/p/lilypond/issues/detail?id=1663 It would be nice if those

Re: Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

2011-08-22 Thread percival . music . ca
On 2011/08/22 12:30:15, Reinhold wrote: Now, it's clear that lilypond produces .pdf files that are about 0.5-1 mm too wide. So we now have the proper way to fix #1816 What does 0.5-1mm mean? Is it 0.5 for top/bottom, 1.0 for left/right? Or does it depend on some random factor? (i.e.

Re: Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

2011-08-22 Thread percival . music . ca
http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#oldcode411 python/book_snippets.py:411: if not has_line_width: This change change be pushed now; it's gone through the

PATCH: 48-hour countdown 22:00 MDT 20110824

2011-08-22 Thread Colin Campbell
For Wednesday August 25th, 22:00 Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735: modifying default behaviour of tremolo slashes - R 4636081 http://codereview.appspot.com/4636081/ Issue 1628 http://code.google.com/p/lilypond/issues/detail?id=1628: Fingerings collide with

Re: Make doc is broken

2011-08-22 Thread Colin Campbell
On 11-08-21 04:24 AM, Phil Holmes wrote: - Original Message - From: Reinhold Kainhofer reinh...@kainhofer.com To: lilypond-devel@gnu.org Sent: Saturday, August 20, 2011 6:23 PM Subject: Re: Make doc is broken Hi Phil, Am Saturday, 20. August 2011, 16:26:48 schrieb Phil Holmes: I

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-22 Thread hanwenn
http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc File flower/polynomial.cc (right): http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc#newcode80 flower/polynomial.cc:80: return ret_max ? sols.back () : sols[0]; you could return an interval instead;

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-22 Thread joeneeman
http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc File lily/bezier.cc (right): http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239 lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d != LEFT); On 2011/08/19 07:03:50, MikeSol wrote: On 2011/08/18

Re: not all doc clean-ups are good

2011-08-22 Thread Werner LEMBERG
Well, it helps in situations like this ... which looks better with a break after the backslash: This is a paragraph with some text to demonstrate that a path name like /usr/ local/share/lilypond/foo.bar should be split after backslashes. Really?! As an 11-year