Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-09 Thread pierstitus
Reviewers: , Message: Please review my contribution to this wonderful project. Maybe still in time for 2.16 :) On the other hand, it changes quite a bit of the way ledger lines are handled, and I'm not sure what your policy for new features just before release is. Piers Description: Add support

Re: Offer to clean up (very) old Tracker issues

2011-09-09 Thread Janek Warchoł
2011/9/9 Reinhold Kainhofer : > Am Friday, 9. September 2011, 22:06:07 schrieb Janek Warchoł: >> > So I am running this pass the 'dev' >> > group for any other additional suggestions (such as other labels I >> > could remove/apply, how far forward I should go etc) >> >> I think Graham said everythi

PATCH:72-hour countdown to 20110912

2011-09-09 Thread Colin Campbell
For 22:00 MDT Monday September 12 Issue 1814 : Breve with double-line "ears" can collide with accidentals and barlines - R 4986042 : include lines in breve X-extent Issue 1871

Re: patches for LilyPond issues 1503 and 1572

2011-09-09 Thread Adam Spiers
Sorry Janek, I did receive the email but I've been away travelling for 3 months and only just got back. I would be glad to work with you on getting these patches finalised and submitted, although please bear with me over the next few days as I have some other pressing issues to attend to first. I

Re: Cleaned up style (issue 4951062)

2011-09-09 Thread aleksandr . andreev
Changed code style and glyph names based on the comments of Carl and lemzwerg. Carl, is it OK that the group name is kievan, so now we have glyphs like kievan.s1kievan? Is this how it should be? Re: "you can see that all coordinates rely on meta-parameters which control the appearance" I'm new

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-09 Thread Francisco Vila
Hello all, 2011/9/6 Peekay Ex : > I need to make a new patch. It's because of a combination of things; I was > (and am still) waiting on Francisco to know if I can remove the old compound > meter examples in the snippet refs in the various translation tely files (I > have asked him for a review a

Re: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069)

2011-09-09 Thread tdanielsmusic
LGTM http://codereview.appspot.com/4969069/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Offer to clean up (very) old Tracker issues

2011-09-09 Thread Reinhold Kainhofer
Am Friday, 9. September 2011, 22:06:07 schrieb Janek Warchoł: > > So I am running this pass the 'dev' > > group for any other additional suggestions (such as other labels I > > could remove/apply, how far forward I should go etc) > > I think Graham said everything that could come to my mind. What

Re: Offer to clean up (very) old Tracker issues

2011-09-09 Thread Janek Warchoł
2011/9/8 Peekay Ex : > Hello, > > I've had a brief conversation with Graham who agreed in principle and > asked me to send a mail to dev regarding 'going through' and 'cleaning > up' old tracker issues. that's very nice of you! > So I am running this pass the 'dev' > group for any other additiona

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

2011-09-09 Thread Janek Warchoł
2011/9/9 : > http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#oldcode691 > scripts/lilypond-book.py:691: + '.%s' % global_options.format) > On 2011/09/09 19:19:47, janek wrote: >> >> Pardon my ignorance, but what the >> '.%s' % >> part was doing before? > > It simply prepended

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

2011-09-09 Thread percival . music . ca
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (right): http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode681 scripts/lilypond-book.py:681: chunks = do_file (files[0]) you mean "that do_file BELOW", right? woah, you

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

2011-09-09 Thread reinhold . kainhofer
LGTM, although I would also move that code changing global_options.output_dir from do_file to main, to make things much clearer! http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (left): http://codereview.appspot.com/4996044/diff/1/scripts/lilyp

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

2011-09-09 Thread percival . music . ca
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (right): http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode677 scripts/lilypond-book.py:677: relative_output_dir = global_options.output_dir did you want an os.path.re

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

2011-09-09 Thread janek . lilypond
Hi, as usual my review will contain only questions... Please pardon my ignorance, i don't know what this area of the code does. However, what your patch does seems reasonable to me. http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (left): htt

Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

2011-09-09 Thread janek . lilypond
Reviewers: julien.rioux_gmail.com, Graham Percival, Message: By Julien Rioux. Description: Fix issue #1852: manuals needs more explicit dependencies. Dependencies are already being tracker by lilypond-book.py, which produces .dep files containing make rules. The file stepmake/stepmake/generic-t

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-09 Thread pkx166h
Added http://code.google.com/p/lilypond/issues/detail?id=1878 http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

2011-09-09 Thread tdanielsmusic
Hi Mike I found a visual difference with one of my scores. I finally tracked this down to a dependence on the stem direction. Try this: SopranoMusic = \relative g' { b2 b \once \override Staff . BarLine #'allow-span-bar = ##f b2 b } TenorMusic = \relative a' { b2 b | b2 b | } \score

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-09 Thread pierstitus
http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New Ubuntu PC

2011-09-09 Thread Graham Percival
On Fri, Sep 09, 2011 at 05:37:03PM +0100, Phil Holmes wrote: > I've got 2 disks in it - the main one is a standard SATA drive with > the OS on it. The other one is an 80 GByte SSD (solid state disk) > that I bought with the intention of using as my data disk, so that > compiles, etc., use the fast

Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069)

2011-09-09 Thread joeneeman
lgtm http://codereview.appspot.com/4969069/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

New Ubuntu PC

2011-09-09 Thread Phil Holmes
As I've already discussed with Graham and James, I've just taken delivery of a new PC, and have now loaded Ubuntu 10.04 64 bit onto it. It all seems to be working OK, and it boots in about 10 seconds! I've got 2 disks in it - the main one is a standard SATA drive with the OS on it. The other

parser.yy et al: Turn \transpose into a music function, make other music functions use ly:pitch? (issue 4991049)

2011-09-09 Thread reinhold . kainhofer
LGTM http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly#newcode852 ly/music-functions-init.ly:852: pitch))) indent (or better, write the whole lambda in on

Patch for review: Turn \transpose into a music function, simplify other music functions using ly:pitch? signatures

2011-09-09 Thread David Kastrup
http://codereview.appspot.com/4991049> -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel