Re: Dots in chords can not be moved Issue 1266 (issue 5174043)

2011-10-03 Thread pkx166h
Passes Make and there are reg tests that show up but I can see no significant changes at first glance. See: http://code.google.com/p/lilypond/issues/detail?id=1266#c7 http://codereview.appspot.com/5174043/ ___ lilypond-devel mailing list lilypond-dev

Re: Sketch for broken beams with consistent slopes (issue 4961041)

2011-10-03 Thread pkx166h
Passes make. I get a few reg tests pop up; see attached at http://code.google.com/p/lilypond/issues/detail?id=1952#c1 but also 'spanner-break-overshoot.log' gives me: --snip-- @@ -4,8 +4,6 @@ Preprocessing graphical objects... Calculating line breaks... Drawing systems... -programming err

Re: Sketch for fix of issue 307 (issue 4813048)

2011-10-03 Thread pkx166h
Passes make and make check http://codereview.appspot.com/4813048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Removes closeness-factor from the Slur details list. (issue 4825051)

2011-10-03 Thread pkx166h
added as http://code.google.com/p/lilypond/issues/detail?id=1953 http://codereview.appspot.com/4825051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Abandoned patch countdown 20111003

2011-10-03 Thread David Kastrup
"m...@apollinemike.com" writes: > Issue 737: Enhancement: support for footnotes and/or endnotes. > > > If you could leave this up for another week, that'll give me time to > collect the bounty on it. I don't find that keeping a patch back helps. I tried work for hire (sending the respe

Re: Improves some parmesan noteheads. (issue 4639065)

2011-10-03 Thread bordage . bertrand
Thanks Keith, I'll quickly fix that in a new issue. http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode853 lily/stem.cc:853: extract_grob_set (me, "note-heads", heads); ... OK. http://cod

Re: Abandoned patch countdown 20111003

2011-10-03 Thread Graham Percival
On Mon, Oct 03, 2011 at 10:16:01AM +0200, David Kastrup wrote: > "m...@apollinemike.com" writes: > > > If you could leave this up for another week, that'll give me time to > > collect the bounty on it. > > Since a reward loses its meaning if you need to invest weeks of > bartering, running after

Re: Improves some parmesan noteheads. (issue 4639065)

2011-10-03 Thread k-ohara5a5a
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode855 lily/stem.cc:855: if (attach && !scm_is_eq (style, ly_symbol2scm ("mensural")) On 2011/10/03 08:52:27, Bertrand Bordage wrote: By def

Re: Abandoned patch countdown 20111003

2011-10-03 Thread David Kastrup
Graham Percival writes: > On Mon, Oct 03, 2011 at 10:16:01AM +0200, David Kastrup wrote: >> "m...@apollinemike.com" writes: >> >> > If you could leave this up for another week, that'll give me time to >> > collect the bounty on it. >> >> Since a reward loses its meaning if you need to invest w

Re: Sketch for broken beams with consistent slopes (issue 4961041)

2011-10-03 Thread Mike Solomon
On Oct 3, 2011, at 6:53 AM, hanw...@gmail.com wrote: > i know it's annoying, but could you separate out the cosmetics (adding _ > ) to members from the rest of this change? The cosmetic changes make it > difficult to see the essence of what you are trying to do. > > > http://codereview.appspot

Re: Sketch for broken beams with consistent slopes (issue 4961041)

2011-10-03 Thread Mike Solomon
On Oct 3, 2011, at 6:53 AM, hanw...@gmail.com wrote: > i know it's annoying, but could you separate out the cosmetics (adding _ > ) to members from the rest of this change? The cosmetic changes make it > difficult to see the essence of what you are trying to do. > > > http://codereview.appspot.

Re: Glyphs for Kievan Notation (issue 4951062)

2011-10-03 Thread aleksandr . andreev
I've taken care of the issues Bertrand points out in #46. There are still some issues outstanding. The code in output-lib.scm is probably not the best way of doing this. Also, the Kievan bar line does not appear correctly. http://codereview.appspot.com/4951062/ __

Re: Removes closeness-factor from the Slur details list. (issue 4825051)

2011-10-03 Thread pkx166h
Mike this patch no longer applies to current tree. I get failed hunks. http://codereview.appspot.com/4825051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Sketch for fix of issue 307 (issue 4813048)

2011-10-03 Thread m...@apollinemike.com
On Oct 3, 2011, at 8:24 AM, k-ohara5...@oco.net wrote: > Mike, > Maybe your flower/out didn't get rebuilt after config > --disable-optimising. I had to rm flower/out/* > > > http://codereview.appspot.com/4813048/diff/29001/lily/slur-scoring.cc > File lily/slur-scoring.cc (right): > > http://co

Re: Fixes footnote automatic numbering. (issue 4877041)

2011-10-03 Thread mtsolo
Hey Reinhold et al, This newest patch set should do the trick for automatic numbering. Cheers, MS http://codereview.appspot.com/4877041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Sketch for fix of issue 307 (issue 4813048)

2011-10-03 Thread pkx166h
passes make and make check http://codereview.appspot.com/4813048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Grob::vertical_less and DOWN/UP

2011-10-03 Thread m...@apollinemike.com
Hey all, Currently, I've written the function Grob::vertical_less such that it returns true for a grob that is higher than another grob. This is because the ordering of a vertical alignment's element list goes from top to bottom, so the vertical axis groups with lower indices in the list are h

Re: Fixes footnote automatic numbering. (issue 4877041)

2011-10-03 Thread pkx166h
Passes make but fails make check. Cannot see where I just get --snip-- job 0 terminated with signal: 11 fatal error: Children (0) exited with errors. command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I /home/jlowe/lilypon

Re: Fixes footnote automatic numbering. (issue 4877041)

2011-10-03 Thread m...@apollinemike.com
On Oct 4, 2011, at 8:48 AM, pkx1...@gmail.com wrote: > Passes make but fails make check. Cannot see where I just get > > --snip-- > > job 0 terminated with signal: 11 > fatal error: Children (0) exited with errors. > command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I > /home/jlow