Re: Who is really alive in the bug squad today?

2011-10-31 Thread Graham Percival
On Mon, Oct 31, 2011 at 06:20:31PM +, Peekay Ex wrote: > However the Contributor Guide has I think you're looking at the 2.14 CG ? or maybe from 2.13 ? That section in git looks different. You should remove Dmytro, and check with Brett. - Graham ___

Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

2011-10-31 Thread k-ohara5a5a
This looks more reasonable. I read through a few times until I had it figured out. I left comments where I really needed either code comments or better variable names. Do you know the performance cost of turning on peters-prolongation? http://codereview.appspot.com/5293060/diff/19014/Documentat

Re: Work on 1890: Fix several compiler warnings on amd64 platform (changing variable types) (issue 5039043)

2011-10-31 Thread k-ohara5a5a
Looks fine to me. The type ssize_t is unusual, but it was already in the code before this patch. http://codereview.appspot.com/5039043/diff/3001/flower/polynomial.cc File flower/polynomial.cc (right): http://codereview.appspot.com/5039043/diff/3001/flower/polynomial.cc#newcode332 flower/polynom

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-10-31 Thread Keith OHara
> This fixes the SpanBar regression ID'd by Phil. Well, not exactly. The failing regression test said: texidoc = "SpanBars participate in the horizontal collision system; the accidentals should not collide with the bar lines." This patch implements issue 1955, keeping accidentals, fingerings,

Re: Who is really alive in the bug squad today?

2011-10-31 Thread Phil Holmes
Have a look at http://lilypond.org/doc/v2.15/Documentation/contributor/bug-squad-checklists :-) -- Phil Holmes - Original Message - From: "Peekay Ex" To: "Devel" Cc: Sent: Monday, October 31, 2011 6:20 PM Subject: Who is really alive in the bug squad today? Hello, Now that Dy

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

2011-10-31 Thread Francisco Vila
2011/10/31 Federico Bruni : > Hi Francisco, > > Il 24/10/2011 10:17, Francisco Vila ha scritto: >> >> I will apply it [when at home] and let's see. >> > > you haven't applied it yet, right? Now it is; please pull, test it and tell me. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmb

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

2011-10-31 Thread Federico Bruni
Hi Francisco, Il 24/10/2011 10:17, Francisco Vila ha scritto: I will apply it [when at home] and let's see. you haven't applied it yet, right? I think that as long as the docs compile, your translations are there and up to date, and we have not too many warnings, it is enough headache for

Who is really alive in the bug squad today?

2011-10-31 Thread Peekay Ex
Hello, Now that Dymtro is standing down from his bug squad duties, I'll fill in his slot. However the Contributor Guide has Sunday: Colin Monday: Dmytro Tuesday: James Bailey Wednesday: Ralph Thursday: Patrick Friday: Urs Saturday: Kieren I know that Colin is still alive and kicking but am unsu

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-10-31 Thread m...@apollinemike.com
On Oct 31, 2011, at 3:19 PM, Phil Holmes wrote: > > Mike - do you have a Windows machine? And a Windows .exe for your changes? > If so, you could run my pixel comparator. > > -- > Phil Holmes > > Unfortunately, I don't have a Windows machine, nor am I able to make a Windows .exe :( I'll be

Re: issues to verify

2011-10-31 Thread Graham Percival
ok. Thanks for all your effort so far, and thanks for letting me know. I disagree that the bug meister should be a programmer; this task can be done with email, a web browser, and a moderate amount of making lists on paper (or other means of administrative skill). There is no reason to have a pro

Re: issues to verify

2011-10-31 Thread Dmytro O. Redchuk
Hi, Graham! I am sorry to say that I will be unable to participate in bug squad duties for at least few months. Thank you, thank you developers and everyone who makes lilypond better .) I am sorry that I am saying this in in such a stupid way, I am sorry that this happens so "suddenly"

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-10-31 Thread Phil Holmes
- Original Message - From: To: Cc: ; Sent: Monday, October 31, 2011 9:08 AM Subject: Fixes NoteColumn vs SpanBar collisions. (issue 5323062) Reviewers: , Message: Hey all, This fixes the SpanBar regression ID'd by Phil. It also fixes a few other things: 1) The research I sent ou

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-10-31 Thread Werner LEMBERG
>> Ideally, this should be another three different commits. > > The fixes are offshoots of the solution, meaning that the solution > to this one problem serendipitously fixes the three others. Ah, ok. Werner ___ lilypond-devel mailing list lilypo

Re: patches for LilyPond issues 1503 and 1572

2011-10-31 Thread Carl Sorensen
On 10/31/11 5:58 AM, "Adam Spiers" wrote: >2011/9/10 Janek Warchoł >> Uploaded to Rietveld: http://codereview.appspot.com/4981052/ > >I could be wrong but it looks like Rietveld has all the patches >squashed into a single patch set. Does that mean that when they get >pushed upstream to the of

Re: patches for LilyPond issues 1503 and 1572

2011-10-31 Thread Adam Spiers
2011/9/10 Janek Warchoł > Uploaded to Rietveld: http://codereview.appspot.com/4981052/ I could be wrong but it looks like Rietveld has all the patches squashed into a single patch set. Does that mean that when they get pushed upstream to the official repo, they'll only appear as a single patch?

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-10-31 Thread m...@apollinemike.com
On Oct 31, 2011, at 11:12 AM, Werner LEMBERG wrote: > >> This fixes the SpanBar regression ID'd by Phil. > > Thanks for working on this. Ideally, this should be one commit. > >> It also fixes a few other things: 1) [...] 2) [...] 3) [...] > > Ideally, this should be another three different co

lilypond-book.py: error: file not found: out-test/key-initial-midi.ly

2011-10-31 Thread Adam Spiers
2011/10/31 Carl Sorensen : > On 10/30/11 6:26 PM, "Adam Spiers" wrote: >>OK, I've gotten stuck whilst running regression tests against my >>feature branch.  'make test-redo' yields the following error, but I >>don't see how any of my patches could affect MIDI output, and the >>error persists even

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-10-31 Thread Werner LEMBERG
> This fixes the SpanBar regression ID'd by Phil. Thanks for working on this. Ideally, this should be one commit. > It also fixes a few other things: 1) [...] 2) [...] 3) [...] Ideally, this should be another three different commits. Werner __

Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-10-31 Thread mtsolo
Reviewers: , Message: Hey all, This fixes the SpanBar regression ID'd by Phil. It also fixes a few other things: 1) The research I sent out about accidentals not hanging over barlines (check my e-mails to the list from Oct. 6, Subject: First stab at getting bar extents right) is actualize

patch merge staging

2011-10-31 Thread Graham Percival
Due to my desktop computer update, I can't compile lilypond, and therefore can't run patchy. Hopefully we'll get that fixed in the next few days, but it'd be annoying for people to have their patches floating around in dev/staging for that long. James, or anybody else with a fast or moderately fa