Re: PATCH: Countdown to 20111106

On Thu, Nov 03, 2011 at 11:44:13PM -0700, m...@apollinemike.com wrote: >Another procedural question. I had decided to pull my patch for issue >1986 off of a countdown to work on it some more. I have gotten it to a >point where I'm comfortable with it going back on a countdown. What t

Re: PATCH: Countdown to 20111106

On Nov 3, 2011, at 7:08 PM, Colin Campbell wrote: > For 20:00 MST Sunday November 6th > > Issue 1567: Add documentation for footnotes - R 5315053 > > Issue 1954: request: filter point-and-click creation by events - R 5327061 > > Issue 2000: Patch: Fixes NoteColumn vs SpanBar collisions - R 532

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

I'll try to make a patch so that note-spacing is not affected by potential collisions between grobs from different staff-like-contexts (fixing the rare Lyrics-barline interaction). Then we can restore skyline-vertical-padding. Net, with this patch and the other SpanBarStub patch, you've added 68

Re: Fixes to jazz chord displays (issue 5320074)

New patch set uploaded. Rebased to current master. http://codereview.appspot.com/5320074/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCH: Countdown to 20111106

For 20:00 MST Sunday November 6th Issue 1567 : Add documentation for footnotes - R 5315053 Issue 1954 : request: filter point-and-click c

Re: Fixes to jazz chord displays (issue 5320074)

Patch doesn't apply to current master.. --snip-- jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 < ../Desktop/issue5320074_2001.diff patching file Documentation/included/chord-names-jazz.ly patching file Documentation/notation/chords.itely patching file Documentation/notation/notation-appendice

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

Passes make and no reg test diffs. James http://codereview.appspot.com/5322065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On 11/3/11 10:50 AM, "Adam Spiers" wrote: >On Thu, Nov 03, 2011 at 04:28:53PM +, Graham Percival wrote: >> On Thu, Nov 03, 2011 at 04:00:41PM +, Adam Spiers wrote: >> > On Thu, Nov 03, 2011 at 11:13:28AM +, Peekay Ex wrote: >> >> Moving back to the jazz patches: Carl, could you take

Fixes to jazz chord displays (issue 5320074)

Reviewers: , Message: I've uploaded Adam's changes for review. I removed the spacing changes in scm/chord-ignatzek-names.scm awaiting resolution on .scm indentation. Description: Fixes to jazz chord displays This issue consists of a well-formed series of commits created by Adam Spiers. The co

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

Passes Make but lots of reg test diffs here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html James http://codereview.appspot.com/5323062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://list

Re: Fixes issue 2005 (too much script padding between certain scripts and accidental) (issue 5328063)

Passes Make but no reg test diffs show. James http://codereview.appspot.com/5328063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

Passes Make but a lot of reg test diffs show up Load index.html from the zip here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-1986-reg-tests-td4962636.html James http://codereview.appspot.com/5293060/ ___ lilypond-devel mailing list lilypon

Issue 1954: Implement event type filtering for pointAndClick events. (issue 5327061)

Passes make and no reg test diffs. James http://codereview.appspot.com/5327061/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

Passes make and make check, No reg test diffs. James http://codereview.appspot.com/5333051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 11 -- beamlet points in wrong direction on tuplet (issue 4941041)

Passes make and make check gives one reg test diff attached on http://code.google.com/p/lilypond/issues/detail?id=11#c20 James http://codereview.appspot.com/4941041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On 11/3/11 1:13 PM, "David Kastrup" wrote: >Graham Percival writes: > >> >> My understanding is that Jan insisted on the script matching >> emacs' formatting, but as long as that's done he won't object. >> (come to think of it, that may have been private email after the >> main discussion died

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

Graham Percival writes: > On Thu, Nov 03, 2011 at 06:28:55PM +, Carl Sorensen wrote: >> >> On 11/3/11 10:50 AM, "Adam Spiers" wrote: >> >and given my strong aversion to (a) a mix of indentation styles within >> >a single file, and (b) commits which mix whitespace changes with real >> >codin

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On Thu, Nov 03, 2011 at 06:28:55PM +, Carl Sorensen wrote: > > On 11/3/11 10:50 AM, "Adam Spiers" wrote: > >and given my strong aversion to (a) a mix of indentation styles within > >a single file, and (b) commits which mix whitespace changes with real > >coding changes, I thought this was the

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On 11/3/11 10:50 AM, "Adam Spiers" wrote: >On Thu, Nov 03, 2011 at 04:28:53PM +, Graham Percival wrote: >> On Thu, Nov 03, 2011 at 04:00:41PM +, Adam Spiers wrote: >> > On Thu, Nov 03, 2011 at 11:13:28AM +, Peekay Ex wrote: >> > > One patch per tracker item? >> > >> > I can do that

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On Thu, Nov 3, 2011 at 4:28 PM, Graham Percival wrote: > We're not comfortable with git.  Other than 4 or 5 people, each > person who's started pushing to dev/staging has required between 3 > and 10 emails to get them able to reliably push to a branch > without screwing stuff up. I just discovere

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On Thu, Nov 03, 2011 at 04:28:53PM +, Graham Percival wrote: > On Thu, Nov 03, 2011 at 04:00:41PM +, Adam Spiers wrote: > > On Thu, Nov 03, 2011 at 11:13:28AM +, Peekay Ex wrote: > > > One patch per tracker item? > > > > I can do that if noone objects to tracker items for patches as tr

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On Thu, Nov 03, 2011 at 04:00:41PM +, Adam Spiers wrote: > On Thu, Nov 03, 2011 at 11:13:28AM +, Peekay Ex wrote: > > One patch per tracker item? > > I can do that if noone objects to tracker items for patches as trivial > as converting tabs to whitespace? I'd rather not see those patches

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

On Thu, Nov 03, 2011 at 11:13:28AM +, Peekay Ex wrote: > Adam, > > On Wed, Nov 2, 2011 at 5:58 PM, wrote: > > I think I am now finished.  The new patch series is available at > > > >    https://github.com/aspiers/lilypond/commits/jazz > > > > IMHO there are now too many patches in the series

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode7 input/regression/complex-once.ly:7: \layout { ragged-right = ##t } On 2011/11/

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

LGTM. http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode7 input/regression/complex-once.ly:7: \layout { ragged-right = ##t } redu

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

As an illustration: take a look at ly/property-init.ly. It contains dozens of commands that will cooperate with the new \once. All of them (well, the reverting commands don't, just because \once\revert is not [yet?] workable in general). That's its principal selling point. And I don't want to

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

On 2011/11/03 13:15:23, J_lowe wrote: http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldco

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldcode732 Documentation/notation/changing-def

Re: Error when compiling with 2.15.16 for \drums function

Mikem On Wed, Nov 2, 2011 at 4:55 PM, m...@apollinemike.com wrote: > On Nov 2, 2011, at 5:41 PM, Peekay Ex wrote: > >> Hello, >> >> While helping someone on the lists yesterday I noticed that a file >> would not compile on 2.15.16 but was ok on 2.14.2. >> >> Because of the error message it is I t

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldcode732 Documentation/notation/changing-def

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

On 2011/11/03 11:45:00, Reinhold wrote: http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode11 input/regression/complex-once.ly:

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldcode732 Documentation/notation/changing-def

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode11 input/regression/complex-once.ly:11: \unHideNotes g a \once\hideNotes b c |

Re: *.profile file changes in regression tests?

On Thu, Nov 03, 2011 at 06:31:23AM +, Graham Percival wrote: > On Thu, Nov 03, 2011 at 12:38:02AM +, Adam Spiers wrote: > > Do I need to create an issue and/or Rietveld entry for this and for > > my other patch to {doc,cg}-section.sh, or will someone who knows the > > processes (e.g. Bug Sq

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

Reviewers: Reinhold, Message: On 2011/11/03 10:47:59, Reinhold wrote: LGTM, although regtests are missing (for \once applied to multiple settings at one, stored in a variable). There you are. Description: Implement \once as music function able to operate on complex stuff. Please review thi

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

Adam, On Wed, Nov 2, 2011 at 5:58 PM, wrote: > I think I am now finished.  The new patch series is available at > >    https://github.com/aspiers/lilypond/commits/jazz > > IMHO there are now too many patches in the series to combine into a > single commit for review.  To do so would lose a lot o

Implement \once as music function able to operate on complex stuff. (issue 5322065)

LGTM, although regtests are missing (for \once applied to multiple settings at one, stored in a variable). http://codereview.appspot.com/5322065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-de

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

2011/11/3 Federico Bruni : > On the other hand, I thought (and still think) that the "right committish", > which keeps tracking information AND gives a terse check-translation output, > should exist for these files. Not necesarily, because snippets change. That is where garbage comes from. You se

Re: multiple issues with building docs (patch included)

David Kastrup wrote Thursday, November 03, 2011 9:01 AM Graham Percival writes: and there's no point having everbody work on dev/staging instead of master; we'll still get random breakage and so we'll be no better off than having everybody working on master. Huh? The point is that not

Re: multiple issues with building docs (patch included)

Graham Percival writes: > On Wed, Nov 02, 2011 at 09:13:02PM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > At this very moment, >> > - we cannot build releases >> >> Well, they _are_ development releases anyway. While my computing >> facilities are quite limited (single Penti

Re: *.profile file changes in regression tests?

On Thu, Nov 03, 2011 at 03:28:14AM +, Carl Sorensen wrote: > > I tried to apply this patch, but couldn't, probably because of the way > Outlooks works (or doesn't) on OS/X. Don't forget that various mail servers automatically add a > in front of any line beginning with "From". That breaks ev

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

On Wed, Nov 02, 2011 at 09:34:12AM +, mts...@gmail.com wrote: > > So that's my reasoning. But the question "why didn't Mike..." should be > addressed to Han-Wen: as he was the one who created it, he may have > answers that I don't. ok, good answer. - Graham

Re: multiple issues with building docs (patch included)

Graham Percival writes: > On Thu, Nov 03, 2011 at 08:40:46AM +0100, David Kastrup wrote: >> And as long as nobody commits directly to master, dev/staging does not > ~ > > what if Han-Wen or John pops in to make a quick bugfix (say, to > the transla

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

Il 01/11/2011 20:32, Francisco Vila ha scritto: I do not see this output especially abnormal. As you know, from this output you will obtain one of -- changes to lilypond code. You should ignore it. -- changes to translations doctitleXX or texidocXX other than yours. Ignore those, too. -

Re: multiple issues with building docs (patch included)

On Wed, Nov 02, 2011 at 09:13:02PM +0100, David Kastrup wrote: > Graham Percival writes: > > > At this very moment, > > - we cannot build releases > > Well, they _are_ development releases anyway. While my computing > facilities are quite limited (single Pentium M of moderate speed), and > my t

Re: multiple issues with building docs (patch included)

On Thu, Nov 03, 2011 at 08:40:46AM +0100, David Kastrup wrote: > And as long as nobody commits directly to master, dev/staging does not ~ what if Han-Wen or John pops in to make a quick bugfix (say, to the translation handling stuff), hasn't spent 1

Re: multiple issues with building docs (patch included)

Graham Percival writes: > On Wed, Nov 02, 2011 at 09:13:02PM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > At this very moment, >> > - we cannot build releases >> >> Well, they _are_ development releases anyway. While my computing >> facilities are quite limited (single Penti