Re: what should patchy do for staging?

David, On Fri, Nov 11, 2011 at 6:38 AM, David Kastrup wrote: > Graham Percival writes: > >> On Thu, Nov 10, 2011 at 11:56:30PM +0100, David Kastrup wrote: >>> Let's take the "David, I tested dev/staging at commit 43214314xx, >>> and it's fine" mail scenario. >> >> David, I ran Patchy, and it

Re: Keep yaffut from attempting to demangle. (issue 5375051)

On 2011/11/10 20:07:34, J_lowe wrote: Passes make and no reg test diffs +// Modified to omit demangling, filter through c++filt -t instead Please, do not add changelogs to source files; we have Git for that. Also, what I miss in this description is *why* you made the change, I can see that you

Re: what should patchy do for staging?

Graham Percival writes: > On Thu, Nov 10, 2011 at 11:56:30PM +0100, David Kastrup wrote: >> Let's take the "David, I tested dev/staging at commit 43214314xx, >> and it's fine" mail scenario. > > David, I ran Patchy, and it built commit > cd229915fc873fdb6fd0125827452cb0ba0067a7 and it's fine.

PATCH: Countdown to 20111113

For 20:00 MST Sunday November 13 Issue 2034 : Patch: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) - R 5371050 Issue 1875

Re: what should patchy do for staging?

On Thu, Nov 10, 2011 at 11:56:30PM +0100, David Kastrup wrote: > Let's take the "David, I tested dev/staging at commit 43214314xx, > and it's fine" mail scenario. David, I ran Patchy, and it built commit cd229915fc873fdb6fd0125827452cb0ba0067a7 and it's fine. Patchy has printed out the -

Re: what should patchy do for staging?

David Kastrup writes: > Let's take the "David, I tested dev/staging at commit 43214314xx, > and it's fine" mail scenario. > > What I would do then is > git push origin 43214314xx:refs/heads/dev/staging > > and see whether it fails. _That_ is something you can equally well. > The differen

Re: what should patchy do for staging?

Graham Percival writes: > On Wed, Nov 09, 2011 at 05:33:53PM +0100, David Kastrup wrote: >> Try the following, and please make it fail if any command returns a >> non-zero exit status. I don't know Python at all. > > thanks, pushed under your name. I then added the "fail with > non-zero" thing.

Re: what should patchy do for staging?

On Wed, Nov 09, 2011 at 05:33:53PM +0100, David Kastrup wrote: > Try the following, and please make it fail if any command returns a > non-zero exit status. I don't know Python at all. thanks, pushed under your name. I then added the "fail with non-zero" thing. I ran it briefly on my laptop and

Re: can't release 2.15.17 due to translators

Francisco Vila writes: > 2011/11/10 David Kastrup : >> The normal workflow would be to merge _from_ master into translation, >> but _into_ staging from translation. > > Right; this could cause undesired material from master to be put into > staging through translation. There is no undesired mate

Re: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) (issue 5371050)

Passes make and no reg test diffs James http://codereview.appspot.com/5371050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Keep yaffut from attempting to demangle. (issue 5375051)

Passes make and no reg test diffs james http://codereview.appspot.com/5375051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

passes make and reg tests all posted here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-10-Nov-2011-td4962666.html James http://codereview.appspot.com/5323062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org ht

Re: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) (issue 5371050)

Ok, lgtm http://codereview.appspot.com/5371050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

On Nov 10, 2011, at 10:38 AM, k-ohara5...@oco.net wrote: > On 2011/11/10 14:51:22, MikeSol wrote: > >>> If we know the space allocated to a staff during horizontal spacing >> (the >>> ly:axis-group-interface::height, I think) and the goal (for issue >> 1955) is to >>> build a wall to block anythi

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

On 2011/11/10 14:51:22, MikeSol wrote: If we know the space allocated to a staff during horizontal spacing (the ly:axis-group-interface::height, I think) and the goal (for issue 1955) is to build a wall to block anything on the staff, then why build each wall to a custom, usually shorter,

Re: can't release 2.15.17 due to translators

2011/11/10 David Kastrup : > The normal workflow would be to merge _from_ master into translation, > but _into_ staging from translation. Right; this could cause undesired material from master to be put into staging through translation. And it is going to form a three thread braid. Is it okay? -

Re: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) (issue 5371050)

Reviewers: joeneeman, md5i, http://codereview.appspot.com/5371050/diff/1/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/5371050/diff/1/lily/grob.cc#newcode536 lily/grob.cc:536: c = c->dim_cache_[a].parent_; On 2011/11/10 16:41:54, joeneeman wrote: After this loop, balanc

Re: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) (issue 5371050)

http://codereview.appspot.com/5371050/diff/1/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/5371050/diff/1/lily/grob.cc#newcode536 lily/grob.cc:536: c = c->dim_cache_[a].parent_; On 2011/11/10 16:41:54, joeneeman wrote: After this loop, balance will be 0, right? So the ne

grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) (issue 5371050)

http://codereview.appspot.com/5371050/diff/1/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/5371050/diff/1/lily/grob.cc#newcode536 lily/grob.cc:536: c = c->dim_cache_[a].parent_; After this loop, balance will be 0, right? So the next loop won't do anything... http://coder

Re: can't release 2.15.17 due to translators

Graham Percival writes: > On Thu, Nov 10, 2011 at 01:26:25PM +0100, Francisco Vila wrote: >> 2011/11/10 Graham Percival : >> >> Before adding "(obviously not enough)" to "I've done my best" I must >> >> repeat, the commit was tested and the docs compiled. The issue is >> >> distribution related.

Re: can't release 2.15.17 due to translators

On Thu, Nov 10, 2011 at 01:26:25PM +0100, Francisco Vila wrote: > 2011/11/10 Graham Percival : > >> Before adding "(obviously not enough)" to "I've done my best" I must > >> repeat, the commit was tested and the docs compiled. The issue is > >> distribution related.  With your help, I'll find a way

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

On Nov 9, 2011, at 11:19 PM, k-ohara5...@oco.net wrote: > On 2011/08/30 16:28:28, mikesol_ufl.edu wrote: >> On Aug 30, 2011, at 5:53 PM, mailto:joenee...@gmail.com wrote: > >> > Correct me if I'm wrong, but this is my understanding: wherever > there's >> > a SpanBar, you're creating SpanBarStubs

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

As always, many thanks for your comments! http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc#newcode72 lily/pure-from-neighbor

Re: can't release 2.15.17 due to translators

2011/11/10 Graham Percival : >> Before adding "(obviously not enough)" to "I've done my best" I must >> repeat, the commit was tested and the docs compiled. The issue is >> distribution related.  With your help, I'll find a way to fix >> distribution problems without running GUB (I've tried that be

Re: can't release 2.15.17 due to translators

On Thu, Nov 10, 2011 at 09:44:06AM +0100, Francisco Vila wrote: > 2011/11/10 David Kastrup : > > We really need to stop the untested commits to master. > > Before adding "(obviously not enough)" to "I've done my best" I must > repeat, the commit was tested and the docs compiled. The issue is > dis

Re: mem leak problem

On Wed, Nov 09, 2011 at 06:04:58PM -0800, m...@apollinemike.com wrote: > Is there a profiling tool i can use to show memory leaks, > especially on that can compare between two runs of a program > (for example, one that's on current master and one that's with > my patch)? search the archives for va

Re: can't release 2.15.17 due to translators

On Thu, Nov 10, 2011 at 10:20:37AM +0100, David Kastrup wrote: > Graham Percival writes: > > > as soon as something is in master, I can move it to > > release/unstable and build a release. > > I rebased dev/staging on top of an emergency fix (no idea whether this > will do the trick). I'll try

Re: Issue 2018 in lilypond: Patch: parser.yy: allow postevents in function arguments in general

Peekay Ex writes: > David, > > On Thu, Nov 10, 2011 at 10:01 AM, wrote: >> >> Comment #10 on issue 2018 by d...@gnu.org: Patch: parser.yy: allow >> postevents in function arguments in general >> http://code.google.com/p/lilypond/issues/detail?id=2018 >> >> Somebody updated master differently th

Re: Issue 2018 in lilypond: Patch: parser.yy: allow postevents in function arguments in general

David, On Thu, Nov 10, 2011 at 10:01 AM, wrote: > > Comment #10 on issue 2018 by d...@gnu.org: Patch: parser.yy: allow > postevents in function arguments in general > http://code.google.com/p/lilypond/issues/detail?id=2018 > > Somebody updated master differently than with the current dev/staging

newlines at end of file

Folks, please adjust your favourite editor to automatically insert a newline at the end of file at saving time in case it is missing. It's a nuisance to see having `diff' emit \ No newline at end of fine I've recently fixed that for a bunch of files, but right now I'm seeing it again (in Mi

Re: can't release 2.15.17 due to translators

Graham Percival writes: > On Wed, Nov 09, 2011 at 10:18:08PM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > can somebody fix this? and depending on dak, either push directly >> > to master (which means he has to play yet more games with >> > dev/staging), >> >> dev/staging is

Re: can't release 2.15.17 due to translators

2011/11/10 David Kastrup : >> My deepest apologies, I cannot correct it until this evening (worktime >> 08:00-18:00). >> >> file name should not have any trailing *S* >> >> Documentation/fr/texidocs/alternative-breve-note.texidoc > > We really need to stop the untested commits to master. I really

Re: can't release 2.15.17 due to translators

Lilyfan writes: >> Message du 09/11/11 21:00 >> De : "Graham Percival" >> A : lilypond-devel@gnu.org >> Copie à : >> Objet : can't release 2.15.17 due to translators >> >> can somebody fix this? and depending on dak, either push directly >> to master (which means he has to play yet more games wit

Re: can't release 2.15.17 due to translators

2011/11/9 Graham Percival : > yep.  :/ > you'd think that they would stop doing this the 5th or 6th time I > complained. I bet fot 6th :-) -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mailing list lilypond

re: can't release 2.15.17 due to translators

> Message du 09/11/11 21:00 > De : "Graham Percival" > A : lilypond-devel@gnu.org > Copie à : > Objet : can't release 2.15.17 due to translators > > can somebody fix this? and depending on dak, either push directly > to master (which means he has to play yet more games with > dev/staging), or push