Re: Most popular French users request : bar numbering of alternatives

On Mon, Nov 28, 2011 at 01:04:06AM +0100, Xavier Scheuer wrote: > Dear LilyPond developers, > > Dear Bug Squad members, could you add this enhancement request to > the tracker? Thanks! > > This is by far the most popular enhancement request from the French > users mailing list: Bar numbering of

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

Hairpins already get padding at the span bars, so rather than add a second implementation can't we just repair the existing implementation ? Maybe will do. (I'm just starting a make check.) http://codereview.appspot.com/5438060/diff/7010/lily/system.cc

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On Nov 28, 2011, at 10:05 AM, k-ohara5...@oco.net wrote: > Hairpins already get padding at the span bars, so rather than add a > second implementation can't we just repair the existing implementation ? > > Maybe will do. (I'm just > starting a make check.

Work around compiler bug, Issue 1997: segfault in tablature-negative-fret.ly (issue 5431088)

Reviewers: , Message: This makes the regtest on my 32bit x86 Ubuntu 11.10 work with optionless autogen.sh for the first time. Description: Work around compiler bug, Issue 1997: segfault in tablature-negative-fret.ly Please review this at http://codereview.appspot.com/5431088/ Affected files:

Re: Work around compiler bug, Issue 1997: segfault in tablature-negative-fret.ly (issue 5431088)

Looks excellent to me. Thanks, Carl http://codereview.appspot.com/5431088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Most popular French users request : bar numbering of alternatives

On 2011-11-28 09:44, Colin Hall wrote: On Mon, Nov 28, 2011 at 01:04:06AM +0100, Xavier Scheuer wrote: Dear LilyPond developers, Dear Bug Squad members, could you add this enhancement request to the tracker? Thanks! This is by far the most popular enhancement request from the French users ma

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

Passes Make and make check james http://codereview.appspot.com/5438060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Asserts that footnotes are being numbered correctly. (issue 5433065)

Passes make and make check James http://codereview.appspot.com/5433065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Work around compiler bug, Issue 1997: segfault in tablature-negative-fret.ly (issue 5431088)

LGTM http://codereview.appspot.com/5431088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Better pure heights for slurs (issue 5431065)

Passes Make. Reg tests here http://lilypond-stuff.1065243.n5.nabble.com/Tracker-2051-28-November-Test-results-td5029591.html James http://codereview.appspot.com/5431065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/ma

Build: don't check gcc version numbers with clang (issue 5440043)

Passes make and make check, I also removed the build dir I use and redid autogen.sh --noconfigure and then ran a full ../configure --disable-optimising; make ; make test-baseline all without issue James http://codereview.appspot.com/5440043/ ___ lily

Cannot 'make' staging to push to master

Hello, Patchy's younger sister 'Patchita' failed to 'make' on staging this evening. --snip-- Begin LilyPond compile, commit: 45b219221124f4d7b977a1a0b1e489c47bb3ac02 Merged staging, now at: 0fa48c98e783d7e85cef2fc62517f7c477b7c8ac Success: ./autogen.sh --noconfigure Success: ../configure *** FAI

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

Pushed to staging as f955789f..0fa48c98 http://codereview.appspot.com/5343050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve HTML output of regression tests (issue 5342042)

Pushed to staging as 1294535b http://codereview.appspot.com/5342042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: avoid cryptic StopIteration failure from make when 'make check' is run before 'make test-baseline' (issue 5361042)

Pushed to staging as 46081ce4 http://codereview.appspot.com/5361042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Usability improvements to {doc,cg}-section.sh and corresponding section of CG. (issue 5342043)

Reviewers: carl.d.sorensen_gmail.com, Message: Pushed to staging as f955789f Description: Usability improvements to {doc,cg}-section.sh and corresponding section of CG. - Now honor LILYPOND_GIT, LILYPOND_BUILD_DIR, and LILYPOND_TEMPDOCS environment variables (all optional). - Provide usage he

Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Reviewers: , Message: I'm not sure if this is the best way to go about it, but it seems to get the job done! Cheers, MS Description: Allows for automatic renumbering of measure numbers at volta repeats. Please review this at http://codereview.appspot.com/5440049/ Affected files: M lily/bar-

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Thanks for taking this on. I sense that this is a step in the direction of helping LilyPond really understand codas and segnos. But the terminology is unclear for this musically unsophisticated user. And I'm not sure I really understand how it all works. Thanks, Carl http://codereview.appsp

Re: Cannot 'make' staging to push to master

James writes: > Hello, > > > Patchy's younger sister 'Patchita' failed to 'make' on staging this > evening. > > --snip-- > > Begin LilyPond compile, commit: > 45b219221124f4d7b977a1a0b1e489c47bb3ac02 > Merged staging, now at: 0fa48c98e783d7e85cef2fc62517f7c477b7c8ac > Success: ./autogen.sh --noco

Re: Most popular French users request : bar numbering of alternatives

Hi, 2011/11/28 Alexander Kobel > On 2011-11-28 09:44, Colin Hall wrote: > >> >> On Mon, Nov 28, 2011 at 01:04:06AM +0100, Xavier Scheuer wrote: >> >>> Dear LilyPond developers, >>> >>> Dear Bug Squad members, could you add this enhancement request to >>> the tracker? Thanks! >>> >>> This is by

Re: Cannot 'make' staging to push to master

On Mon, Nov 28, 2011 at 09:11:59PM +, James wrote: > Patchy's younger sister 'Patchita' failed to 'make' on staging this evening. WTM is Patchita? > Previous good commit: 91f314bea692ffb82a2c784cfbf8e339f2c12580 > Current broken commit: 45b219221124f4d7b977a1a0b1e489c47bb3ac02 I'm not certai

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On 2011/11/28 09:11:47, mike_apollinemike.com wrote: If the hairpins stop before span bars but extend all the way when span bar's don't exist (including when they are not present because of the RemoveEmptyStaffContext), then I'd much rather go with your patch, as it is much less invasive than min

rebasing inside staging

Compile of staging dies due to: baf650c616cf73ab8ee47e28b298f7d7e1336867 Author: Adam Spiers 2011-07-28 00:51:12 Committer: Adam Spiers 2011-11-28 09:31:44 Parent: c8e6f4dbdbe2932504aa294394862728cff0ba5c (Replace tabs with spaces in scm/chord-ignatzek-names.scm) Child: baf650c616cf73ab8ee47

Re: rebasing inside staging

Graham Percival writes: > Compile of staging dies due to: > > > baf650c616cf73ab8ee47e28b298f7d7e1336867 > Author: Adam Spiers 2011-07-28 00:51:12 > Committer: Adam Spiers 2011-11-28 > 09:31:44 > Parent: c8e6f4dbdbe2932504aa294394862728cff0ba5c (Replace tabs > with spaces in scm/chord-ignatze

Re: rebasing inside staging

On Tue, Nov 29, 2011 at 03:41:25AM +0100, David Kastrup wrote: > Graham Percival writes: > > > 2) remove that commit, then rebase origin/staging on the result. > > > > I'm not comfortable rewriting history on a shared repository. > > I'll do the second one. Rewriting history is easy, and that i

Re: rebasing inside staging

Graham Percival writes: > On Tue, Nov 29, 2011 at 03:41:25AM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > 2) remove that commit, then rebase origin/staging on the result. >> > >> > I'm not comfortable rewriting history on a shared repository. >> >> I'll do the second one. Re

Re: rebasing inside staging

Graham Percival writes: > On Tue, Nov 29, 2011 at 03:41:25AM +0100, David Kastrup wrote: > >> An interesting question is how the commit could >> a) acquire changes not at all described in the commit message > > eh? The description seems legit here. At least, I assume that > changing \super to \

Re: rebasing inside staging

On Tue, Nov 29, 2011 at 04:09:48AM +0100, David Kastrup wrote: > I backed out all of the jazz chord changes. Since they were last in > staging, this did not actually require a rebase. This should likely be > pretty painless. It does have the disadvantage that anybody who already > fetched them c

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Works nicely. I'm inspired to name some variables in Irish now! And, I'll be sure the names are misleadingly related, but critically distinct, from the conceptual contents of the variable. http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc File lily/bar-number-engraver.cc

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

On Mon, 28 Nov 2011 19:54:42 -0800, wrote: http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc#newcode38 lily/bar-number-engraver.cc:38: int renvoi_number_; maybe "alternative_number_" Isn't there already a counter for that somewhere? Probably the letters /should/ be base

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On Mon, 28 Nov 2011 22:58:07 -0800, m...@apollinemike.com wrote: I've attached the regtest I added compiled w/ Keith's patch & with my patch. Your test case has one very long hairpin in each staff, spanning three systems. Do we want to insert a gap in the broken hairpin to make room for the

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On Nov 29, 2011, at 8:25 AM, Keith OHara wrote: > On Mon, 28 Nov 2011 22:58:07 -0800, m...@apollinemike.com > wrote: > >> I've attached the regtest I added compiled w/ Keith's patch & with my patch. > > Your test case has one very long hairpin in each staff, spanning three > systems. > Do we

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Passes Make and make check just gives me --snip-- /home/jlowe/lilypond-git/input/regression/display-lily-tests.log @@ -13,6 +13,9 @@ Test 106 unequal: NOT A BUG. in = \transpose c d { c d } out = { d e } +Test 111 unequal: . +in = \repeat volta 2 { c4 d } \alternative { { c d } { e f } } +