On 2011/12/29 06:45:53, Graham Percival wrote:
First thought: I'm a bit leery of adding a push to staging, since:
1. that clutters up the interface. Sure, it's just one more button,
but OTOH
that's 25% more buttons. :)
It would seem to me that this button need only appear when you have
Graham, can you ping me when changes to lily-git.tcl are finalized and
I'll get new version into lilydev-remix image. Thanks,
Jon
2011/12/29 Janek Warchoł janek.lilyp...@gmail.com:
2011/12/29 pkx1...@gmail.com:
On 2011/12/29 08:31:38, dak wrote:
It would seem to me that this button need only
- Original Message -
From: pkx1...@gmail.com
To: philehol...@googlemail.com; perciv...@gmail.com;
tdanielsmu...@googlemail.com
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Thursday, December 29, 2011 1:42 PM
Subject: Re: Removes ugly side bars from learning
- Original Message -
From: Aleksandr Andreev aleksandr.andr...@gmail.com
To: Carl Sorensen c_soren...@byu.edu
Cc: lilypond-devel@gnu.org
Sent: Wednesday, December 28, 2011 5:06 PM
Subject: Re: Regression tests don't run
Here's the contents of the relevant log file:
GNU LilyPond
On 2011/12/29 18:19:26, Graham Percival wrote:
On Thu, Dec 29, 2011 at 05:21:34PM +,
mailto:carl.d.soren...@gmail.com wrote:
The Push button is disabled by default; an experienced user can
enable
it with a simple edit to the script.
By disabled, do you mean commented out ? If new
Aha. Some Googling reveals that:
Exit code 137: The job was killed because it exceeded the time limit.
Any ideas how to up the time limit?
On Thu, Dec 29, 2011 at 10:54 AM, Phil Holmes m...@philholmes.net wrote:
- Original Message - From: Aleksandr Andreev
aleksandr.andr...@gmail.com
I have a final draft (see files attached):
- colors are now similar to the highlighting of Frescobaldi 2
- fixed some regexps
- replaced a couple of hungry regexps with lists
I'm quite happy with this version.
Please let me know if you spot any error or missing item.
I'll send a patch to
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (right):
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/common-notation.itely#newcode853
Reviewers: percivall, J_lowe, Trevor Daniels,
Message:
Please review
Description:
Please see http://code.google.com/p/lilypond/issues/detail?id=2152 for
more detail on what and why.
Please review this at http://codereview.appspot.com/5498089/
Affected files:
M
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Aleksandr Andreev aleksandr.andr...@gmail.com
Cc: Phil Holmes m...@philholmes.net; lilypond-devel@gnu.org
Sent: Thursday, December 29, 2011 6:12 PM
Subject: Re: Regression tests don't run
On Thu, Dec 29, 2011 at
Just some very minor queries.
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (right):
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/common-notation.itely#newcode853
On Thu, Dec 29, 2011 at 05:21:34PM +, carl.d.soren...@gmail.com wrote:
The Push button is disabled by default; an experienced user can enable
it with a simple edit to the script.
By disabled, do you mean commented out ? If new contributors
see a greyed-out button, they'll get confused and
2011/12/29 pkx1...@gmail.com:
On 2011/12/29 08:31:38, dak wrote:
It would seem to me that this button need only appear when you have
told the configuration (is there one?)
Not for lily-git.tcl specifically, but there _is_ something it checks
wen you run it; for instance if you use it for
I've uploaded a new patch set.
The Push button is disabled by default; an experienced user can enable
it with a simple edit to the script. I couldn't find a good value that
I believed would work for automatic detection, since my push-enabled
configuration is different from that listed in the
- Original Message -
From: Aleksandr Andreev aleksandr.andr...@gmail.com
To: Phil Holmes m...@philholmes.net
Cc: Carl Sorensen c_soren...@byu.edu; lilypond-devel@gnu.org
Sent: Thursday, December 29, 2011 5:41 PM
Subject: Re: Regression tests don't run
Phil,
I ran it again this
On 2011/12/29 08:31:38, dak wrote:
It would seem to me that this button need only appear when you have
told the
configuration (is there one?)
Not for lily-git.tcl specifically, but there _is_ something it checks
wen you run it; for instance if you use it for the very first time it
knows
On Thu, Dec 29, 2011 at 11:03:43AM -0700, Aleksandr Andreev wrote:
Aha. Some Googling reveals that:
Exit code 137: The job was killed because it exceeded the time limit.
Don't top-post.
Any ideas how to up the time limit?
Unless you have an incredibly under-powered computer (say, 10
years
Phil,
I ran it again this morning on the latest source from git pull, and I
get the same message. There is no notice in the relevant log file of
any failed files, so it doesn't appear to be a syntax error.
In fact, it looks like the relevant command runs, but for some reason
make test still
Graham Percival gra...@percival-music.ca writes:
On Thu, Dec 29, 2011 at 11:03:43AM -0700, Aleksandr Andreev wrote:
Aha. Some Googling reveals that:
Exit code 137: The job was killed because it exceeded the time limit.
Don't top-post.
Any ideas how to up the time limit?
Unless you have
The last batch of the year, for 20:00 MST Saturday December 31, 2011
Documentation:
Issue 2137
http://code.google.com/p/lilypond/issues/detail?id=2137: Patch: Doc:
NR improve 'visibility' of 'q' operation - R 5489118
http://codereview.appspot.com/5489118/
Enhancement:
Issue 2149
http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc
File lily/lily-guile.cc (right):
http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc#newcode574
lily/lily-guile.cc:574: if (o = 0)
gcc gives a warning that this test is always true.
'o' is type vsize which is a
http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc
File lily/lily-guile.cc (right):
http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc#newcode573
lily/lily-guile.cc:573: o = scm_to_int (k);
shouldn't it be
int i = scm_to_int (k)
if (i = 0)
return
I am interested in getting a new stable release of LilyPond out, so I want to
work on Critical issues.
There are 3 critical issues, all of which will require changes to GUB in order
to fix them.
I know nothing about GUB, but I can see that the lack of GUB knowledge is
preventing a release
More information: When I ran the command by hand, I got this message:
carl@carl-lilydev:~/gub/target/darwin-ppc/build/cross/gcc-4.1.1$ make
tooldir='/usr/powerpc-apple-darwin7' gcc_tooldir='/usr/powerpc-apple-darwin7'
make[1]: Entering directory
More info:
It looks like I have powerpc-apple-darwin7/bin/ar
Do I have something wrong with the makefile that's giving it a bad name for the
link command?
Thanks,
Carl
___
lilypond-devel mailing list
lilypond-devel@gnu.org
LGTM
Thanks,
Carl
http://codereview.appspot.com/5500093/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Fri, Dec 30, 2011 at 06:12:58AM +, Carl Sorensen wrote:
More information: When I ran the command by hand, I got this message:
carl@carl-lilydev:~/gub/target/darwin-ppc/build/cross/gcc-4.1.1$ make
tooldir='/usr/powerpc-apple-darwin7' gcc_tooldir='/usr/powerpc-apple-darwin7'
Be aware
On Fri, Dec 30, 2011 at 06:05:17AM +, Carl Sorensen wrote:
I am interested in getting a new stable release of LilyPond out, so I want to
work on Critical issues.
Great! We have definitely suffered from having those critical
issues.
There are 3 critical issues, all of which will require
LGTM
http://codereview.appspot.com/5489118/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
29 matches
Mail list logo
