Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-02 Thread dak
On 2012/01/01 22:06:52, Keith wrote: On 2012/01/01 10:12:27, dak wrote: Sorry, I wasn't making much sense. As a reader I want to *recognize* what the but switch/case is doing rather than trying to figure it out. Maybe : // Test if these bytes are a UTF-8 encoding of a Unicode character,

Re: PATCH: Countdown to 20120103

2012-01-02 Thread James
hello, On 2 January 2012 04:53, Colin Campbell c...@shaw.ca wrote: For 20:00 MST Tuesday January 3rd, 2012     Issue 2162: Patch: Doc: NR added @knownissue for beam properties - R 5504100 There's still discussion on this. @keith and @carl, I see Keith has done something specific for

Modifies broken hairpin height (issue 5502089)

2012-01-02 Thread janek . lilypond
LGTM http://codereview.appspot.com/5502089/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

LSR updates (again)

2012-01-02 Thread Phil Holmes
OK - I'm having another go at getting the LSR updates into git. Graham's recommended method for this (which I will add to the CG) is to run makelsr locally, with no downloaded updates - this simply aligns git with any changes makelsr automatically makes. Attached is a patch after this

Re: LSR updates (again)

2012-01-02 Thread David Kastrup
Phil Holmes em...@philholmes.net writes: OK - I'm having another go at getting the LSR updates into git. Graham's recommended method for this (which I will add to the CG) is to run makelsr locally, with no downloaded updates - this simply aligns git with any changes makelsr automatically

Re: LSR updates (again)

2012-01-02 Thread m...@apollinemike.com
On Jan 2, 2012, at 12:56 PM, David Kastrup wrote: Phil Holmes em...@philholmes.net writes: OK - I'm having another go at getting the LSR updates into git. Graham's recommended method for this (which I will add to the CG) is to run makelsr locally, with no downloaded updates - this simply

Updates makelsr to point to lilypond exe (issue 5489134)

2012-01-02 Thread PhilEHolmes
Reviewers: percivall, Message: Please review Description: The CG discussing makelsr says Make sure that convert-ly and lilypond commands in current PATH are in a bleeding edge version but in practice the it constructs a path to convert-ly, but not to the lilypond exe. The only indication that

Re: syntax highlighting in the docs (issue 1005)

2012-01-02 Thread Federico Bruni
Il 31/12/2011 02:44, Graham Percival ha scritto: On Thu, Dec 29, 2011 at 12:22:17PM +0100, Federico Bruni wrote: I have a final draft (see files attached): I'm quite happy with this version. Given my time constraints, I am happy to trust you. I fully expect that you'll get complaints

Re: T2026: Use new (scm markup-facility-defs) scheme module for markup commands. (issue 5464045)

2012-01-02 Thread dak
http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly#newcode31 ly/music-functions-init.ly:31: %% need (scm markup-facility-defs)for markup? Wasn't this

Re: LSR updates (again)

2012-01-02 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Monday, January 02, 2012 11:56 AM Subject: Re: LSR updates (again) Phil Holmes em...@philholmes.net writes: OK - I'm having another go at getting the LSR updates into git. Graham's recommended

Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-01-02 Thread Carl . D . Sorensen
LGTM http://codereview.appspot.com/5507050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Encoding of LilyPond console output

2012-01-02 Thread David Kastrup
David Kastrup d...@gnu.org writes: I am indeed top-posting. URL:http://code.google.com/p/lilypond/issues/detail?id=2173 Wilbert Berendsen wbs...@xs4all.nl writes: Everything boils down to the question in which encoding the 8bit console output of LilyPond is presented. I was always assuming

Re: PATCH: Countdown to 20120103

2012-01-02 Thread Keith OHara
On Mon, 02 Jan 2012 02:41:25 -0800, James pkx1...@gmail.com wrote: @keith and @carl, I see Keith has done something specific for \hidenotes in another patch. Should I use this Tracker (1566) as the Document issue for the @knowissue or for whatever else needs to bedone 'codewise' Let the

critical issues

2012-01-02 Thread David Kastrup
I see the following critical issues: 2160document LILYPOND_WEB_MEDIA_GIT 2100Patch: CG: explanation of branches for the impatient 1948Windows install clobbered system PATH 1943lilypond after 2.15.8 fails on x86 Macs 1933Lilypond-book requires msvcrt again 1933, 1943, 1948

Re: critical issues

2012-01-02 Thread Graham Percival
On Mon, Jan 02, 2012 at 09:59:47PM +0100, David Kastrup wrote: I see the following critical issues: -snip- There is, actually, a wagonload of other changes underfoot that does not appear quite compatible with releasing a version called stable to me. It seems strange to me that the _above_

Re: Updates makelsr to point to lilypond exe (issue 5489134)

2012-01-02 Thread graham
great idea! A few implementation quibbles, though. http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py File scripts/auxiliar/makelsr.py (right): http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py#newcode76 scripts/auxiliar/makelsr.py:76:

Re: LSR updates (again)

2012-01-02 Thread Graham Percival
On Mon, Jan 02, 2012 at 11:50:07AM -, Phil Holmes wrote: I'd like to push this to staging, but would appreciate someone else (David, Graham?) looking at it just to check. I'd prefer not to go to a Rietveld for this simple change. LGTM. Cheers, - Graham

Re: T2026: Use new (scm markup-facility-defs) scheme module for markup commands. (issue 5464045)

2012-01-02 Thread ianhulin44
I've had to do some major mangling with my local git rep, so the next patch-set is coming up as a new Rietveld issue. It's http://codereview.appspot.com/5504107 Will also update Google tracker. Ian http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly File

Doc: NR added internal ledger lines (1935) (issue 5480057)

2012-01-02 Thread graham
LGTM http://codereview.appspot.com/5480057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Removes ugly side bars from learning (issue 5498089)

2012-01-02 Thread graham
could we get those @* turned into @example ? Just grit your teeth and ignore the yellow boxes for now? If you want to add a comment to remind us to change the @example when we have a better way of doing this, go ahead. http://codereview.appspot.com/5498089/

Re: critical issues

2012-01-02 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Mon, Jan 02, 2012 at 09:59:47PM +0100, David Kastrup wrote: I see the following critical issues: -snip- There is, actually, a wagonload of other changes underfoot that does not appear quite compatible with releasing a version called

Re: Doc: LM adjusted explanation for \once (issue 5489129)

2012-01-02 Thread graham
LGTM http://codereview.appspot.com/5489129/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T2026: Use new (scm markup-facility-defs) scheme module for markup commands. (issue 5464045)

2012-01-02 Thread dak
http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly#newcode31 ly/music-functions-init.ly:31: %% need (scm markup-facility-defs)for markup? On 2012/01/02

Re: critical issues

2012-01-02 Thread Graham Percival
On Mon, Jan 02, 2012 at 10:23:28PM +0100, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: This was the result of between 25 to 40 emails in August 2011 on lilypond-devel. A quick scan didn't reveal your name amongst those emails, but we simply cannot afford to

Re: Sketch of not remaking html files (issue 5498093)

2012-01-02 Thread graham
a few minor quibbles; I'm on a ferry right now so I can't test a full doc build. http://codereview.appspot.com/5498093/diff/1/GNUmakefile.in File GNUmakefile.in (right): http://codereview.appspot.com/5498093/diff/1/GNUmakefile.in#newcode125 GNUmakefile.in:125: # find $(outdir) -name '*-root' |

Re: T2026: Use new (scm markup-facility-defs) scheme module for markup commands. (issue 5464045)

2012-01-02 Thread Ian Hulin
Hi David, On 02/01/12 21:33, d...@gnu.org wrote: http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly#newcode31 ly/music-functions-init.ly:31: %%

Re: critical issues

2012-01-02 Thread Janek Warchoł
2012/1/2 Graham Percival gra...@percival-music.ca: On Mon, Jan 02, 2012 at 10:23:28PM +0100, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: This was the result of between 25 to 40 emails in August 2011 on lilypond-devel.  A quick scan didn't reveal your name amongst

Re: critical issues

2012-01-02 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Mon, Jan 02, 2012 at 10:23:28PM +0100, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: This was the result of between 25 to 40 emails in August 2011 on lilypond-devel. A quick scan didn't reveal your name amongst

Re: critical issues

2012-01-02 Thread Graham Percival
On Tue, Jan 03, 2012 at 01:03:08AM +0100, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: We could certainly consider dropping support for OSX or windows. That sort of token solidarity is actually counterproductive: if you believe that non-releases lead to non-users,

Re: Segfault 2.15.23 Span_bar_stub_engraver

2012-01-02 Thread Keith OHara
mike at apollinemike.com mike at apollinemike.com writes: Some meh news: I don't get a segfault ... Maybe someone else could give it a look? I can't produce the segfault, either. Jay Anderson horndude77 at gmail.com writes: Removing the Span_bar_stub_engraver from my PianoStaff fixes the

Re: GUB Build Success!

2012-01-02 Thread Carl Sorensen
Graham Percival graham at percival-music.ca writes: On Sun, Jan 01, 2012 at 08:43:05PM +, Carl Sorensen wrote: I have made one change to the spec files (the location of netpm on lilypond.org has changed), and I did a couple of manual downloads, so I'm not sure yet that GUB is ready

Re: Segfault 2.15.23 Span_bar_stub_engraver

2012-01-02 Thread Jay Anderson
On Mon, Jan 2, 2012 at 6:41 PM, Keith OHara k-ohara5...@oco.net wrote: mike at apollinemike.com mike at apollinemike.com writes: Some meh news: I don't get a segfault ... Maybe someone else could give it a look? I can't produce the segfault, either. Strange I can consistently reproduce it

Re: Segfault 2.15.23 Span_bar_stub_engraver

2012-01-02 Thread Keith OHara
Jay Anderson horndude77 at gmail.com writes: On Mon, Jan 2, 2012 at 6:41 PM, Keith OHara k-ohara5a5a at oco.net wrote: I can't produce the segfault, either. Strange I can consistently reproduce it (just pulled the latest and recompiled): Ubuntu 11.10, gcc 4.6.1. If you have *only* seen

Re: GUB Build Success!

2012-01-02 Thread Graham Percival
On Tue, Jan 03, 2012 at 04:15:06AM +, Carl Sorensen wrote: Graham Percival graham at percival-music.ca writes: [*] after installing libmpfr-dev, which is mentioned in the README. In looking at my notes, it appears that I may have failed on my lilydev install because I didn't install

Re: critical issues

2012-01-02 Thread Janek Warchoł
2012/1/3 David Kastrup d...@gnu.org: I am afraid that we are painting ourselves into a corner.  And I don't think that we are doing ourselves a favor by defining stable as a random moment when somebody managed to get GUB to run for Windows and OSX.  We should define stable based on the

Re: critical issues

2012-01-02 Thread Janek Warchoł
(sorry for double-post) 2012/1/2 Graham Percival gra...@percival-music.ca: On Mon, Jan 02, 2012 at 10:23:28PM +0100, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: If you are aware of any other issues which fall under the definition (i.e. a reproducible failure to

Re: critical issues

2012-01-02 Thread Graham Percival
On Tue, Jan 03, 2012 at 06:24:19AM +0100, Janek Warchoł wrote: By the way, do we have a policy about regressions? Yes, they're bad? :) I remember that reverting bad commits was discussed in the past, and i'm quite for this solution. I don't see information about which commits caused our

Re: critical issues

2012-01-02 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Tue, Jan 03, 2012 at 01:03:08AM +0100, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: We could certainly consider dropping support for OSX or windows. That sort of token solidarity is actually counterproductive: