Re: Overhauls broken bound coordinate checking (issue 5602054)

2012-02-04 Thread k-ohara5a5a
LFTM http://codereview.appspot.com/5602054/diff/6003/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5602054/diff/6003/lily/axis-group-interface.cc#newcode114 lily/axis-group-interface.cc:114: SCM forbidden_interfaces = me-get_property

Re: Overhauls broken bound coordinate checking (issue 5602054)

2012-02-04 Thread k-ohara5a5a
Dumping 'bound-alignment-forbidden-interfaces and the changes to axis-group-interface.cc, in favor of a 'bound-alignment-interfaces for NonMusicalPaperColumn, works for me. It restores that one regression test 'text-spanner-full-rest.ly'. http://codereview.appspot.com/5602054/

Re: failure rewriting Patchy

2012-02-04 Thread David Kastrup
Janek Warchoł janek.lilyp...@gmail.com writes: Dear developers, i hoped to rewrite Patchy to make it more robust, user-friendly and solve problems that David experienced with his fix for 2240; unfortunately it turned out that i'm not experienced enough to do this. After 50 hours of

Re: failure rewriting Patchy

2012-02-04 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Saturday, February 04, 2012 10:25 AM Subject: Re: failure rewriting Patchy Janek Warchoł janek.lilyp...@gmail.com writes: Dear developers, i hoped to rewrite Patchy to make it more robust,

Re: failure rewriting Patchy

2012-02-04 Thread David Kastrup
Phil Holmes m...@philholmes.net writes: I've got a couple of weeks off college now and could look at this. My knowledge of python is small and git even smaller, but would be happy to make changes and test them. Would clearly need the help of the people who know what they're doing, tho'.

Re: failure rewriting Patchy

2012-02-04 Thread Graham Percival
On Sat, Feb 04, 2012 at 11:57:24AM +0100, David Kastrup wrote: Phil Holmes m...@philholmes.net writes: I've not looked at the attached file, but what were you trying to do and what caused problems, Jan? a) git management. test-patches.py basically takes whatever state its reference

Directs lilypond option help to stderr (issue 5625052)

2012-02-04 Thread PhilEHolmes
Reviewers: dak, Graham Percival, Message: Please review minor change. Description: The regtest option-help.ly prints out the help string for ly:set-option, with the intention of making this testable via logfile comparison. However, it sends the output to stdout, so it appears on the terminal

loglevels.ly

2012-02-04 Thread Phil Holmes
The regtest loglevels.ly sends the following 2 lines to stdout: Message functions of the Input class: Message functions in the warn.hh file: It does this with the following syntax: #(display \nMessage functions of the Input class:\n) I'm assuming it's another that should go to stderr but

Re: lily-git.tcl and git clone

2012-02-04 Thread Jean-Charles Malahieude
Le 31/01/2012 14:21, David Kastrup disait : David Kastrupd...@gnu.org writes: Graham Percivalgra...@percival-music.ca writes: The updated CG instructions for setting up git manually specify to use clone: http://lilypond.org/doc/v2.15/Documentation/contributor/setting-up but the latest

Re: lily-git.tcl and git clone

2012-02-04 Thread Graham Percival
On Sat, Feb 04, 2012 at 02:14:56PM +0100, Jean-Charles Malahieude wrote: * git clone learned --single-branch option to limit cloning to a single branch (surprise!). This might change things end be quite useful! Thanks for the news, but in this case it's actually the opposite: we _want_

Directs output from identifier-foll*.ly to stderr (issue 5624050)

2012-02-04 Thread PhilEHolmes
Reviewers: dak, Graham Percival, Message: Please review. Description: identifier-following-chordmode.ly sends a load of output to stdout - i.e. the terminal. This sends it to stderr - i.e. the logifles. Please review this at http://codereview.appspot.com/5624050/ Affected files: M

Re: Directs output from identifier-foll*.ly to stderr (issue 5624050)

2012-02-04 Thread Phil Holmes
- Original Message - From: philehol...@googlemail.com To: d...@gnu.org; gra...@percival-music.ca Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org Sent: Saturday, February 04, 2012 2:40 PM Subject: Directs output from identifier-foll*.ly to stderr (issue 5624050)

Staging-master

2012-02-04 Thread Phil Holmes
I'll run patchy in an hour or so to update master from staging. If anyone has this in progress, please shout. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Directs lilypond option help to stderr (issue 5625052)

2012-02-04 Thread dak
On 2012/02/04 12:45:23, PhilEHolmes wrote: Please review minor change. If we have a Scheme function for printing, the output should not be hardwired to a non-Scheme port, whether that be stderr or stdout. I think I mentioned as much. I'll push a reimplementation to staging in the next half

Re: Directs output from identifier-foll*.ly to stderr (issue 5624050)

2012-02-04 Thread dak
On 2012/02/04 14:52:45, mail_philholmes.net wrote: - Original Message - From: mailto:philehol...@googlemail.com To: d...@gnu.org; mailto:gra...@percival-music.ca Cc: re...@codereview-hr.appspotmail.com; mailto:lilypond-devel@gnu.org Sent: Saturday, February 04, 2012 2:40 PM Subject:

Re: Staging-master

2012-02-04 Thread David Kastrup
Phil Holmes em...@philholmes.net writes: I'll run patchy in an hour or so to update master from staging. If anyone has this in progress, please shout. Why? It is not like there is any harm in parallel update processes. The worst that can happen is nothing. There is no need to coordinate

Re: Staging-master

2012-02-04 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Saturday, February 04, 2012 3:14 PM Subject: Re: Staging-master Phil Holmes em...@philholmes.net writes: I'll run patchy in an hour or so to update master from staging. If anyone has this in

Re: Directs output from identifier-foll*.ly to stderr (issue 5624050)

2012-02-04 Thread Phil Holmes
- Original Message - From: d...@gnu.org To: philehol...@googlemail.com; gra...@percival-music.ca; m...@philholmes.net Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Saturday, February 04, 2012 3:11 PM Subject: Re: Directs output from identifier-foll*.ly to stderr

Re: Directs output from identifier-foll*.ly to stderr (issue 5624050)

2012-02-04 Thread dak
On 2012/02/04 15:35:28, mail_philholmes.net wrote: - Original Message - From: mailto:d...@gnu.org To: philehol...@googlemail.com; gra...@percival-music.ca; mailto:m...@philholmes.net Cc: lilypond-devel@gnu.org; mailto:re...@codereview-hr.appspotmail.com Sent: Saturday, February 04,

Re: Directs lilypond option help to stderr (issue 5625052)

2012-02-04 Thread dak
On 2012/02/04 15:08:33, dak wrote: On 2012/02/04 12:45:23, PhilEHolmes wrote: Please review minor change. If we have a Scheme function for printing, the output should not be hardwired to a non-Scheme port, whether that be stderr or stdout. I think I mentioned as much. I'll push a

Re: Staging-master

2012-02-04 Thread David Kastrup
Phil Holmes m...@philholmes.net writes: - Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Saturday, February 04, 2012 3:14 PM Subject: Re: Staging-master Phil Holmes em...@philholmes.net writes: I'll run patchy in an hour or so to update

Re: Staging-master

2012-02-04 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes m...@philholmes.net I don't think that we are in the situation where we have to fear for our environment because of too many people actually doing what they said they'll do. -- David Kastrup :-) -- Phil Holmes

Re: failure rewriting Patchy

2012-02-04 Thread Janek Warchoł
2012/2/4 David Kastrup d...@gnu.org: Phil Holmes m...@philholmes.net writes: what were you trying to do and what caused problems, Jan? I was trying to completely rewrite Patchy. Graham's implementation seemed too complicated to me. I've not looked at the attached file, I have not looked

Re: failure rewriting Patchy

2012-02-04 Thread David Kastrup
Janek Warchoł janek.lilyp...@gmail.com writes: 2012/2/4 David Kastrup d...@gnu.org: Phil Holmes m...@philholmes.net writes: what were you trying to do and what caused problems, Jan? I was trying to completely rewrite Patchy. Graham's implementation seemed too complicated to me. I've not

Directs regtest output for last 2 files to stderr (issue 5625053)

2012-02-04 Thread PhilEHolmes
Reviewers: dak, Graham Percival, Message: Please review. Description: 2 further regtests that send output to stdout as opposed to stderr. Updated to send the output to stderr. This is the last of this series of patches. Please review this at http://codereview.appspot.com/5625053/ Affected

Re: Directs regtest output for last 2 files to stderr (issue 5625053)

2012-02-04 Thread dak
On 2012/02/04 16:39:00, PhilEHolmes wrote: Please review. I am not actually sure that we should not for the regtests divert current-output-port generally to current-error-port and be done without all those fixups. Of course, this will still need to cater for those parts of the code that

Re: Directs lilypond option help to stderr (issue 5625052)

2012-02-04 Thread PhilEHolmes
See new description. Please review. http://codereview.appspot.com/5625052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Directs lilypond option help to stderr (issue 5625052)

2012-02-04 Thread dak
On 2012/02/04 17:34:09, PhilEHolmes wrote: See new description. Please review. Well, obviously correct, but it will still require one pass of the staging patchy before the testing patchy will be happy with it. So depending on who runs which Patchy when, this might take some time to get the

Re: Directs lilypond option help to stderr (issue 5625052)

2012-02-04 Thread Phil Holmes
- Original Message - From: d...@gnu.org To: philehol...@googlemail.com; gra...@percival-music.ca Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org Sent: Saturday, February 04, 2012 5:40 PM Subject: Re: Directs lilypond option help to stderr (issue 5625052) On 2012/02/04

Gets vertical skylines from grob stencils (issue 5626052)

2012-02-04 Thread mtsolo
Reviewers: , Message: Sorry in advance for the whitespace errors. This patch provides a generic framework for building vertical skylines out of boxes by traversing through a stencil. It currently only implements skylines for three stencil types (draw-line, named-glyph, and glyph-string) and

Build: website should rely on $LILYPOND_GIT (issue 5630055)

2012-02-04 Thread julien . rioux
Curious about... http://codereview.appspot.com/5630055/diff/2001/Documentation/contributor/website-work.itexi File Documentation/contributor/website-work.itexi (left): http://codereview.appspot.com/5630055/diff/2001/Documentation/contributor/website-work.itexi#oldcode270

Re: Build: website should rely on $LILYPOND_GIT (issue 5630055)

2012-02-04 Thread Graham Percival
On Sat, Feb 04, 2012 at 11:10:51PM +, julien.ri...@gmail.com wrote: Documentation/contributor/website-work.itexi:270: make -f website.make WEBSITE_ONLY_BUILD=1 -B website If we leave -B here, does it fix issue 2251? That's not the issue; once I'd boiled down the instructions and tested

Unbound variable GUILE error when no whitespace before closing brace

2012-02-04 Thread James
Hello, Just investigating some old Tracker issues I came across that \new Staff \with { \override StaffSymbol #'staff-space = #0.9 } \relative { \times 2/3 { d16[ d16 d16] } } compiles but \new Staff \with { \override StaffSymbol #'staff-space = #0.9} \relative { \times 2/3 { d16[ d16

Re: Unbound variable GUILE error when no whitespace before closing brace

2012-02-04 Thread David Kastrup
James pkx1...@gmail.com writes: Hello, Just investigating some old Tracker issues I came across that \new Staff \with { \override StaffSymbol #'staff-space = #0.9 } \relative { \times 2/3 { d16[ d16 d16] } } compiles but \new Staff \with { \override StaffSymbol #'staff-space =

Re: Unbound variable GUILE error when no whitespace before closing brace

2012-02-04 Thread James
Hello, On 5 February 2012 07:30, David Kastrup d...@gnu.org wrote: ... The variable is not } but 0.9} instead.  Anything that can't be parsed as a constant in Scheme is a variable. This has nothing to do with Lilypond: dak@lola:/usr/local/tmp/lilypond$ guile guile 0.9} ERROR: Unbound