Re: Email from Phil's patchy

2012-07-29 Thread David Kastrup
Phil Holmes m...@philholmes.net writes: Sorry, Marc. To do this completely, you will need to add the changed file to snippets/new. The files in snippets get over-written when we import from the LSR, so this update would be lost. However, to make current git compile, you do also need to

Re: Email from Phil's patchy

2012-07-29 Thread Marc Hohl
Am 29.07.2012 08:12, schrieb David Kastrup: Phil Holmes m...@philholmes.net writes: Sorry, Marc. To do this completely, you will need to add the changed file to snippets/new. The files in snippets get over-written when we import from the LSR, so this update would be lost. However, to make

Re: Email from Phil's patchy

2012-07-29 Thread Marc Hohl
Am 29.07.2012 10:10, schrieb David Kastrup: Marc Hohl m...@hohlart.de writes: Am 29.07.2012 08:12, schrieb David Kastrup: Phil Holmes m...@philholmes.net writes: Sorry, Marc. To do this completely, you will need to add the changed file to snippets/new. The files in snippets get

Re: LilyPond developeruser meeting in Waltrop, August 24th to 28th

2012-07-29 Thread David Kastrup
Rodolfo Zitellini xhero...@gmail.com writes: Hi All! is the meeting open to all users? Yes. We need to keep track of the head count and have to cater for accommodation/food accordingly, but that does not seem like much of a problem right now. I would be very interested in coming, as I would

Re: Patchy email

2012-07-29 Thread Marc Hohl
Am 28.07.2012 14:08, schrieb David Kastrup: [...] One thing that occured to me is that this contains a whole lot of public functions without any DOC string. No idea whether this might cause a problem for the documentation run, but it certainly is not much of a help for humans understanding the

Re: Email from Phil's patchy

2012-07-29 Thread David Kastrup
Marc Hohl m...@hohlart.de writes: Am 29.07.2012 10:10, schrieb David Kastrup: Now it is true that we probably did not have a formal discussion of this in any rate, and you are probably quite keeping with some sort of de-facto standard and are in the unlucky position of standing next when I

Re: Patchy email

2012-07-29 Thread David Kastrup
Marc Hohl m...@hohlart.de writes: Am 28.07.2012 14:08, schrieb David Kastrup: [...] One thing that occured to me is that this contains a whole lot of public functions without any DOC string. No idea whether this might cause a problem for the documentation run, but it certainly is not much

Re: Email from Phil's patchy

2012-07-29 Thread Marc Hohl
Am 29.07.2012 11:16, schrieb David Kastrup: Marc Hohl m...@hohlart.de writes: Am 29.07.2012 10:10, schrieb David Kastrup: Now it is true that we probably did not have a formal discussion of this in any rate, and you are probably quite keeping with some sort of de-facto standard and are in

Re: GOP2-3 - GLISS or not

2012-07-29 Thread David Kastrup
Han-Wen Nienhuys hanw...@gmail.com writes: On Tue, Jul 24, 2012 at 6:09 AM, Graham Percival gra...@percival-music.ca wrote: This summer hasn't been going as I'd hoped -- heh, who am I kidding, this whole year hasn't been going as I'd hoped. Anyway, we seem to have radically different

Re: Syntax change: REAL requires at least one digit before decimal point (issue 6446048)

2012-07-29 Thread k-ohara5a5a
This looks nice. Cleaner code, and continues to accept -.3\cm, for now. http://codereview.appspot.com/6446048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Set indent based on instrument name (issue 6457049)

2012-07-29 Thread PhilEHolmes
Reviewers: dak, Graham Percival, Message: My first attempt at coding in LilyPond. Treat me gently... Description: An attempt to set the line indent based upon the instrument name. The simple use of instrumentName.length() to add to the indent seems odd, but works in practice. Not tested with

Re: Issue 2702 in lilypond: Patch: Unify the lexer's idea of words and commands across all modes.

2012-07-29 Thread David Kastrup
Forwarding this from the lilypond-auto list since this review concerns an important syntax change. GLISS material, in a manner. Consider it a proposal for word and command syntax across _all_ lexer modes. Reasonably simple, and somewhat surprisingly not requiring any changes in the entire .ly

Re: Issue 2702 in lilypond: Patch: Unify the lexer's idea of words and commands across all modes.

2012-07-29 Thread Graham Percival
On Sun, Jul 29, 2012 at 10:15:10PM +0200, David Kastrup wrote: Forwarding this from the lilypond-auto list since this review concerns an important syntax change. GLISS material, in a manner. Consider it a proposal for word and command syntax across _all_ lexer modes. What's a lexer mode ?

Re: Set indent based on instrument name (issue 6457049)

2012-07-29 Thread Phil Holmes
- Original Message - From: d...@gnu.org To: philehol...@googlemail.com; gra...@percival-music.ca Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Sunday, July 29, 2012 9:16 PM Subject: Re: Set indent based on instrument name (issue 6457049) On 2012/07/29 18:20:16,

Re: Issue 2702 in lilypond: Patch: Unify the lexer's idea of words and commands across all modes.

2012-07-29 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Sun, Jul 29, 2012 at 10:15:10PM +0200, David Kastrup wrote: Forwarding this from the lilypond-auto list since this review concerns an important syntax change. GLISS material, in a manner. Consider it a proposal for word and command

Re: Set indent based on instrument name (issue 6457049)

2012-07-29 Thread David Kastrup
Phil Holmes em...@philholmes.net writes: - Original Message - From: d...@gnu.org To: philehol...@googlemail.com; gra...@percival-music.ca Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Sunday, July 29, 2012 9:16 PM Subject: Re: Set indent based on instrument

Re: Set indent based on instrument name (issue 6457049)

2012-07-29 Thread David Kastrup
David Kastrup d...@gnu.org writes: Phil Holmes em...@philholmes.net writes: - Original Message - From: d...@gnu.org To: philehol...@googlemail.com; gra...@percival-music.ca Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Sunday, July 29, 2012 9:16 PM

Re: Issue 2702 in lilypond: Patch: Unify the lexer's idea of words and commands across all modes.

2012-07-29 Thread David Kastrup
David Kastrup d...@gnu.org writes: Graham Percival gra...@percival-music.ca writes: On Sun, Jul 29, 2012 at 10:15:10PM +0200, David Kastrup wrote: Being able to access every definition equally well in every lexer mode is also an advantage. The word definition is palindromic: iff a