Re: Set indent based on instrument name (issue 6457049)

Hey Phil! First and foremost, congrats on this work. I'm thrilled to see you venturing into the C++ side. You're tackling an issue that, while just a few lines of code, uses a lot of advanced LilyPond structures, so it's not easy. My suggestions don't have to do with the math (all of it is fin

Re: [Lilypond-auto] Issue 1320 in lilypond: Enhancement: user-customizable barlines through a Scheme interface.

to 20120731, please push. Pushed as a1b73185eae2f07dfee3cfcac0a6f11a15075ffe to staging. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Patchy email

04:35:11 (UTC) Begin LilyPond compile, previous commit at 1c980a9906a7ea01b9f99487e75580f7232f2491 04:35:12 *** FAILED STEP *** merge from staging Command 'git branch test-master-lock origin/master' returned non-zero exit status 128 fatal: A branch named 'test-master-loc

Re: Syntax-question about nested functions/procedures

Thomas Morley writes: > Hi, > > fiddling around with a new patch for issue 2646 I tried to integrate > default-parenthesize into another function. > The following returns an error when uncommenting \override > Score.ParenthesesItem #'font-size = #0 and applying it to an > articulation. > > \versi

PATCH: Countdown to 20120812

For 21:00 MDT Thursday August 2 Documentation: Issue 2640 : doc enhancement for \headers - R 6456047 Enhancement: Issue 2705 : P

Doc: Clarify automatic beam setting (2701) (issue 6452072)

Reviewers: , Message: For Graham, really: http://codereview.appspot.com/6452072/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/6452072/diff/1/Documentation/notation/rhythms.itely#newcode2007 Documentation/notation/rh

Patchy email

22:35:09 (UTC) Begin LilyPond compile, previous commit at 1c980a9906a7ea01b9f99487e75580f7232f2491 22:35:09 *** FAILED STEP *** merge from staging Command 'git branch test-master-lock origin/master' returned non-zero exit status 128 fatal: A branch named 'test-master-loc

Re: GOP2-3 - GLISS or not

On 30/07/12 17:52, Graham Percival wrote: In general, yes. But some aspects of our syntax haven't been around for a long time -- footnotes, woodwind fingering, compound meters, etc. Do we have the best syntax for those? I mean, maybe David can figure out a way to allow us to write \compound

Syntax-question about nested functions/procedures

Hi, fiddling around with a new patch for issue 2646 I tried to integrate default-parenthesize into another function. The following returns an error when uncommenting \override Score.ParenthesesItem #'font-size = #0 and applying it to an articulation. \version "2.15.42" parenthesizeII = #(define-

Re: Changes make test to allow output to be reviewed in a browser (issue 6442068)

I'm extremely cautious about _removing_ the ps output, since that might break the regtest comparisons in GUB. Have you / could you test this? I'd be much happier if this patch created pngs *in addition* to ps. I don't think we need to worry about making the process 10% or even 20% slower. htt

Changes make test to allow output to be reviewed in a browser (issue 6442068)

Reviewers: Graham Percival, Message: Please review. Description: As the title says, really. To date, running make test creates only .ps files which it's difficult to check. This changes the output to .png, which means that collated-files.html can be opened by a browser and the reg tests checke

Re: Fwd: Using MSH Paris Nord server

Il giorno mar, 31/07/2012 alle 12.12 +0200, John Mandereau ha scritto: > I'm currently setting up the server with the default (OpenId), but I > don't mind changing it if there are strong wishes for the other option. Uh oh, OpenId login hits on the firewall (I haven't requested outgoing HTTPS conne

Re: Unify the lexer's idea of words and commands across all modes. (issue 6445056)

wrote Tuesday, July 31, 2012 11:52 AM >> http://codereview.appspot.com/6445056/diff/1/lily/lexer.ll#newcode390 >> lily/lexer.ll:390: {RESTNAME}/[-_] | >> Why is this trailing context added? I don't see >> what this would match that wouldn't be matched >> by the following line. > > Flex picks t

Re: Set indent based on instrument name (issue 6457049)

Graham Percival wrote Tuesday, July 31, 2012 4:41 PM > One slight quibble: if a user explicitly sets indent=1\cm, then I > think it's fair to let the instrument name go off the left-hand > side of the page. I agree. This probably means making the default for indent (and short-indent) to be call

Re: Problems with make test

On Tue, Jul 31, 2012 at 05:31:17PM +0100, Phil Holmes wrote: > - Original Message - From: "Graham Percival" > > >collated-files.html only shows the differences, not the actual > >files. Furthermore, these differences are calculated based on the > >.eps or something like that, and text is

Re: Patchy's built docs on the web

Il giorno mar, 31/07/2012 alle 17.08 +0100, Graham Percival ha scritto: > I suppose that something could go at the very bottom of that page, > but it's kind-of full already. If we _do_ add anything like that, > then we should thank GNU first and foremost, then google code, > then rietveld, then ms

Re: Problems with make test

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: "Devel" Sent: Tuesday, July 31, 2012 4:48 PM Subject: Re: Problems with make test On Tue, Jul 31, 2012 at 11:22:25AM +0100, Phil Holmes wrote: So I open collated-files.html, to find that there are no images to eyeba

Re: Patchy's built docs on the web

On Tue, Jul 31, 2012 at 05:51:17PM +0200, John Mandereau wrote: > All that said, I'd like to advertise that this server is provided by > http://www.mshparisnord.fr on lilypond.org in addition to the home page > of the server http://194.254.171.80. The Thanks pages on the former > website and docs n

Re: Patchy's built docs on the web

Il giorno mar, 31/07/2012 alle 16.27 +0100, Phil Holmes ha scritto: > I'm assuming that changes to patchy will make this an "opt-in" option - I > don't want to ftp megs of files from home whenever I run patchy... Sure. BTW my changes don't add support for upload with FTP/SSH/Rsync/whatever proto

Re: Problems with make test

On Tue, Jul 31, 2012 at 11:22:25AM +0100, Phil Holmes wrote: > So I open collated-files.html, to find that there are no images to > eyeball. The HTML expects PNG files, but very few are created (in > particular, the one I want...). collated-files.html only shows the differences, not the actual fil

Re: Set indent based on instrument name (issue 6457049)

On Tue, Jul 31, 2012 at 04:13:20PM +0100, Phil Holmes wrote: > - Original Message - From: "David Kastrup" > >So _how_ are you trying to accommodate? Increase indent until the > >instrument name fits wholly in the text width? Let it stick out > >somewhat? How much? > > Increase the inde

Re: Patchy's built docs on the web

- Original Message - From: "John Mandereau" To: "Lily devel" Sent: Tuesday, July 31, 2012 4:18 PM Subject: Patchy's built docs on the web When lilypond-patchy-staging.py a.k.a. Patchy succesfully builds on MSH Paris Nord server, it now puts the docs on http://194.254.171.80/lilypond

Patchy's built docs on the web

When lilypond-patchy-staging.py a.k.a. Patchy succesfully builds on MSH Paris Nord server, it now puts the docs on http://194.254.171.80/lilypond-web/master/ This is intended for use by all developers and contributors; I'm not sure whether it duplicates docs on kainhofer.com/~lilypond/, it depend

Re: Set indent based on instrument name (issue 6457049)

- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: Sent: Tuesday, July 31, 2012 3:40 PM Subject: Re: Set indent based on instrument name (issue 6457049) "Phil Holmes" writes: I can't actually help here since either problem description or what the patch is trying to

Re: Set indent based on instrument name (issue 6457049)

"Phil Holmes" writes: >> I can't actually help here since either problem description or what the >> patch is trying to achieve is utterly absent from the issue. >> >> http://code.google.com/p/lilypond/issues/detail?id=2703> >> >> "Set indent based on instrument name" is all that is described >> a

Re: Set indent based on instrument name (issue 6457049)

On Tue, Jul 31, 2012 at 03:47:42PM +0200, David Kastrup wrote: > Graham Percival writes: > > > I think this is a bit too far. Phil is trying to solve a > > long-standing *extremely* annoying bug for documentation writers > > which has not attracted much attention from "real" programmers. > > I

Re: Set indent based on instrument name (issue 6457049)

- Original Message - From: "David Kastrup" To: Sent: Tuesday, July 31, 2012 2:47 PM Subject: Re: Set indent based on instrument name (issue 6457049) Graham Percival writes: On Tue, Jul 31, 2012 at 02:14:17PM +0200, David Kastrup wrote: And if you think this is purely hypothetical

Re: Set indent based on instrument name (issue 6457049)

- Original Message - From: To: ; ; ; ; Cc: ; Sent: Tuesday, July 31, 2012 2:36 PM Subject: Re: Set indent based on instrument name (issue 6457049) http://codereview.appspot.com/6457049/diff/4001/lily/output-def.cc File lily/output-def.cc (right): http://codereview.appspot.com/645

Re: Set indent based on instrument name (issue 6457049)

Graham Percival writes: > On Tue, Jul 31, 2012 at 02:14:17PM +0200, David Kastrup wrote: >> And if you think this is purely hypothetical, check out >> Documentation/snippets/incipit.ly. > > David, thank you for identifying a specific problematic example. > >> There are exceptions to every rule.

Re: Set indent based on instrument name (issue 6457049)

http://codereview.appspot.com/6457049/diff/4001/lily/output-def.cc File lily/output-def.cc (right): http://codereview.appspot.com/6457049/diff/4001/lily/output-def.cc#newcode275 lily/output-def.cc:275: set_inst_name_len (Real long_inst_name_len, Real short_inst_name_len) Correct me if I am wrong

Re: Set indent based on instrument name (issue 6457049)

On Tue, Jul 31, 2012 at 02:14:17PM +0200, David Kastrup wrote: > And if you think this is purely hypothetical, check out > Documentation/snippets/incipit.ly. David, thank you for identifying a specific problematic example. > There are exceptions to every rule. But if you are calling for an > exc

Re: Set indent based on instrument name (issue 6457049)

On Tue, Jul 31, 2012 at 12:59:16PM +0200, David Kastrup wrote: > Graham Percival writes: > > > On Mon, Jul 30, 2012 at 11:44:28PM +0100, Bernard Hurley wrote: > >> On Mon, Jul 30, 2012 at 10:14:37PM +0100, Phil Holmes wrote: > >> > - Original Message - From: > >> >> lily/output-def.cc:38

Re: Set indent based on instrument name (issue 6457049)

"Phil Holmes" writes: >>> Question is - is it OK to modify my code to use statics, >> >> No. Even engravers at score level are running in parallel, like when >> using a \score markup or using the part combiner or quoting music and so >> on. Static variables just don't work in this setting. > >

Re: GOP2-3: GLISS (update 1)

On Tue, Jul 31, 2012 at 11:26:12AM +0100, Trevor Daniels wrote: > > Graham Percival wrote Monday, July 30, 2012 7:11 PM > > > \version "2.16.0" > > \score { ... > > \midi {} > > } > > Currently this code produces no pdf and, if \layout {} is > added, no titles. > > Was this an intentional sug

Re: Set indent based on instrument name (issue 6457049)

- Original Message - From: "David Kastrup" To: Sent: Tuesday, July 31, 2012 12:50 PM Subject: Re: Set indent based on instrument name (issue 6457049) "Phil Holmes" writes: - Original Message - From: "David Kastrup" To: Sent: Tuesday, July 31, 2012 12:04 PM Subject: Re:

Re: Set indent based on instrument name (issue 6457049)

"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: > Sent: Tuesday, July 31, 2012 12:04 PM > Subject: Re: Set indent based on instrument name (issue 6457049) > > >> "Phil Holmes" writes: >> >>> I'd be happy to change it if someone could suggest an improvement.

Re: Set indent based on instrument name (issue 6457049)

- Original Message - From: "David Kastrup" To: Sent: Tuesday, July 31, 2012 12:04 PM Subject: Re: Set indent based on instrument name (issue 6457049) "Phil Holmes" writes: I'd be happy to change it if someone could suggest an improvement. When I initially asked how this could be d

Re: Set indent based on instrument name (issue 6457049)

"Phil Holmes" writes: > I'd be happy to change it if someone could suggest an improvement. > When I initially asked how this could be done, Keith said: > > "Maybe each Instrument_name_engraver, one for each staff, could push > information to a central location" > > which does sound rather like a

Re: Set indent based on instrument name (issue 6457049)

Graham Percival writes: > On Mon, Jul 30, 2012 at 11:44:28PM +0100, Bernard Hurley wrote: >> On Mon, Jul 30, 2012 at 10:14:37PM +0100, Phil Holmes wrote: >> > - Original Message - From: >> >> lily/output-def.cc:38: Real long_name_len = 0.0; >> >> could these be class member variables ins

Re: Unify the lexer's idea of words and commands across all modes. (issue 6445056)

Reviewers: Trevor Daniels, Message: On 2012/07/31 08:47:53, Trevor Daniels wrote: Just a query really, to help my understanding. Trevor http://codereview.appspot.com/6445056/diff/1/lily/lexer.ll File lily/lexer.ll (right): http://codereview.appspot.com/6445056/diff/1/lily/lexer.ll#newco

Re: GOP2-3: GLISS (update 1)

Graham Percival wrote Monday, July 30, 2012 7:11 PM > ** Subset for first phase > > In greater detail: I’m suggesting that we have multiple rounds of > syntax stabilization. The proposed elements of current lilypond > notation which we will stabilize is captured by these two files: > > \version

Problems with make test

OK - my instrument names/indent patch breaks make test. Took me a while to find out why, but it's stem-length-estimation.ly, which crams a load of notes onto a single small page. I suspect that the indent set on the previous score is hanging over into this one, causing it to be unable to get

Re: Fwd: Using MSH Paris Nord server

Il giorno lun, 30/07/2012 alle 15.21 +0100, Graham Percival ha scritto: > Ok. I just want to emphasize that you could easily spend 20 hours > setting this up, but then have the response be "no, we prefer the > old system". I got it :-P > oh, logins just occurred to me. Can gerrit let people lo

Re: Patchy email

Il giorno mar, 31/07/2012 alle 09.45 +0100, Phil Holmes ha scritto: > From: > > 04:35:09 (UTC) Begin LilyPond compile, previous commit at > > 1c980a9906a7ea01b9f99487e75580f7232f2491 > > > > 04:35:11 Merged staging, now at: 1c980a9906a7ea01b9f99487e75580f7232f2491 > > 07:00:18 *** FAILED BUILD *

Unify the lexer's idea of words and commands across all modes. (issue 6445056)

Just a query really, to help my understanding. Trevor http://codereview.appspot.com/6445056/diff/1/lily/lexer.ll File lily/lexer.ll (right): http://codereview.appspot.com/6445056/diff/1/lily/lexer.ll#newcode390 lily/lexer.ll:390: {RESTNAME}/[-_] | Why is this trailing context added? I don't

Re: Patchy email

- Original Message - From: To: Cc: Sent: Tuesday, July 31, 2012 8:00 AM Subject: Patchy email 04:35:09 (UTC) Begin LilyPond compile, previous commit at 1c980a9906a7ea01b9f99487e75580f7232f2491 04:35:11 Merged staging, now at: 1c980a9906a7ea01b9f99487e75580f7232f2491 04:35:13 Succ

Re: Set indent based on instrument name (issue 6457049)

- Original Message - From: "Graham Percival" To: "Bernard Hurley" Cc: "Phil Holmes" ; ; ; ; Sent: Tuesday, July 31, 2012 12:12 AM Subject: Re: Set indent based on instrument name (issue 6457049) On Mon, Jul 30, 2012 at 11:44:28PM +0100, Bernard Hurley wrote: On Mon, Jul 30, 2012