Checks for recursive element behavior (issue 6943072)

2012-12-20 Thread mtsolo
Reviewers: , Message: Hey all, I'm ok w/ this on the countdown but can someone check out David's suspicion that this slows stuff down by O(n^3)? I definitely won't push this if it slows LilyPond down to a crawl. Cheers, MS Description: Checks for recursive element behavior Please review this

Re: Changes to Kievan documentation (issue 6865049)

2012-12-20 Thread pkx166h
authorAleksandr Andreev Fri, 30 Nov 2012 21:14:44 + (15:14 -0600) committerJames Lowe Fri, 21 Dec 2012 07:18:09 + (07:18 +) commit4c4c59acd68533e6ce152a13707027443f387897 https://codereview.appspot.com/6865049/ ___ lilypond-devel mailin

Re: Tablature: ignore minimumStretch to/from fret zero (issue 6944061)

2012-12-20 Thread Marc Hohl
Am 21.12.2012 08:01, schrieb gra...@percival-music.ca: Not really about this patch, but what happened to the plans for running scripts/auxiliar/fixscm.sh ? There were objections about the way emacs does the automatic formatting, and I am not sure how one can preformat stuff so that the script wi

Re: Documentation/GNUmakefile: Add dependencies for internals.texi (issue 6943053)

2012-12-20 Thread pkx166h
Johannes, I am not sure if you have push access. If not, send me a git formatted patch and I can push this for you. james https://codereview.appspot.com/6943053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/list

Re: Web: Added New Page Acknowledgements.itexi (issue 6948068)

2012-12-20 Thread graham
There might be some weirdness between having foo.itexi, @foo, and foo.html output. But as long as the 2-minute "make website" doesn't die, it's probably ok. https://codereview.appspot.com/6948068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Tablature: ignore minimumStretch to/from fret zero (issue 6944061)

2012-12-20 Thread graham
Not really about this patch, but what happened to the plans for running scripts/auxiliar/fixscm.sh ? it would be nice to get rid of those tabs. https://codereview.appspot.com/6944061/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://list

Dual license the files under mf/ using OFL. (issue 6970046)

2012-12-20 Thread graham
I suspect that the GNUMakefile.in will need .OFL to be added to the EXTRA_DIST. https://codereview.appspot.com/6970046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Web: Introduction.itexi - added new opera (issue 6946074)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6946074/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6940064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix \textLengthOn to work with 2.17 skylining (3032) (issue 6936060)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6936060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCH: Countdown to 20121223

2012-12-20 Thread Colin Campbell
For 20:00 MST Sunday December 23rd (What, you wanted a tryptophan-fulled countdown on Christmas Day? Bah, humbug, I say!) Crash: Issue 2990 : \RemoveEmptyStaves in StaffGroup context crashes - R 6943072

Re: Add note to manuals.html describing formats of manuals (Issue 2895) (issue 6867054)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6867054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Web: Easier editing - new URI for lyqi (issue 6947065)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6947065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Web: Updated sizes of PDFs and 'big' HTML links (issue 6949062)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6949062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Usage - fixed syntax for backend inc. example (issue 6938071)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6938071/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 1029: \thumb should behave like other fingerings (issue 6945047)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6945047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

New Catalan PO file for 'lilypond' (version 2.15.95)

2012-12-20 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Catalan team of translators. The file is available at: http://translationproject.org/latest/lilypond/ca.po (We can arrange things so tha

Re: Better alignment of MetronomeMark to MultiMeasureRest (issue 6972044)

2012-12-20 Thread mtsolo
Reviewers: Keith, Message: You're right...it was mostly out of laziness and desperation that I did the quick fix...it worked for a piece I was typesetting. I have a long plane ride on the 28th to fix this correctly. https://codereview.appspot.com/6972044/diff/1/lily/metronome-engraver.cc File

Re: Upgrading Python - why not bundle official 2.7 binaries?

2012-12-20 Thread m...@mikesolomon.org
On 20 déc. 2012, at 08:36, Jan Nieuwenhuizen wrote: > Ben Rudiak-Gould writes: > >> On Wed, Dec 19, 2012 at 1:43 AM, David Kastrup wrote: >>> "m...@mikesolomon.org" writes: ...it seems like the question is why we don't download the binaries directly and bundle them with LilyPon

Re: midi2ly failure

2012-12-20 Thread James
Ben, On 19 December 2012 10:03, Colin Hall wrote: > On Tue, Dec 18, 2012 at 06:39:09PM -0800, Ben Rudiak-Gould wrote: >> I rewrote midi.c in Python and tested it on the largest midi file in >> IMSLP [1]. On my laptop it takes about 200 ms instead of 50 ms to load >> the file, but that's a small f

Re: Latest commit breaks master

2012-12-20 Thread David Kastrup
James writes: > On 19 December 2012 22:58, James wrote: >> Hello, >> >> On 19 December 2012 22:54, David Kastrup wrote: >> >> >>> Thanks. By the way, is the 2-hourly run on right now? After fixing the >>> docs and getting a successful make doc run (big time hole), I pushed to >>> staging agai