Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

2013-02-17 Thread Keith OHara
On Sun, 17 Feb 2013 02:07:19 -0800, m...@mikesolomon.org wrote: On 16 févr. 2013, at 21:20, k-ohara5...@oco.net wrote: Best, of course, would be to find and repair the code that cannot handle zero-widths. We do not yet have the choice between "a bit better" and "best", merely "a bit better"

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

2013-02-17 Thread m...@mikesolomon.org
On 16 févr. 2013, at 21:20, k-ohara5...@oco.net wrote: > Best, of course, would be to find and repair the code that cannot handle > zero-widths. We do not yet have the choice between "a bit better" and > "best", merely "a bit better" or nothing. > One solution is to just allow 0-width buildings

Re: Clean up bar-line.scm some more (issue 7350044)

2013-02-17 Thread dak
On 2013/02/17 18:57:13, marc wrote: On 2013/02/17 18:51:23, dak wrote: > Remove unused variable LGTM, looks much more scheme-ish than before! Well, there is not a single set!, there _is_ a named let for building two lists in tandem (unfold does not work really for building more than one list

Re: Clean up bar-line.scm some more (issue 7350044)

2013-02-17 Thread marc
On 2013/02/17 18:51:23, dak wrote: Remove unused variable LGTM, looks much more scheme-ish than before! https://codereview.appspot.com/7350044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-de

Re: PATCH: Countdown to 20130219 - 19:00 GMT

2013-02-17 Thread Phil Holmes
Note that the patches marked as fixed but needing verifying can't be verified at present, since 2.17.13 has not been released. -- Phil Holmes - Original Message - From: James To: Devel Sent: Saturday, February 16, 2013 7:43 PM Subject: PATCH: Countdown to 20130219 - 19:00 G

Re: Avoid excessive number of dots in chords (#3179). (issue 7319049)

2013-02-17 Thread lemzwerg
Thanks for the review. https://codereview.appspot.com/7319049/diff/2001/lily/dot-column.cc File lily/dot-column.cc (right): https://codereview.appspot.com/7319049/diff/2001/lily/dot-column.cc#newcode63 lily/dot-column.cc:63: vector allowed_y_positions; On 2013/02/17 08:20:39, Keith wrote: It w

Re: [Lilypond-auto] Issue 3182 in lilypond: Patch: Defuse the obfuscated Scheme programming contest

2013-02-17 Thread David Kastrup
Marc Hohl writes: > If this erroneous use of reduce cannot be resolved quickly, it would > be best to raise an issue for this. I can't even judge if it is erroneous (namely leading to wrong results), and that's what makes it a problem. > Well, a do loop in scheme felt kinda weird, but map didn'

Re: Avoid excessive number of dots in chords (#3179). (issue 7319049)

2013-02-17 Thread k-ohara5a5a
This seems like the most reasonable place to remove extra dots. Dot_configuration has the job of arranging dots in a chord, but confines its efforts to the mathematical problem of keeping a set of integer position for dots close to a set of integer positions of noteheads. Looking at the resulting

Re: [Lilypond-auto] Issue 3182 in lilypond: Patch: Defuse the obfuscated Scheme programming contest

2013-02-17 Thread Marc Hohl
Am 16.02.2013 09:29, schrieb David Kastrup: Marc Hohl writes: Am 15.02.2013 14:02, schrieb lilyp...@googlecode.com: Status: Started Owner: d...@gnu.org Labels: Type-Enhancement Patch-new New issue 3182 by d...@gnu.org: Patch: Defuse the obfuscated Scheme programming contest http://code.googl

Re: Invert the meaning of instrumentTransposition again. (issue 7300086)

2013-02-17 Thread k-ohara5a5a
Looks and sounds fine to me. https://codereview.appspot.com/7300086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel