Re: Eliminates side poisition calculations for system-start-text grobs. (issue 7574048)

2013-03-18 Thread k-ohara5a5a
This will be nice. Notice that the Stanza number in 'input/regression/hara-kiri-stanza-number.ly' lost its alignment. https://codereview.appspot.com/7574048/diff/1/scm/define-grob-interfaces.scm File scm/define-grob-interfaces.scm (right): https://codereview.appspot.com/7574048/diff/1/scm/defin

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-18 Thread mtsolo
The most recent patch set copies direction from SlurEvents and PhrasingSlurEvents, but this doesn't seem to work as intended (it fails silently). Everything else is operational. https://codereview.appspot.com/7424049/ ___ lilypond-devel mailing list l

Re: alignment of unattached lyrics - opinions needed

2013-03-18 Thread Janek Warchoł
Hi, On Sat, Mar 16, 2013 at 9:36 AM, David Kastrup wrote: > Aligning lyrics at a point of time to notecolumns at the same point of time > should not require associating voices. On Sun, Mar 17, 2013 at 6:55 PM, Janek Warchoł wrote: > On Sun, Mar 17, 2013 at 2:38 PM, Trevor Daniels wrote: >> The

Add warning about using \relative with tagged music (3253) (issue 7798045)

2013-03-18 Thread dak
https://codereview.appspot.com/7798045/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/7798045/diff/1/Documentation/notation/input.itely#newcode2247 Documentation/notation/input.itely:2247: @end example That's \relative wi

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-18 Thread lemzwerg
https://codereview.appspot.com/7424049/diff/41001/input/regression/repeat-slur.ly File input/regression/repeat-slur.ly (right): https://codereview.appspot.com/7424049/diff/41001/input/regression/repeat-slur.ly#newcode10 input/regression/repeat-slur.ly:10: " This should be rather @code{\\breakSlu

a short explanation

2013-03-18 Thread Janek Warchoł
Hi, recently i've mixed several things together and made some mess. I apologize fo that. Below i explain the situation so that you won't be lost: Issue 3239 http://code.google.com/p/lilypond/issues/detail?id=3239 https://codereview.appspot.com/7768043 Previous versions of this patch contained s

Re: don't abort aligning when grob's parent is a PaperColumn (issue 7564044)

2013-03-18 Thread tdanielsmusic
On 2013/03/18 13:05:15, janek wrote: On 2013/03/18 10:36:35, Trevor Daniels wrote: > I can't easily test this, but on the basis of the > reg tests - LGTM Do you mean that i should improve the test file which is attached to tracker issue? Janek No, the test file looks fine. It's just th

report a programming error when trying to align on empty parent (issue 7533046)

2013-03-18 Thread janek . lilypond
Reviewers: dak, MikeSol, J_lowe, Message: This is the part of Issue 3239 that introduced additional programming errors. I hope that the explanation is clear. Of course there is one fundamental question: maybe we shouldn't complain about grobs with empty extents, and just silently assume that an

Re: Release process for 2.18 cancelled

2013-03-18 Thread David Kastrup
"Trevor Daniels" writes: > David Kastrup wrote Monday, March 18, 2013 11:14 AM > >> The way to do that is to bind people to their predictions of what can >> and cannot be achieved in a certain amount of time by agreeing on a >> timeline in advance and putting in deadlines for certain kinds of >>

Re: don't abort aligning when grob's parent is a PaperColumn (issue 7564044)

2013-03-18 Thread janek . lilypond
On 2013/03/18 10:36:35, Trevor Daniels wrote: I can't easily test this, but on the basis of the reg tests - LGTM Do you mean that i should improve the test file which is attached to tracker issue? Janek https://codereview.appspot.com/7564044/ ___ l

Re: Release process for 2.18 cancelled

2013-03-18 Thread Trevor Daniels
David Kastrup wrote Monday, March 18, 2013 11:14 AM > "Trevor Daniels" writes: > >> David Kastrup Monday, March 18, 2013 8:52 AM >>> >>> It turns out that the pent-up pressure to get forward-looking changes >>> into the master branch that have transitory user interfaces or extensive >>> chang

Re: Release process for 2.18 cancelled

2013-03-18 Thread David Kastrup
"Trevor Daniels" writes: > David Kastrup Monday, March 18, 2013 8:52 AM >> >> It turns out that the pent-up pressure to get forward-looking changes >> into the master branch that have transitory user interfaces or extensive >> changes of internals not exposed to sufficient testing is already too

Re: don't abort aligning when grob's parent is a PaperColumn (issue 7564044)

2013-03-18 Thread tdanielsmusic
I can't easily test this, but on the basis of the reg tests - LGTM https://codereview.appspot.com/7564044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Release process for 2.18 cancelled

2013-03-18 Thread Trevor Daniels
David Kastrup Monday, March 18, 2013 8:52 AM > > It turns out that the pent-up pressure to get forward-looking changes > into the master branch that have transitory user interfaces or extensive > changes of internals not exposed to sufficient testing is already too > high to permit a prerelease p

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-18 Thread Joseph Rushton Wakeling
On 03/17/2013 06:47 PM, thomasmorle...@googlemail.com wrote: > And while above the staff dynamic brackets have the hook down. As I said before, I'd have argued for that feature even in the absence of a Ferneyhough example, as it makes musical/notational sense. But I think the example settles it.

Re: Release process for 2.18 cancelled

2013-03-18 Thread Janek Warchoł
David, On Mon, Mar 18, 2013 at 9:52 AM, David Kastrup wrote: > > In the last week it has become abundantly clear that the last-minute > attempt for reaching the conditions suitable for making a stable release > occured too late to arrive at a releasable state. > [] > So a release process of 2

Release process for 2.18 cancelled

2013-03-18 Thread David Kastrup
In the last week it has become abundantly clear that the last-minute attempt for reaching the conditions suitable for making a stable release occured too late to arrive at a releasable state. The work I scheduled for myself for arriving at such a state consisted in dealing with several regression

Eliminates side poisition calculations for system-start-text grobs. (issue 7574048)

2013-03-18 Thread janek . lilypond
Whoah, Mike! I've understood your patch in first reading! Nice commit message. The spacing of system-star-text-interface implementing grobs used side typo (system-start-text) Also, we change the name of the list of elements used for alignment, as elements should only be used for axis groups