Re: Restore dots that overflow chords; issue 3179 (issue 8266047)

2013-04-09 Thread lemzwerg
LGTM, but one patch too much :-) https://codereview.appspot.com/8266047/diff/19001/ly/titling-init.ly File ly/titling-init.ly (left): https://codereview.appspot.com/8266047/diff/19001/ly/titling-init.ly#oldcode144 ly/titling-init.ly:144: Oops! Changes to this file probably don't belong to

Re: Remove remaining uses of \times (3301) (issue 8509043)

2013-04-09 Thread graham
LGTM https://codereview.appspot.com/8509043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some more documentation for \defaultchild (issue 8474044)

2013-04-09 Thread graham
LGTM https://codereview.appspot.com/8474044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Update essay to correct display of articulations (issue 8412044)

2013-04-09 Thread graham
LGTM https://codereview.appspot.com/8412044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add warning about using \relative with tagged music (3253) (issue 7798045)

2013-04-09 Thread graham
LGTM https://codereview.appspot.com/7798045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New Job

2013-04-09 Thread Jan Nieuwenhuizen
Reinhold Kainhofer writes: Dear Reinhold, I wish you all the best. LilyPond is an awesome project, and it was a lot of fun to be part of if. But I simply don't have the time any more to work on it. Good for you. Thanks a lot for all your efforts! See you around, or not, Greetings, Jan --

Re: New Job

2013-04-09 Thread Ian Hulin
Hi Reinhold, Congratulations on the your new job. :-) You'll be missed here in the Pond, here's hoping you'll have time in the future to dive back in again. Cheers, Ian Hulin ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: New Job

2013-04-09 Thread Francisco Vila
Dear Reinhold, Congratulations. These words from Ian pretty much express the same I'd want to say. Good luck! 2013/4/9 Ian Hulin i...@hulin.org.uk: Hi Reinhold, Congratulations on the your new job. :-) You'll be missed here in the Pond, here's hoping you'll have time in the future to dive

Re: Allows slurs to break at barlines. (issue 7424049)

2013-04-09 Thread k-ohara5a5a
On 2013/03/26 04:10:38, mike7 wrote: On 25 mars 2013, at 07:10, mailto:k-ohara5...@oco.net wrote: Please do just one manual review of the regression suite between versions before adding another test of this length. I wanted to exhaust as many possibilities as I could think of (broken slurs

Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

2013-04-09 Thread janek . lilypond
Changed as suggested. Janek https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely#newcode1632 Documentation/notation/vocal.itely:1632:

Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

2013-04-09 Thread tdanielsmusic
A couple of minor suggestions, otherwise LGTM Thanks, Janek! Trevor https://codereview.appspot.com/8384043/diff/10001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right):

Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

2013-04-09 Thread janek . lilypond
done. https://codereview.appspot.com/8384043/diff/10001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/10001/Documentation/notation/vocal.itely#newcode1632 Documentation/notation/vocal.itely:1632: cadence, or a

Re: Allows slurs to break at barlines. (issue 7424049)

2013-04-09 Thread m...@mikesolomon.org
On 9 avr. 2013, at 20:31, k-ohara5...@oco.net wrote: On 2013/03/26 04:10:38, mike7 wrote: On 25 mars 2013, at 07:10, mailto:k-ohara5...@oco.net wrote: Please do just one manual review of the regression suite between versions before adding another test of this length. I wanted to

Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

2013-04-09 Thread pkx166h
fails make https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely#newcode1641 Documentation/notation/vocal.itely:1641:

Re: Issue 3307: Rest positions incorrect with non-standard line count (issue 8580045)

2013-04-09 Thread k-ohara5a5a
You changed more than necessary to fix the reported bug. This is good because finally voiced r1-style whole rests are in the correct positions (which I confirmed with Ted Ross' book just to be careful). Quarter-rests and shorter look a bit odd now, on the even-line-count staves, as they are not