Re: Updating lilypap, and versions

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: "Devel" Sent: Saturday, April 13, 2013 12:44 AM Subject: Re: Updating lilypap, and versions On Fri, Apr 12, 2013 at 04:25:56PM +0100, Phil Holmes wrote: So I presume the first step to updating lilypad is to create a

skyline.cc: No zero-width empty buildings between buildings; issue 3311 (issue 8668044)

LGTM this is much clearer (and i think also better) than Mike's patch. https://codereview.appspot.com/8668044/diff/1/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/8668044/diff/1/lily/skyline.cc#newcode389 lily/skyline.cc:389: if (x1 > last_end) I suggest to add a

Re: Creates minor overlap in slur skyline buildings (issue 8723043)

Just a technical note: as this patch was superseded by http://codereview.appspot.com/8668044, please close this issue. https://codereview.appspot.com/8723043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

2013/4/13 Keith OHara : > On Fri, 12 Apr 2013 03:24:46 -0700, wrote: >> actually, placement of d4-.\downbow looks like a bug to me. Its too >> similar to square fermata. > > All the more reason to include it in the "changes" announcement. We would > not want this to surprise anyone. ok >> Anot

Makes arpeggio horizontal spacing similar to that of accidentals (issue 8708043)

The code looks reasonable to me; however, it's currently beyond my knowledge to say whether this is correct approach. Anyway, the description needs some more background information - why should arpeggio horizontal spacing be similar to that of accidentals? A summary of the discussion that took p

Re: Remove remaining uses of \times (3301) (issue 8509043)

LGTM https://codereview.appspot.com/8509043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some more documentation for \defaultchild (issue 8474044)

LGTM https://codereview.appspot.com/8474044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add warning about using \relative with tagged music (3253) (issue 7798045)

generally LGTM https://codereview.appspot.com/7798045/diff/5001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/7798045/diff/5001/Documentation/notation/input.itely#newcode2246 Documentation/notation/input.itely:2246: Calling @c

Re: Time signature before repeat bars at beginning of line; issue 828 (issue 8508043)

What if a non-repeat barline is placed after a break? Do i understand correctly that this patch will also place it after time sig, and is this what we want? Janek https://codereview.appspot.com/8508043/ ___ lilypond-devel mailing list lilypond-devel@

Add the command \offset to LilyPond (issue 8647044)

Reviewers: , Message: Please review. Thanks, David Description: Add the command \offset to LilyPond The ability to offset default values of various properties would be a useful enhancement of LilyPond. Currently, this is possible for the property 'control-points using the \shape command. The

Re: Add the command \offset to LilyPond (issue 8647044)

There's one thing that puzzles me. Current syntax is \offset property offset-value grob-name I understand that grob-name is at the end because it's optional, and we want to omit it when we're using \offset as a tweak. However, i find this syntax awkward. Since David K's change that allowed to u