Doc: elaborate explanation of accidentals within cadenzas (3078) (issue 8866043)

2013-04-20 Thread ianhulin44
LGTM apart from a Nitpick: "can" implies there just may be an option of the accidentals appearing in this case. So use "must" "have to" or "need to be". Cheers, Ian https://codereview.appspot.com/8866043/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right

Re: Flags cross-staff semi ties. (issue 8857043)

2013-04-20 Thread mtsolo
On 2013/04/19 12:40:43, Neil Puttock wrote: Hi Mike, Generally LGTM, but since there's nothing in the code which requires C++ code I favour adding a callback to output-lib.scm: (define-public (semi-tie::calc-cross-staff grob) (let* ((note-head (ly:grob-object grob 'note-head))

PATCHES - Countdown for April 23 - 19:00 GMt

2013-04-20 Thread James
hello *Countdown – April 23rd 2013 – 19:00 GMT* * * * * * * * * 3309 Enhancement Janek Warchol Push Patch: change Oct

Re: Adds padding around extender of line-spanners. (issue 8819043)

2013-04-20 Thread k-ohara5a5a
Remove the commented setting of minimum-Y-extent in scm/define-grobs.scm at the same time, because it no longer works and you are replacing it. https://codereview.appspot.com/8819043/diff/12001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspo

Re: Adds padding around extender of line-spanners. (issue 8819043)

2013-04-20 Thread David Kastrup
"m...@mikesolomon.org" writes: > On 20 avr. 2013, at 08:06, k-ohara5...@oco.net wrote: > >> >> https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc >> File lily/line-spanner.cc (right): >> >> https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371 >> li

Re: Adds padding around extender of line-spanners. (issue 8819043)

2013-04-20 Thread m...@mikesolomon.org
On 20 avr. 2013, at 08:06, k-ohara5...@oco.net wrote: > > https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc > File lily/line-spanner.cc (right): > > https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371 > lily/line-spanner.cc:371: // actual stencil

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2013-04-20 Thread k-ohara5a5a
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc File lily/side-position-interface.cc (right): https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc#newcode151 lily/side-position-interface.cc:151: // Commented out because of cross staf